[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380867519 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/HelixZkClient.java

[GitHub] [helix] narendly commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

narendly commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380874975 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/HelixZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380875510 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

narendly commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380875012 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/HelixZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380882410 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380862823 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/TrieRoutingData.java

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380862823 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/TrieRoutingData.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380867519 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/HelixZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380867519 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/HelixZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380868468 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/HelixZkClient.java

[GitHub] [helix] dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock

dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r380916271 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/ZKHelixNonblockingLock.java ## @@ -0,0 +1,145 @@

[GitHub] [helix] dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock

dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r380915772 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,109 @@ package

[GitHub] [helix] dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock

dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r380916833 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/ZKHelixNonblockingLock.java ## @@ -0,0 +1,145 @@

[GitHub] [helix] alirezazamani commented on a change in pull request #776: add CustomizedStateAggregation config

alirezazamani commented on a change in pull request #776: add CustomizedStateAggregation config URL: https://github.com/apache/helix/pull/776#discussion_r380914433 ## File path: helix-core/src/main/java/org/apache/helix/model/CustomizedStateAggregationConfig.java ## @@

[GitHub] [helix] alirezazamani commented on a change in pull request #776: add CustomizedStateAggregation config

alirezazamani commented on a change in pull request #776: add CustomizedStateAggregation config URL: https://github.com/apache/helix/pull/776#discussion_r380913969 ## File path: helix-core/src/main/java/org/apache/helix/model/CustomizedStateAggregationConfig.java ## @@

[GitHub] [helix] zhangmeng916 commented on a change in pull request #776: add CustomizedStateAggregation config

zhangmeng916 commented on a change in pull request #776: add CustomizedStateAggregation config URL: https://github.com/apache/helix/pull/776#discussion_r380952867 ## File path: helix-core/src/main/java/org/apache/helix/model/CustomizedStateAggregationConfig.java ## @@

[GitHub] [helix] narendly commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

narendly commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380935789 ## File path:

[GitHub] [helix] mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock

mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r380960097 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/ZKHelixNonblockingLock.java ## @@ -0,0 +1,145 @@ +/*

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380959695 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380862050 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

dasahcc commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380857248 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

dasahcc commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380858300 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/TrieRoutingData.java

[GitHub] [helix] narendly opened a new issue #777: Create rest-common module for all REST services

narendly opened a new issue #777: Create rest-common module for all REST services URL: https://github.com/apache/helix/issues/777 Since there will be two services that will be deployed in a RESTful way, we could refactor the common JAX-RS rest startable logic out into a common module

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380961009 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380966871 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380966871 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] pkuwm commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

pkuwm commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380968738 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.java

[GitHub] [helix] pkuwm commented on a change in pull request #775: WIP: Add HttpRoutingDataReader

pkuwm commented on a change in pull request #775: WIP: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r381014954 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,81 @@

[GitHub] [helix] pkuwm commented on a change in pull request #775: WIP: Add HttpRoutingDataReader

pkuwm commented on a change in pull request #775: WIP: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r381014832 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,81 @@

[GitHub] [helix] pkuwm commented on a change in pull request #775: WIP: Add HttpRoutingDataReader

pkuwm commented on a change in pull request #775: WIP: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r381008006 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,81 @@

[GitHub] [helix] dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock

dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r381032011 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,106 @@ package

[GitHub] [helix] dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock

dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r381032659 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,106 @@ package

[GitHub] [helix] dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock

dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r381031816 ## File path: helix-lock/src/main/java/org/apache/helix/lock/HelixLock.java ## @@ -22,7 +22,7 @@ /** * Generic

[GitHub] [helix] dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock

dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r381031871 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,106 @@ package

[GitHub] [helix] mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock

mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r380962857 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/ZKHelixNonblockingLock.java ## @@ -0,0 +1,145 @@ +/*

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380989661 ## File path:

[GitHub] [helix] NealSun96 commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

NealSun96 commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r380992746 ## File path:

[GitHub] [helix] pkuwm opened a new issue #779: Implement FederatedZkClient to Support Multi-Realm CRUD and Callback

pkuwm opened a new issue #779: Implement FederatedZkClient to Support Multi-Realm CRUD and Callback URL: https://github.com/apache/helix/issues/779 FederatedZkClient (One FederatedZkClient, multiple Zookeeper sessions inside) - Some Helix Java APIs such as HelixAdmin can only perform

[GitHub] [helix] zhangmeng916 commented on a change in pull request #776: add CustomizedStateAggregation config

zhangmeng916 commented on a change in pull request #776: add CustomizedStateAggregation config URL: https://github.com/apache/helix/pull/776#discussion_r380982556 ## File path: helix-core/src/main/java/org/apache/helix/model/CustomizedStateAggregationConfig.java ## @@

[GitHub] [helix] kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory

kaisun2000 commented on a change in pull request #770: WIP: Add SharedZkClient and update SharedZkClientFactory URL: https://github.com/apache/helix/pull/770#discussion_r380961009 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] NealSun96 opened a new issue #778: Add leader request forwarding for ZkRoutingDataWriter

NealSun96 opened a new issue #778: Add leader request forwarding for ZkRoutingDataWriter URL: https://github.com/apache/helix/issues/778 Due to the potential concurrency issues raised by multiple writes to ZooKeeper, we have decided on the design of having one single writer for

[GitHub] [helix] pkuwm commented on a change in pull request #775: WIP: Add HttpRoutingDataReader

pkuwm commented on a change in pull request #775: WIP: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r381014954 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,81 @@

[GitHub] [helix] pkuwm commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

pkuwm commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380968738 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.java

[GitHub] [helix] pkuwm commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

pkuwm commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r380963631 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.java

[GitHub] [helix] pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r381000691 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock

dasahcc commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r381031248 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,109 @@ package

[GitHub] [helix] mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock

mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r380964332 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,109 @@ package

[GitHub] [helix] NealSun96 commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

NealSun96 commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r380994410 ## File path:

[GitHub] [helix] NealSun96 commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

NealSun96 commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r380997605 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r381044344 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r381053697 ## File path:

[GitHub] [helix] narendly merged pull request #759: Add validation logic to MSD write operations

narendly merged pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [helix] zhangmeng916 opened a new pull request #776: add CustomizedStateAggregation config

zhangmeng916 opened a new pull request #776: add CustomizedStateAggregation config URL: https://github.com/apache/helix/pull/776 ### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: (#728 ) ### Description - [X]

[GitHub] [helix] NealSun96 commented on issue #759: Add validation logic to MSD write operations

NealSun96 commented on issue #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#issuecomment-587580298 This PR is ready to be merged, approved by @narendly Final commit message: ## Add validation logic to MSD write operations ## This PR

[GitHub] [helix] NealSun96 commented on issue #772: Unexpected randomness in the WAGED rebalancer partition assignment

NealSun96 commented on issue #772: Unexpected randomness in the WAGED rebalancer partition assignment URL: https://github.com/apache/helix/issues/772#issuecomment-587599600 Please assign this issue to me, @jiajunwang , thank you!