[GitHub] [helix] dasahcc commented on a change in pull request #908: Make Helix REST realm-aware

dasahcc commented on a change in pull request #908: Make Helix REST realm-aware URL: https://github.com/apache/helix/pull/908#discussion_r39805 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ## @@ -20,42 +20,67 @@ * under the L

[GitHub] [helix] narendly commented on a change in pull request #908: Make Helix REST realm-aware

narendly commented on a change in pull request #908: Make Helix REST realm-aware URL: https://github.com/apache/helix/pull/908#discussion_r398066168 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ## @@ -20,42 +20,67 @@ * under the

[GitHub] [helix] zhangmeng916 commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation

zhangmeng916 commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation URL: https://github.com/apache/helix/pull/851#discussion_r398114728 ## File path: helix-core/src/main/java/org/apache/helix/controller/Gener

[GitHub] [helix] zhangmeng916 commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation

zhangmeng916 commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation URL: https://github.com/apache/helix/pull/851#discussion_r398115507 ## File path: helix-core/src/main/java/org/apache/helix/controller/Gener

[GitHub] [helix] jiajunwang commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation

jiajunwang commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation URL: https://github.com/apache/helix/pull/851#discussion_r398143820 ## File path: helix-core/src/main/java/org/apache/helix/controller/Generic

[GitHub] [helix] jiajunwang commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation

jiajunwang commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation URL: https://github.com/apache/helix/pull/851#discussion_r398144033 ## File path: helix-core/src/main/java/org/apache/helix/controller/Generic

[GitHub] [helix] zhangmeng916 commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation

zhangmeng916 commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation URL: https://github.com/apache/helix/pull/851#discussion_r398157359 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/Callb

[GitHub] [helix] zhangmeng916 commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation

zhangmeng916 commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation URL: https://github.com/apache/helix/pull/851#discussion_r398159643 ## File path: helix-core/src/main/java/org/apache/helix/controller/stage

[GitHub] [helix] zhangmeng916 commented on a change in pull request #869: Replace customized view cache with property cache

zhangmeng916 commented on a change in pull request #869: Replace customized view cache with property cache URL: https://github.com/apache/helix/pull/869#discussion_r397458124 ## File path: helix-core/src/test/java/org/apache/helix/integration/spectator/TestRoutingTableProvider.java

[GitHub] [helix] zhangmeng916 commented on issue #851: Modify Helix generic controller to include new stage for customized view aggregation

zhangmeng916 commented on issue #851: Modify Helix generic controller to include new stage for customized view aggregation URL: https://github.com/apache/helix/pull/851#issuecomment-604083600 This PR is ready to merge, approved by @jiajunwang Final commit message: Add new stages in H

[GitHub] [helix] jiajunwang merged pull request #851: Modify Helix generic controller to include new stage for customized view aggregation

jiajunwang merged pull request #851: Modify Helix generic controller to include new stage for customized view aggregation URL: https://github.com/apache/helix/pull/851 This is an automated message from the Apache Git Service

[GitHub] [helix] zhangmeng916 closed pull request #780: Add customized state aggregation to Helix controller (WIP)

zhangmeng916 closed pull request #780: Add customized state aggregation to Helix controller (WIP) URL: https://github.com/apache/helix/pull/780 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [helix] pkuwm opened a new issue #910: Unit test TestZNRecordSerializeWriteSizeLimit fails

pkuwm opened a new issue #910: Unit test TestZNRecordSerializeWriteSizeLimit fails URL: https://github.com/apache/helix/issues/910 Test log: ``` testZNRecordSerializerWriteSizeLimit(org.apache.helix.zookeeper.datamodel.serializer.TestZNRecordSerializeWriteSizeLimit) Time elapsed: 0

[GitHub] [helix] pkuwm opened a new pull request #911: Fix TestZNRecordSerializeWriteSizeLimit

pkuwm opened a new pull request #911: Fix TestZNRecordSerializeWriteSizeLimit URL: https://github.com/apache/helix/pull/911 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Fixes #910 ### Description - [ ] He

[GitHub] [helix] mgao0 opened a new pull request #912: Add integration test to customized view aggregation

mgao0 opened a new pull request #912: Add integration test to customized view aggregation URL: https://github.com/apache/helix/pull/912 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: This PR added an integration test to

[GitHub] [helix] narendly commented on issue #908: Make Helix REST realm-aware

narendly commented on issue #908: Make Helix REST realm-aware URL: https://github.com/apache/helix/pull/908#issuecomment-604234992 This PR is ready to be merged, approved by @dasahcc This is an automated message from the Apac

[GitHub] [helix] narendly commented on issue #908: Make Helix REST realm-aware

narendly commented on issue #908: Make Helix REST realm-aware URL: https://github.com/apache/helix/pull/908#issuecomment-604235186 Helix REST needs to start using a realm-aware ZkClient on multi-zk mode. Also it needs to become a listener on routing data because we don't want to restart th

[GitHub] [helix] narendly merged pull request #908: Make Helix REST realm-aware

narendly merged pull request #908: Make Helix REST realm-aware URL: https://github.com/apache/helix/pull/908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [helix] pkuwm commented on issue #911: Fix TestZNRecordSerializeWriteSizeLimit

pkuwm commented on issue #911: Fix TestZNRecordSerializeWriteSizeLimit URL: https://github.com/apache/helix/pull/911#issuecomment-604235542 This PR is ready to be merged, approved by @narendly ``` There was a exception type change in znrecord serializers: ZkClientException -> ZkMarsh

[GitHub] [helix] zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation

zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation URL: https://github.com/apache/helix/pull/912#discussion_r398325974 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java #

[GitHub] [helix] zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation

zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation URL: https://github.com/apache/helix/pull/912#discussion_r398325124 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java #

[GitHub] [helix] zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation

zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation URL: https://github.com/apache/helix/pull/912#discussion_r398326958 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java #

[GitHub] [helix] zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation

zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation URL: https://github.com/apache/helix/pull/912#discussion_r398324255 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java #

[GitHub] [helix] zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation

zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation URL: https://github.com/apache/helix/pull/912#discussion_r39832 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java #

[GitHub] [helix] zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation

zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation URL: https://github.com/apache/helix/pull/912#discussion_r398324732 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java #

[GitHub] [helix] zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation

zhangmeng916 commented on a change in pull request #912: Add integration test to customized view aggregation URL: https://github.com/apache/helix/pull/912#discussion_r398322393 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java #