[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-03-01 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. IMPALA-4430: Update build scripts to

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9446 to look at the new patch set (#5). Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() ..

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-6594: skip tests on local fs

2018-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: skip tests on local fs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-03-01 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. IMPAL-4430: Update build scripts to die

[Impala-ASF-CR] Review comments

2018-03-01 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9464 Change subject: Review comments .. Review comments Change-Id: I15fcab44052aa98e19343746bc07bfdffe663a0e --- M buildall.sh 1 file

[Impala-ASF-CR] Review comments

2018-03-01 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has abandoned this change. ( http://gerrit.cloudera.org:8080/9464 ) Change subject: Review comments .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9464 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 5: Code-Review+2 This looks good. Not for this change, but

[Impala-ASF-CR] IMPALA-6594: fix tests on local fs

2018-03-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: fix tests on local fs .. IMPALA-6594: fix tests on local fs Skip most mem_usage_scaling

[Impala-ASF-CR] IMPALA-6594: fix tests on local fs

2018-03-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: fix tests on local fs .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-03-01 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6594: fix tests on local fs

2018-03-01 Thread Tim Armstrong (Code Review)
Hello David Knupp, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9463 to look at the new patch set (#3). Change subject: IMPALA-6594: fix tests on local fs

[Impala-ASF-CR] IMPALA-6594: skip tests on local fs

2018-03-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: skip tests on local fs .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6594: skip tests on local fs

2018-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: skip tests on local fs .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9463/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

2018-03-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters .. Patch Set 6: Code-Review+1 I'm good with this change.

[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files

2018-03-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 4: Code-Review+1 John, are you happy with the changes?

[Impala-ASF-CR] IMPALA-6594: skip tests on local fs

2018-03-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: skip tests on local fs .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6547: [DOCS] Correct default encoding for INT

2018-03-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9402 ) Change subject: IMPALA-6547: [DOCS] Correct default encoding for INT .. Patch Set 1: Code-Review+1 Makes sense to me. Todd can confirm

[Impala-ASF-CR] IMPALA-6585: increase test low mem limit q21 limit

2018-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9449 ) Change subject: IMPALA-6585: increase test_low_mem_limit_q21 limit .. Patch Set 1: Code-Review+2 > FWIW, IMPALA-2567 is blocked by this.

[Impala-ASF-CR] IMPALA-6594: skip tests on local fs

2018-03-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: skip tests on local fs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6585: increase test low mem limit q21 limit

2018-03-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9449 ) Change subject: IMPALA-6585: increase test_low_mem_limit_q21 limit .. Patch Set 2: Yeah I agree we should consider whether we can do

[Impala-ASF-CR] IMPALA-6585: increase test low mem limit q21 limit

2018-03-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9449 ) Change subject: IMPALA-6585: increase test_low_mem_limit_q21 limit .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6594: skip tests on local fs

2018-03-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: skip tests on local fs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-03-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9346 ) Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6594: fix tests on local fs

2018-03-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: fix tests on local fs .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 10: How was this tested? (Add to

[Impala-ASF-CR] IMPALA-6594: fix tests on local fs

2018-03-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: fix tests on local fs .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-03-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. IMPALA-6554: Fix a race in DequeueDeferredRpc()

[Impala-ASF-CR] IMPALA-6585: increase test low mem limit q21 limit

2018-03-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9449 ) Change subject: IMPALA-6585: increase test_low_mem_limit_q21 limit .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6585: increase test low mem limit q21 limit

2018-03-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9449 ) Change subject: IMPALA-6585: increase test_low_mem_limit_q21 limit .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6594: skip tests on local fs

2018-03-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: skip tests on local fs .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 2: Once this is checked in, please verify that impala is configured with

[Impala-ASF-CR] IMPALA-6594: skip tests on local fs

2018-03-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: skip tests on local fs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9463

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-03-01 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. IMPAL-4430: Update build scripts to die

[Impala-ASF-CR] IMPALA-6594: skip tests on local fs

2018-03-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: skip tests on local fs .. Patch Set 2: -Code-Review aborted merge -- To view, visit

[Impala-ASF-CR] IMPALA-6594: fix tests on local fs

2018-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9463 ) Change subject: IMPALA-6594: fix tests on local fs .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9463