[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 7: (7 comments) Mostly minor comments. http://gerrit.clo

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-07-07 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16000 to look at the new patch set (#15). Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-07-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 15: Apparently, test_ddl.py/test_functions_dd

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 16: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 15: Build Successful https://jenkin

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 1 Reading modified tables (primitive types)

2020-07-07 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16082 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 1 Reading modified tables (primitive types) .. Patch Set 10: (9 comments)

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-07 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I did the test on parquet/none/none, scale factor

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 16: Verified-1 Build failed: https://

[Impala-ASF-CR] IMPALA-9531: Dropped support for dateless timestamps

2020-07-07 Thread Adam Tamas (Code Review)
Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/15866 ) Change subject: IMPALA-9531: Dropped support for dateless timestamps .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-9531: Dropped support for dateless timestamps

2020-07-07 Thread Adam Tamas (Code Review)
Adam Tamas has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/15866 ) Change subject: IMPALA-9531: Dropped support for dateless timestamps .. IMPALA-9531: Dropped support for dateless timestamps Removed the s

[Impala-ASF-CR] IMPALA-9531: Dropped support for dateless timestamps

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15866 ) Change subject: IMPALA-9531: Dropped support for dateless timestamps .. Patch Set 10: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-9531: Dropped support for dateless timestamps

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15866 ) Change subject: IMPALA-9531: Dropped support for dateless timestamps .. Patch Set 11: Build started: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-9531: Dropped support for dateless timestamps

2020-07-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15866 ) Change subject: IMPALA-9531: Dropped support for dateless timestamps .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] POC: Remote codegen (Milestone 1)

2020-07-07 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14735 ) Change subject: POC: Remote codegen (Milestone 1) .. POC: Remote codegen (Milestone 1) Optional remote codegen, set by a query option. C

[Impala-ASF-CR] POC: Remote codegen (Milestone 1)

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14735 ) Change subject: POC: Remote codegen (Milestone 1) .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/14735/5/be

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 16: Verified+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-07-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 16: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-07-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. IMPALA-9632: Implement ds_hll_sketch() and ds_hl

[Impala-ASF-CR] POC: Remote codegen (Milestone 1)

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14735 ) Change subject: POC: Remote codegen (Milestone 1) .. Patch Set 5: Build Failed https://jenkins.impala.io/job/gerrit-code-revi

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 1 Reading modified tables (primitive types)

2020-07-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Aman Sinha, Quanlong Huang, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16082 to look at the new patch set (#11). Change subject: IMPALA-9859: Full ACID Milestone 4: Part 1 Reading modified tables (primitive t

[Impala-ASF-CR] IMPALA-9633: Implement ds hll union()

2020-07-07 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16095 to look at the new patch set (#3). Change subject: IMPALA-9633: Implement ds_hll_union() .

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 1 Reading modified tables (primitive types)

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16082 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 1 Reading modified tables (primitive types) .. Patch Set 11: (1 comm

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 1 Reading modified tables (primitive types)

2020-07-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16082 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 1 Reading modified tables (primitive types) .. Patch Set 11: (12 comment

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 1 Reading modified tables (primitive types)

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16082 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 1 Reading modified tables (primitive types) .. Patch Set 11: Build S

[Impala-ASF-CR] IMPALA-9633: Implement ds hll union()

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16095 ) Change subject: IMPALA-9633: Implement ds_hll_union() .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-c

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 17: Build started: https://jenkins.im

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 17: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 16: Hit IMPALA-9923 -- To view, visit http:

[Impala-ASF-CR] IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16146 ) Change subject: IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs .. Patch Set 1: Code-Review+2 -- To v

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 4: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 4: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I was a little scared since Q1 is a decimal-inten

[Impala-ASF-CR] IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState

2020-07-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16122 ) Change subject: IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState .. Patch Set 3: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-07 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 10: (1 comment) > Uploaded patch set 10. http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-9294: Support DATE for min-max runtime filter

2020-07-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16103 ) Change subject: IMPALA-9294: Support DATE for min-max runtime filter .. Patch Set 6: (5 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-9531: Dropped support for dateless timestamps

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15866 ) Change subject: IMPALA-9531: Dropped support for dateless timestamps .. Patch Set 11: Verified-1 Build failed: https://jenkins

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/16

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#8). Change subject: IMPALA-9917: grouping() and grouping_id() support

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 8: Oh I missed the logical view comment, will think abo

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 8: I added a couple of basic view compatibility tests.

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#9). Change subject: IMPALA-9917: grouping() and grouping_id() support

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#10). Change subject: IMPALA-9917: grouping() and grouping_id() support ...

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 8: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 9: Build Successful https://jenkins.impala.io/

[native-toolchain-CR] Remove colon from filename

2020-07-07 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/16139 ) Change subject: Remove colon from filename .. Patch Set 1: Code-Review+2 LGTM. Would there be an easy way to fix the process that emits

[Impala-ASF-CR] IMPALA-9633: Implement ds hll union()

2020-07-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16095 ) Change subject: IMPALA-9633: Implement ds_hll_union() .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16095/4/be/s

[Impala-ASF-CR] IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors

2020-07-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16148 Change subject: IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors .. IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors Fixed two

[Impala-ASF-CR] IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16148 ) Change subject: IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors .. Patch Set 1: (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 10: Code-Review+1 (2 comments) LGTM. http://gerrit.cloud

[Impala-ASF-CR] IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16148 ) Change subject: IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors .. Patch Set 1: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-9834: De-flake TestQueryRetries on EC builds

2020-07-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16149 Change subject: IMPALA-9834: De-flake TestQueryRetries on EC builds .. IMPALA-9834: De-flake TestQueryRetries on EC builds This patch ma

[Impala-ASF-CR] IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors

2020-07-07 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16148 to look at the new patch set (#2). Change subject: IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors ..

[Impala-ASF-CR] IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors

2020-07-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16148 ) Change subject: IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. IMPALA-9897: GROUPING SETS/CUBE/ROLLUP p

[Impala-ASF-CR] IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 ) Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis .. Patch Set 17: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-9834: De-flake TestQueryRetries on EC builds

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16149 ) Change subject: IMPALA-9834: De-flake TestQueryRetries on EC builds .. Patch Set 1: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16148 ) Change subject: IMPALA-9855, IMPALA-9854: Fix query retry TSAN errors .. Patch Set 2: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#11). Change subject: IMPALA-9917: grouping() and grouping_id() support ...

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-07 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Quanlong Huang, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#11). Change subject: IMPALA-9898: generate grouping set plans ...

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#12). Change subject: IMPALA-9917: grouping() and grouping_id() support ...

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 11: Code-Review+1 rebased onto latest master -- To view, visit

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 12: Code-Review+1 rebased onto latest master -- To vi

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 12: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 11: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 4: Verified-1 Build failed: https://jenkins.

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 11: Build Successful https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 12: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16122 ) Change subject: IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState .. Patch Set 5: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState

2020-07-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16122 ) Change subject: IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState .. Patch Set 4: Code-Review+2 carrying forward

[Impala-ASF-CR] IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16122 ) Change subject: IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState .. Patch Set 5: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-3380: Add a timeout for statestore RPCs

2020-07-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16150 Change subject: IMPALA-3380: Add a timeout for statestore RPCs .. IMPALA-3380: Add a timeout for statestore RPCs Adds the following star

[Impala-ASF-CR] IMPALA-3380: Add a timeout for statestore RPCs

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16150 ) Change subject: IMPALA-3380: Add a timeout for statestore RPCs .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-07 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. IMPALA-9744: Treat corrupt table stats as missing

[Impala-ASF-CR] IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16146 ) Change subject: IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs .. Patch Set 2: Code-Review+2

[Impala-ASF-CR] IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16146 ) Change subject: IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-3380: Add a timeout for statestore RPCs

2020-07-07 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16150 to look at the new patch set (#2). Change subject: IMPALA-3380: Add a timeout for statestore RPCs .

[Impala-ASF-CR] IMPALA-3380: Add a timeout for statestore RPCs

2020-07-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16150 ) Change subject: IMPALA-3380: Add a timeout for statestore RPCs .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16150/

[Impala-ASF-CR] IMPALA-3380: Add a timeout for statestore RPCs

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16150 ) Change subject: IMPALA-3380: Add a timeout for statestore RPCs .. Patch Set 1: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 14: Build Successful https

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-07 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 14: > Uploaded patch set 14. -- To v

[Impala-ASF-CR] IMPALA-3380: Add a timeout for statestore RPCs

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16150 ) Change subject: IMPALA-3380: Add a timeout for statestore RPCs .. Patch Set 2: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-9294: Support DATE for min-max runtime filter

2020-07-07 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16103 ) Change subject: IMPALA-9294: Support DATE for min-max runtime filter .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-9294: Support DATE for min-max runtime filter

2020-07-07 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16103 ) Change subject: IMPALA-9294: Support DATE for min-max runtime filter .. IMPALA-9294: Support DATE for min-max runtime filter Implemented D

[Impala-ASF-CR] IMPALA-9294: Support DATE for min-max runtime filter

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16103 ) Change subject: IMPALA-9294: Support DATE for min-max runtime filter .. Patch Set 8: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 12: Verified+1 -- To view, visit http://gerrit

[native-toolchain-CR] Remove colon from filename

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16139 ) Change subject: Remove colon from filename .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16139 To unsu

[native-toolchain-CR] Remove colon from filename

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16139 ) Change subject: Remove colon from filename .. Remove colon from filename Some OSes don't allow cloning the repo if it has a fi

[native-toolchain-CR] Remove colon from filename

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16139 ) Change subject: Remove colon from filename .. Patch Set 2: I'm not sure - these patches are usually manually generated so not sure wha

[Impala-ASF-CR] IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16122 ) Change subject: IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState .. IMPALA-9692 (part 4): Rename QuerySchedu

[Impala-ASF-CR] IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16122 ) Change subject: IMPALA-9692 (part 4): Rename QuerySchedule to ScheduleState .. Patch Set 5: Verified+1 -- To view, visit http

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16146 ) Change subject: IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs .. Patch Set 2: Verified+1 --

[Impala-ASF-CR] IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16146 ) Change subject: IMPALA-9921: Change error messages in checking needsQuotes to TRACE level logs .. IMPALA-9921: Change

[Impala-ASF-CR] IMPALA-9531: Dropped support for dateless timestamps

2020-07-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15866 ) Change subject: IMPALA-9531: Dropped support for dateless timestamps .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/