[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#21) to the change originally created by Vuk Ercegovac. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. IMPALA-4993:

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-3998: Remove refresh after connect option from shell

2018-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9072 ) Change subject: IMPALA-3998: Remove refresh_after_connect option from shell .. IMPALA-3998: Remove refresh_after_connect option from shell

[Impala-ASF-CR] IMPALA-6422: Use ldexp() instead of powf() in HLL.

2018-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9078 ) Change subject: IMPALA-6422: Use ldexp() instead of powf() in HLL. .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] Bumping version to 3.0.

2018-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9044 ) Change subject: Bumping version to 3.0. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9044 To unsubs

[Impala-ASF-CR] IMPALA-6422: Use ldexp() instead of powf() in HLL.

2018-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9078 ) Change subject: IMPALA-6422: Use ldexp() instead of powf() in HLL. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6427: fix QUERYOPTIONS in planner test output

2018-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9081 Change subject: IMPALA-6427: fix QUERYOPTIONS in planner test output .. IMPALA-6427: fix QUERYOPTIONS in planner test output Testing: Ra

[Impala-ASF-CR] IMPALA-6092: turn off flaky test temporarily.

2018-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9080 ) Change subject: IMPALA-6092: turn off flaky test temporarily. .. Patch Set 1: Let's file a follow-up JIRA to re-enable this as a releas

[Impala-ASF-CR] IMPALA-6092: turn off flaky test temporarily.

2018-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9080 ) Change subject: IMPALA-6092: turn off flaky test temporarily. .. Patch Set 1: If that's required to re-enable the test. My perspective

[Impala-ASF-CR] IMPALA-6092: turn off flaky test temporarily.

2018-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9080 ) Change subject: IMPALA-6092: turn off flaky test temporarily. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6092: run flaky test serially (temporary).

2018-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9080 ) Change subject: IMPALA-6092: run flaky test serially (temporary). .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8972 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 7: (1 comment) Thank you for the patch! It looks go

[Impala-ASF-CR] IMPALA-3998: Remove refresh after connect option from shell

2018-01-22 Thread Tim Armstrong (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9072 to look at the new patch set (#3). Change subject: IMPALA-3998: Remove refresh_after_connect option from shell .

[Impala-ASF-CR] IMPALA-3998: Remove refresh after connect option from shell

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9072 ) Change subject: IMPALA-3998: Remove refresh_after_connect option from shell .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9097 Change subject: IMPALA-4835: prerequisite buffer pool changes .. IMPALA-4835: prerequisite buffer pool changes The scanner/buffer pool c

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-01-22 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#20). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation ...

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit h

[Impala-ASF-CR] PREVIEW: IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#9). Change subject: PREVIEW: IMPALA-4835: Part 3: switch I/O buffers to buffer pool

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 20: Code-Review+2 carry -- To view, visi

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 1: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: I'll go ahead and merge this unless there are any remaining co

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 1: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] [DOCS] Doc for MURMUR HASH() function

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9058 ) Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. Patch Set 1: Code-Review+1 -- To view, visit http://

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 6: Is this ready to merge? -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#10). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 10: This is now ready for review. There might still

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/890

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9097 ) Change subject: IMPALA-4835: prerequisite buffer pool changes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9097/1/b

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9097 to look at the new patch set (#2). Change subject: IMPALA-4835: prerequisite buffer pool changes .. IMPALA-4835: p

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-23 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#11). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 11: Fixed the remaining core tests. -- To view, v

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 4: Anyone want to do a +2 review? -- To view,

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9102/3

[Impala-ASF-CR] [DOCS] IMPALA-6105 unix timestamp returns a number of seconds

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9084 ) Change subject: [DOCS] IMPALA-6105 unix_timestamp returns a number of seconds .. Patch Set 2: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 9: Code-Review+1 LGTM. Might be good if Sailesh had

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 2: (1 comment) I think the usage LibCacheEntry* interface

[Impala-ASF-CR] InMPALA-4319: remove some deprecated query options

2018-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9118 Change subject: InMPALA-4319: remove some deprecated query options .. InMPALA-4319: remove some deprecated query options These query opt

[native-toolchain-CR] Build old versions of gperftools and thrift.

2018-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9122 ) Change subject: Build old versions of gperftools and thrift. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 5: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-6441: update explain string for stress test

2018-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9141 ) Change subject: IMPALA-6441: update explain string for stress test .. Patch Set 1: Code-Review+2 Thanks for fixing and sorry for breaki

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 2: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 12: (10 comments) Sorry for the delay here. This

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 8: I probably won't have a chance to look throug

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9097 ) Change subject: IMPALA-4835: prerequisite buffer pool changes .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9097/2/

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-28 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9097 to look at the new patch set (#3). Change subject: IMPALA-4835: prerequisite buffer pool changes .. IM

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9097 ) Change subject: IMPALA-4835: prerequisite buffer pool changes .. Patch Set 4: Code-Review+2 Carry +2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-28 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9118 to look at the new patch set (#4). Change subject: IMPALA-4319: remove some deprecated query options .. IMPALA-4319:

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-28 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9118 to look at the new patch set (#5). Change subject: IMPALA-4319: remove some deprecated query options .. IMPALA-4319:

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-28 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#19). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 18: (6 comments) LMK if there's somethign that c

[native-toolchain-CR] Make file upload/downlad progress report less verbose

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9149 ) Change subject: Make file upload/downlad progress report less verbose .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/9089/4

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-29 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9118 to look at the new patch set (#6). Change subject: IMPALA-4319: remove some deprecated query options .. IM

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-29 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9118 to look at the new patch set (#7). Change subject: IMPALA-4319: remove some deprecated query options .. IM

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9118

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9118

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 5: Code-Review+2 (1 comment) LGTM unless Dan feels strongl

[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9155 Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. IMPALA-6450: loosen DCHECK in EventSequence::Start() It looks li

[Impala-ASF-CR] IMPALA-6450: loosen DCHECK in EventSequence::Start()

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-29 Thread Tim Armstrong (Code Review)
Hello Lars Volker, anujphadke, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9155 to look at the new patch set (#2). Change subject: IMPALA-6450: fix EventSequence::Start() ..

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: fix EventSequence::Start() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9155/1/be/src/

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/915

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: fix EventSequence::Start() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9155/2/be/src/

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-30 Thread Tim Armstrong (Code Review)
Hello Lars Volker, anujphadke, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9155 to look at the new patch set (#3). Change subject: IMPALA-6450: fix EventSequence::Start() ..

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-30 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#20). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 20: Code-Review+1 Carry Tianyi's +1 -- To view,

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 8: Code-Review+2 carry dan's +2 -- To view, visit http

[Impala-ASF-CR] IMPALA-6437: seperate AC/scheduler from catalog topic updates

2018-01-30 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9123 to look at the new patch set (#9). Change subject: IMPALA-6437: seperate AC/scheduler from catalog topic updates ...

[Impala-ASF-CR] IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-01-30 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9123 to look at the new patch set (#10). Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates ..

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9153

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 17: (2 comments) Looks good, just had a couple of clar

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 8: Hit IMPALA-6455 and a test_decimal_fuzz failure. Also

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-30 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9118 to look at the new patch set (#9). Change subject: IMPALA-4319: remove some deprecated query options ...

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 9: Code-Review+2 carry -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: fix EventSequence::Start() .. Patch Set 3: Hit IMPALA-6455 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 5: (4 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6455: unique tmpdirs for test partition metadata compatibility

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9165 Change subject: IMPALA-6455: unique tmpdirs for test_partition_metadata_compatibility .. IMPALA-6455: unique tmpdirs for test_partition_

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-31 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9118 to look at the new patch set (#11). Change subject: IMPALA-4319: remove some deprecated query options ..

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 11: Code-Review+2 Hit a merge conflict -- To view, vis

[Impala-ASF-CR] IMPALA-6455: unique tmpdirs for test partition metadata compatibility

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9165 ) Change subject: IMPALA-6455: unique tmpdirs for test_partition_metadata_compatibility .. Patch Set 1: Started the precommit tests to h

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6455: unique tmpdirs for test partition metadata compatibility

2018-01-31 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9165 to look at the new patch set (#2). Change subject: IMPALA-6455: unique tmpdirs for test_partition_metadata_compatibility .

[Impala-ASF-CR] IMPALA-6455: unique tmpdirs for test partition metadata compatibility

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9165 ) Change subject: IMPALA-6455: unique tmpdirs for test_partition_metadata_compatibility .. Patch Set 1: (2 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-6455: unique tmpdirs for test partition metadata compatibility

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9165 ) Change subject: IMPALA-6455: unique tmpdirs for test_partition_metadata_compatibility .. Patch Set 2: I cancelled the previous GVD mys

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-31 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#12). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/

  1   2   3   4   5   6   7   8   9   10   >