[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 1: Code-Review+1 (1 comment) I'm

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 ) Change subject: IMPALA-6241: timeout in admission control test under ASAN .. Patch Set 3: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8639 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

2017-11-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8652 Change subject: IMPALA-6241: timeout in admission control test under ASAN .. IMPALA-6241: timeout in admission control test under ASAN

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6227: deflake admission stress tests

2017-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8631 ) Change subject: IMPALA-6227: deflake admission stress tests .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6227: deflake admission stress tests

2017-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8631 ) Change subject: IMPALA-6227: deflake admission stress tests .. Patch Set 5: Code-Review+2 Carry -- To view, visit

[Impala-ASF-CR] IMPALA-6227: deflake admission stress tests

2017-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8631 ) Change subject: IMPALA-6227: deflake admission stress tests .. Patch Set 6: Code-Review+2 Trivial test fix -- To view, visit

[Impala-ASF-CR] IMPALA-6227: deflake admission stress tests

2017-11-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8631 to look at the new patch set (#6). Change subject: IMPALA-6227: deflake admission stress tests

[Impala-ASF-CR] IMPALA-6227: deflake admission stress tests

2017-11-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8631 to look at the new patch set (#2). Change subject: IMPALA-6227: deflake admission stress tests ..

[Impala-ASF-CR] IMPALA-6227: deflake admission stress tests

2017-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8631 ) Change subject: IMPALA-6227: deflake admission stress tests .. Patch Set 3: (1 comment) Just to summarise where this is at, it's a

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 3: I need to get back to this one after the

[Impala-ASF-CR] IMPALA-6227: deflake admission stress tests

2017-11-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8631 to look at the new patch set (#4). Change subject: IMPALA-6227: deflake admission stress tests ..

[Impala-ASF-CR] IMPALA-6227: deflake admission stress tests

2017-11-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8631 to look at the new patch set (#5). Change subject: IMPALA-6227: deflake admission stress tests ..

[Impala-ASF-CR] IMPALA-6227: deflake admission stress tests

2017-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8631 ) Change subject: IMPALA-6227: deflake admission stress tests .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 17: This is still on my radar, need to get

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 ) Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. Patch Set 1: (2 comments) The code looks

[Impala-ASF-CR] Update incubator-impala -> impala URLs

2017-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8685 Change subject: Update incubator-impala -> impala URLs .. Update incubator-impala -> impala URLs This fixes push_to_asf.py and various

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 4: Nice repro! -- To view, visit

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8669 ) Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Remove "incubator-" from URLs.

2017-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8698 ) Change subject: Remove "incubator-" from URLs. .. Patch Set 1: Heh :) -- To view, visit http://gerrit.cloudera.org:8080/8698 To

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8669 ) Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 10: (5 comments) Did an initial pass. Still need

[Impala-ASF-CR] IMPALA-6201: Fix test basic filters on ASAN

2017-11-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8646 ) Change subject: IMPALA-6201: Fix test_basic_filters on ASAN .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

2017-11-27 Thread Tim Armstrong (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8652 to look at the new patch set (#2). Change subject: IMPALA-6241: timeout in admission control test under ASAN ..

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

2017-11-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 ) Change subject: IMPALA-6241: timeout in admission control test under ASAN .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 12: Tianyi, did you have any more

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 14: (5 comments)

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

2017-11-28 Thread Tim Armstrong (Code Review)
Hello Michael Brown, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8652 to look at the new patch set (#4). Change subject: IMPALA-6241: timeout in admission control test under ASAN

[Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 ) Change subject: IMPALA-6241: timeout in admission control test under ASAN .. Patch Set 4: Code-Review+2 I discovered that some of the

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 8: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 9: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 2: (1 comment) Would it make sense

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-1474: Add a metric for running queries

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/7228 ) Change subject: IMPALA-1474: Add a metric for running queries .. Abandoned Seems like this is probably redundant now. Can always reopen. -- To

[Impala-ASF-CR] IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8748 ) Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs .. Patch Set 2: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 ) Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 10: (8 comments)

[Impala-ASF-CR] IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8748 ) Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs .. Patch Set 1: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-6265 Query cancellation test enhancements

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8713 ) Change subject: IMPALA-6265 Query cancellation test enhancements .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 ) Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 14: Code-Review+2 rebase -- To view,

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-12 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8814 to look at the new patch set (#3). Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. ..

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 3: (3 comments) Took a quick look - I had

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. .. IMPALA-6290: limit ScannerContext to 1 buffer at a time.

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: UBSAN might also be able to detect

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 10: (5 comments)

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. .. Patch Set 3: (14 comments)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-14 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8814 to look at the new patch set (#4). Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. ..

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 10: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2017-12-15 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8814 to look at the new patch set (#5). Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time ..

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 12: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 4: (1 comment) The code and tests look

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2017-12-15 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8814 to look at the new patch set (#6). Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2017-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: Code-Review+1 Rebased onto master. There

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2017-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 ) Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 8: (1 comment) This is looking pretty good to

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 9: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8781 ) Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. Patch Set 3: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails

2017-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8572 ) Change subject: IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails .. Patch Set 1: (2 comments) Just a couple of

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-17 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8424 to look at the new patch set (#9). Change subject: IMPALA-4835 (prep only): create io subfolder and namespace

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-11-17 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#10). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 9: rebased and tweaked the #define guard to

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow"

2017-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8597 ) Change subject: IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow" .. Patch Set 1: Code-Review+2

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 5: (10 comments) Overall

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 9: (19 comments)

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-11-20 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#12). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 15: (17 comments)

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 ) Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. Patch Set 9: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6217: fix DCHECK in Parquet fuzz test

2017-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8594 ) Change subject: IMPALA-6217: fix DCHECK in Parquet fuzz test .. IMPALA-6217: fix DCHECK in Parquet fuzz test The IMPALA-4177 change

[Impala-ASF-CR] IMPALA-6217: fix DCHECK in Parquet fuzz test

2017-11-19 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8594 to look at the new patch set (#3). Change subject: IMPALA-6217: fix DCHECK in Parquet fuzz test .. IMPALA-6217: fix

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 1: Code-Review+1 (1 comment) The perf results looked acceptable

[Impala-ASF-CR] [DOCS] Correct bit patterns in comments for shiftright() examples

2017-11-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8624 ) Change subject: [DOCS] Correct bit patterns in comments for shiftright() examples .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-11-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 8: rebased and resolved conflicts with other

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 8: Ended up doing some further changes to

[Impala-ASF-CR] IMPALA-6080: clean up table descriptor handling

2017-11-16 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, anujphadke, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8330 to look at the new patch set (#3). Change subject: IMPALA-6080: clean up table descriptor handling

[Impala-ASF-CR] IMPALA-6080: clean up table descriptor handling

2017-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8330 ) Change subject: IMPALA-6080: clean up table descriptor handling .. Patch Set 3: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-6080: clean up table descriptor handling

2017-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8330 ) Change subject: IMPALA-6080: clean up table descriptor handling .. Patch Set 2: (2 comments)

  1   2   3   4   5   6   7   8   9   10   >