Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 )
Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9140/3/be/src/exec/parquet-column-stats.cc File be/src/exec/parquet-column-stats.cc: http://gerrit.cloudera.org:8080/#/c/9140/3/be/src/exec/parquet-column-stats.cc@132 PS3, Line 132: const int64_t* ColumnStatsBase::ReadNullCountStat( Can we use the same pattern as ReadFromThrift() - i.e. return a bool to indicate whether the stats were read, and an output parameter for the value? http://gerrit.cloudera.org:8080/#/c/9140/3/tests/query_test/test_parquet_stats.py File tests/query_test/test_parquet_stats.py: http://gerrit.cloudera.org:8080/#/c/9140/3/tests/query_test/test_parquet_stats.py@49 PS3, Line 49: self.client.execute('create table %s.table_for_null_count_test (i int, j int) ' Can you move these into parquet-stats.test - I don't think there's a reason to have these queries in python. -- To view, visit http://gerrit.cloudera.org:8080/9140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I141317af0e0df30da8f220b29b0bfba364f40ddf Gerrit-Change-Number: 9140 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2018 19:17:30 +0000 Gerrit-HasComments: Yes
