[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 8: > Thanks Tim and David for reviewing the changes -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 8 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 04 Apr 2018 17:36:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 8: Thanks Tm and David for reviewing the changes -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 8 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 04 Apr 2018 17:32:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 8: Thanks for the review Tim! -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 8 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 04 Apr 2018 17:17:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Reviewed-on: http://gerrit.cloudera.org:8080/9385 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M bin/impala-config.sh M buildall.sh 2 files changed, 20 insertions(+), 7 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 8 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 7 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 04 Apr 2018 01:48:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 7 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 03 Apr 2018 21:55:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2232/ -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 7 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 03 Apr 2018 21:55:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 6 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 03 Apr 2018 21:55:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 6: Code-Review+1 This looks OK to me. I'd like someone whose more of a bash expert to give this a final +2. -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 6 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Tue, 03 Apr 2018 17:50:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Nithya Janarthanan has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 --- M bin/impala-config.sh M buildall.sh 2 files changed, 20 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/9385/6 -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 6 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/9385/5/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/9385/5/bin/impala-config.sh@48 PS5, Line 48: "'$IMPALA_HOME'" =~ [[:blank:]] > See below on where to put this, but that said, make sure any checks you use [[:blank:]] seems to be zsh compliant based on below documentation https://www.gnu.org/software/grep/manual/html_node/Character-Classes-and-Bracket-Expressions.html http://zsh.sourceforge.net/Doc/Release/Expansion.html http://gerrit.cloudera.org:8080/#/c/9385/5/bin/impala-config.sh@56 PS5, Line 56: else : echo "IMPALA_HOME cannot have spaces in the path" : exit 1 : fi > Not sure it makes sense to put this check here. The L56 condition needs to Since it is possible that IMPALA_HOME could still expand to a path with spaces, moving the space check after this block http://gerrit.cloudera.org:8080/#/c/9385/5/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/9385/5/buildall.sh@28 PS5, Line 28: $ > I don't think you want variable expansion here. Done -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Fri, 30 Mar 2018 18:21:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 5: Yes. Have one last patch I need to put Got pulled in to CDH-64539will put the patch asap -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Thu, 29 Mar 2018 22:22:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 5: Is there still more coming on this review? -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Thu, 29 Mar 2018 22:01:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/9385/5/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/9385/5/bin/impala-config.sh@48 PS5, Line 48: "'$IMPALA_HOME'" =~ [[:blank:]] See below on where to put this, but that said, make sure any checks you use are zsh-compliant. If you need advice for zsh, I'd suggest checking with Lars Volker. http://gerrit.cloudera.org:8080/#/c/9385/5/bin/impala-config.sh@56 PS5, Line 56: else : echo "IMPALA_HOME cannot have spaces in the path" : exit 1 : fi Not sure it makes sense to put this check here. The L56 condition needs to still happen if L51 or L53 yields an IMPALA_HOME with spaces. I'd suggest putting this check below the L48-53 block (on the left side of the diff) as a separate check. -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Mon, 05 Mar 2018 17:38:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9385/5/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/9385/5/buildall.sh@28 PS5, Line 28: $ I don't think you want variable expansion here. -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Fri, 02 Mar 2018 21:28:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces
Nithya Janarthanan has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 --- M bin/impala-config.sh M buildall.sh 2 files changed, 18 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/9385/5 -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan