[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9102 )

Change subject: IMPALA-6435: Disable codegen for CHAR literals.
..

IMPALA-6435: Disable codegen for CHAR literals.

Currently we do not codegen CHAR types. This change checks
for CHAR literals in a expr and disables codegen.

Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Reviewed-on: http://gerrit.cloudera.org:8080/9102
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M be/src/exprs/literal.cc
M testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
2 files changed, 20 insertions(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Gerrit-Change-Number: 9102
Gerrit-PatchSet: 5
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: anujphadke

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9102 )

Change subject: IMPALA-6435: Disable codegen for CHAR literals.
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1793/


--
To view, visit http://gerrit.cloudera.org:8080/9102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Gerrit-Change-Number: 9102
Gerrit-PatchSet: 4
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: anujphadke 
Gerrit-Comment-Date: Wed, 24 Jan 2018 01:43:54 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review) 
anujphadke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9102 )

Change subject: IMPALA-6435: Disable codegen for CHAR literals.
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9102/3/testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
File testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test:

http://gerrit.cloudera.org:8080/#/c/9102/3/testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test@38
PS3, Line 38:   select cast('a' as char(4)) as s from functional.alltypestiny
> Can you add a similar test for cast(NULL as char(4))? Or add it to this que
Done



--
To view, visit http://gerrit.cloudera.org:8080/9102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Gerrit-Change-Number: 9102
Gerrit-PatchSet: 4
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: anujphadke 
Gerrit-Comment-Date: Wed, 24 Jan 2018 01:40:19 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review) 
Hello Philip Zeyliger, Tim Armstrong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9102

to look at the new patch set (#4).

Change subject: IMPALA-6435: Disable codegen for CHAR literals.
..

IMPALA-6435: Disable codegen for CHAR literals.

Currently we do not codegen CHAR types. This change checks
for CHAR literals in a expr and disables codegen.

Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
---
M be/src/exprs/literal.cc
M testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
2 files changed, 20 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/9102/4
--
To view, visit http://gerrit.cloudera.org:8080/9102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Gerrit-Change-Number: 9102
Gerrit-PatchSet: 4
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: anujphadke

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9102 )

Change subject: IMPALA-6435: Disable codegen for CHAR literals.
..


Patch Set 3: Code-Review+1

Looks better to me. Not an area of my expertise, though.


--
To view, visit http://gerrit.cloudera.org:8080/9102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Gerrit-Change-Number: 9102
Gerrit-PatchSet: 3
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: anujphadke 
Gerrit-Comment-Date: Tue, 23 Jan 2018 21:53:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review) 
anujphadke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9102 )

Change subject: IMPALA-6435: Disable codegen for CHAR literals.
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9102/1/be/src/exprs/literal.cc
File be/src/exprs/literal.cc:

http://gerrit.cloudera.org:8080/#/c/9102/1/be/src/exprs/literal.cc@a392
PS1, Line 392:
> This seems wrong; you deleted the handlig for TYPE_STRING.
Ooops! Sorry I had removed some of the code to debug some test failure.
Forgot to git add it back again. Removed the TYPE_CHAR case here and I return 
earlier.



--
To view, visit http://gerrit.cloudera.org:8080/9102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Gerrit-Change-Number: 9102
Gerrit-PatchSet: 3
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: anujphadke 
Gerrit-Comment-Date: Tue, 23 Jan 2018 21:20:31 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review) 
Hello Philip Zeyliger,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9102

to look at the new patch set (#3).

Change subject: IMPALA-6435: Disable codegen for CHAR literals.
..

IMPALA-6435: Disable codegen for CHAR literals.

Currently we do not codegen CHAR types. This change checks
for CHAR literals in a expr and disables codegen.

Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
---
M be/src/exprs/literal.cc
M testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
2 files changed, 18 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/9102/3
--
To view, visit http://gerrit.cloudera.org:8080/9102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Gerrit-Change-Number: 9102
Gerrit-PatchSet: 3
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review) 
Hello Philip Zeyliger,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9102

to look at the new patch set (#2).

Change subject: IMPALA-6435: Disable codegen for CHAR literals.
..

IMPALA-6435: Disable codegen for CHAR literals.

Currently we do not codegen CHAR types. This change checks
for CHAR literals in a expr and disables codegen.

Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
---
M be/src/exprs/literal.cc
M testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
2 files changed, 22 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/9102/2
--
To view, visit http://gerrit.cloudera.org:8080/9102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Gerrit-Change-Number: 9102
Gerrit-PatchSet: 2
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9102 )

Change subject: IMPALA-6435: Disable codegen for CHAR literals.
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9102/1/be/src/exprs/literal.cc
File be/src/exprs/literal.cc:

http://gerrit.cloudera.org:8080/#/c/9102/1/be/src/exprs/literal.cc@a392
PS1, Line 392:
This seems wrong; you deleted the handlig for TYPE_STRING.



-- 
To view, visit http://gerrit.cloudera.org:8080/9102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Gerrit-Change-Number: 9102
Gerrit-PatchSet: 1
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 23 Jan 2018 20:32:33 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review) 
anujphadke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9102


Change subject: IMPALA-6435: Disable codegen for CHAR literals.
..

IMPALA-6435: Disable codegen for CHAR literals.

Currently we do not codegen CHAR types. This change checks
for CHAR literals in a expr and disables codegen.

Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
---
M be/src/exprs/literal.cc
M testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
2 files changed, 18 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/9102/1
--
To view, visit http://gerrit.cloudera.org:8080/9102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Gerrit-Change-Number: 9102
Gerrit-PatchSet: 1
Gerrit-Owner: anujphadke