[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9544 )

Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
Gerrit-Change-Number: 9544
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 
Gerrit-Comment-Date: Fri, 09 Mar 2018 02:27:11 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9544 )

Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values
..

IMPALA-6500: gracefully handle invalid sched_getcpu() values

It appears that in some cases (probably under virtualization) we can get
out-of-range values returned from this function. Handle that case by
warning and modding the value back into range.

Testing:
Manually modified the function to inject a bad CPU ID. Verified that it
logged the warning as expected.

Added a backend test to exercise the code path. In the process,
repurpose perf-counters-test and delete some dead code that it
referenced.

Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
Reviewed-on: http://gerrit.cloudera.org:8080/9544
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M be/src/testutil/cpu-util.h
M be/src/util/CMakeLists.txt
M be/src/util/cpu-info.cc
D be/src/util/perf-counters-test.cc
D be/src/util/perf-counters.cc
D be/src/util/perf-counters.h
A be/src/util/sys-info-test.cc
7 files changed, 95 insertions(+), 647 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
Gerrit-Change-Number: 9544
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9544 )

Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2073/


--
To view, visit http://gerrit.cloudera.org:8080/9544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
Gerrit-Change-Number: 9544
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 
Gerrit-Comment-Date: Thu, 08 Mar 2018 22:40:55 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9544 )

Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values
..


Patch Set 4: Code-Review+2

rebase


--
To view, visit http://gerrit.cloudera.org:8080/9544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
Gerrit-Change-Number: 9544
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 
Gerrit-Comment-Date: Thu, 08 Mar 2018 22:40:30 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9544 )

Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9544/2/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

http://gerrit.cloudera.org:8080/#/c/9544/2/be/src/util/cpu-info.cc@298
PS2, Line 298: const int MAX_WARNINGS = 100;
> I think we could cut this down to say 20 or so; if it happens, it is likely
Done



--
To view, visit http://gerrit.cloudera.org:8080/9544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
Gerrit-Change-Number: 9544
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 
Gerrit-Comment-Date: Thu, 08 Mar 2018 22:40:08 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

[Tim Armstrong (Code Review)]

Hello Zach Amsden,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9544

to look at the new patch set (#3).

Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values
..

IMPALA-6500: gracefully handle invalid sched_getcpu() values

It appears that in some cases (probably under virtualization) we can get
out-of-range values returned from this function. Handle that case by
warning and modding the value back into range.

Testing:
Manually modified the function to inject a bad CPU ID. Verified that it
logged the warning as expected.

Added a backend test to exercise the code path. In the process,
repurpose perf-counters-test and delete some dead code that it
referenced.

Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
---
M be/src/testutil/cpu-util.h
M be/src/util/CMakeLists.txt
M be/src/util/cpu-info.cc
D be/src/util/perf-counters-test.cc
D be/src/util/perf-counters.cc
D be/src/util/perf-counters.h
A be/src/util/sys-info-test.cc
7 files changed, 95 insertions(+), 647 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/9544/3
--
To view, visit http://gerrit.cloudera.org:8080/9544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
Gerrit-Change-Number: 9544
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 

[Impala-ASF-CR] IMPALA-6500: gracefully handle invalid sched getcpu() values

[Zach Amsden (Code Review)]

Zach Amsden has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9544 )

Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values
..


Patch Set 2: Code-Review+2

(1 comment)

Looks good, up to you if you think we could reduce spamminess.

http://gerrit.cloudera.org:8080/#/c/9544/2/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

http://gerrit.cloudera.org:8080/#/c/9544/2/be/src/util/cpu-info.cc@298
PS2, Line 298: const int MAX_WARNINGS = 100;
I think we could cut this down to say 20 or so; if it happens, it is likely to 
immediately repeat and flood logs.



--
To view, visit http://gerrit.cloudera.org:8080/9544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
Gerrit-Change-Number: 9544
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 
Gerrit-Comment-Date: Thu, 08 Mar 2018 20:25:19 +
Gerrit-HasComments: Yes