[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 7: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Fri, 13 Apr 2018 00:44:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..

IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory

Testing:
- Ran bootstrap_development.sh with IMPALA_HOME set to non ~/Impala
  directory
- Ran bootstrap_development.sh with IMPALA_HOME not set

Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Reviewed-on: http://gerrit.cloudera.org:8080/9994
Reviewed-by: Fredy Wijaya 
Reviewed-by: Philip Zeyliger 
Tested-by: Impala Public Jenkins 
---
M bin/bootstrap_system.sh
1 file changed, 14 insertions(+), 8 deletions(-)

Approvals:
  Fredy Wijaya: Looks good to me, but someone else must approve
  Philip Zeyliger: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2303/


--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:51:06 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Fredy Wijaya (Code Review) 
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 7: Code-Review+1

(1 comment)

carry +1

http://gerrit.cloudera.org:8080/#/c/9994/6/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/9994/6/bin/bootstrap_system.sh@206
PS6, Line 206: : ${IMPALA_LZO_HOME:="${IMPALA_HOME}/../Impala-lzo"}
> nit:
Done



--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:47:08 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Fredy Wijaya (Code Review) 
Fredy Wijaya has uploaded a new patch set (#7). ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..

IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory

Testing:
- Ran bootstrap_development.sh with IMPALA_HOME set to non ~/Impala
  directory
- Ran bootstrap_development.sh with IMPALA_HOME not set

Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
---
M bin/bootstrap_system.sh
1 file changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9994/7
--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 6:

(1 comment)

One more quick thing.

http://gerrit.cloudera.org:8080/#/c/9994/6/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/9994/6/bin/bootstrap_system.sh@206
PS6, Line 206: IMPALA_LZO_HOME="$IMPALA_HOME"/../Impala-lzo
nit:

I think this should be

: ${IMPALA_LZO_HOME:="${IMPALA_HOME}/../Impala-lzo"}



--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 19:58:19 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Attila Jeges (Code Review) 
Attila Jeges has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 6: Code-Review+1

Thanks!


--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 15:20:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Fredy Wijaya (Code Review) 
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9994/5/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/9994/5/bin/bootstrap_system.sh@107
PS5, Line 107:   time -p git clone 
https://git-wip-us.apache.org/repos/asf/impala.git "$IMPALA_HOM
> This might fail if $IMPALA_HOME contains white-space and/or \[*? characters
Done



--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 14:41:18 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Fredy Wijaya (Code Review) 
Fredy Wijaya has uploaded a new patch set (#6). ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..

IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory

Testing:
- Ran bootstrap_development.sh with IMPALA_HOME set to non ~/Impala
  directory
- Ran bootstrap_development.sh with IMPALA_HOME not set

Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
---
M bin/bootstrap_system.sh
1 file changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9994/6
--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Attila Jeges (Code Review) 
Attila Jeges has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9994/5/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/9994/5/bin/bootstrap_system.sh@107
PS5, Line 107:   time -p git clone 
https://git-wip-us.apache.org/repos/asf/impala.git $IMPALA_HOME
This might fail if $IMPALA_HOME contains white-space and/or \[*? characters. 
Always use double quotes around variable substitutions (that is, "$IMPALA_HOME" 
instead of $IMPALA_HOME) here and elsewhere.

Same goes for $IMPALA_LZO_HOME and $HADOOP_LZO_HOME.



--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 13:46:22 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-11 Thread Fredy Wijaya (Code Review) 
Fredy Wijaya has uploaded a new patch set (#5). ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..

IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory

Testing:
- Ran bootstrap_development.sh with IMPALA_HOME set to non ~/Impala
  directory
- Ran bootstrap_development.sh with IMPALA_HOME not set

Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
---
M bin/bootstrap_system.sh
1 file changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9994/5
--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-11 Thread Fredy Wijaya (Code Review) 
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@24
PS3, Line 24: # variables to make Impala compile and run after this script is 
complete.
> Add a note here that it respects IMPALA_HOME
Done


http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@102
PS3, Line 102: # If there is no Impala git repo, get one now
> Impala house style for this is:
Done


http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@208
PS3, Line 208: then
> Define IMPALA_LZO_HOME next to where you define IMPALA_HOME and use that?
Done



--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 00:03:32 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-11 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 3:

(3 comments)

Seems fine. I've got minor suggestions.

http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@24
PS3, Line 24: # variables to make Impala compile and run after this script is 
complete.
Add a note here that it respects IMPALA_HOME


http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@102
PS3, Line 102: if ! [[ -v IMPALA_HOME ]]
Impala house style for this is:

: ${IMPALA_HOME:=~/Impala}

instead of lines 102-105.


http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@208
PS3, Line 208: if ! [[ -d $IMPALA_HOME/../Impala-lzo ]]
Define IMPALA_LZO_HOME next to where you define IMPALA_HOME and use that?



--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Wed, 11 Apr 2018 23:22:13 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-11 Thread Fredy Wijaya (Code Review) 
Fredy Wijaya has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9994


Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..

IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory

Testing:
- Ran bootstrap_development.sh with IMPALA_HOME set to non ~/Impala
  directory
- Ran bootstrap_development.sh with IMPALA_HOME not set

Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
---
M bin/bootstrap_system.sh
1 file changed, 14 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9994/3
--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya