[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Jim Apple (Code Review)
Hello Michael Brown, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7587 to look at the new patch set (#5). Change subject: IMPALA-4407: Move Impala setup procedures to main repo

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 5: Code-Review+1 (1 comment) Carry +1s from Michael B. and Lars.

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7640 Change subject: IMPALA-5352: Age out unused file handles from the cache .. IMPALA-5352: Age out unused file handles from the cache

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Jim Apple (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7587 to look at the new patch set (#4). Change subject: IMPALA-4407: Move Impala setup procedures to main repo ..

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 3: (11 comments) http://gerrit.cloudera.org:8080/#/c/7587/3/bin/bootstrap_development.sh File

[Impala-ASF-CR] IMPALA-5768: Better developer documentation

2017-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5768: Better developer documentation .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7350 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5768: Better developer documentation

2017-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-5768: Better developer documentation .. IMPALA-5768: Better developer documentation Guide to important environment variables for build, impala

[Impala-ASF-CR] IMPALA-5778: clarify --read size option.

2017-08-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5778: clarify --read_size option. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7623 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 4: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled

2017-08-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7631/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled

2017-08-10 Thread Lars Volker (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7631 to look at the new patch set (#2). Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#14). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Set toolchain version

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7642 Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-10 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5764: Allow overriding packaged components .. IMPALA-5764: Allow overriding packaged components For allowing multiple different distributions to build

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5778: clarify --read size option.

2017-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5778: clarify --read_size option. .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7623 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-10 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Abandoned Gerrit created another change for some reason. -- To view, visit http://gerrit.cloudera.org:8080/7648 To

[Impala-ASF-CR] PREVIEW: IMPALA-2615: support [[nodiscard]] on Status

2017-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: PREVIEW: IMPALA-2615: support [[nodiscard]] on Status .. PREVIEW: IMPALA-2615: support [[nodiscard]] on Status This is the set of changes required to get Impala

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 5: Sailesh since you also took a look at this and left comments, do you want to give the +2

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7642/1/be/src/util/jni-util.cc File

[Impala-ASF-CR] IMPALA-5412 Fix scan result with partitions on same file

2017-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5412 Fix scan result with partitions on same file .. Patch Set 3: (2 comments) Gabor told me that he won't be able to work on this for around 10 days.

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/7652 Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. IMPALA-4847: Simplify HdfsTable block metadata

[Impala-ASF-CR] IMPALA-5677: limit clean page memory consumption

2017-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7653 Change subject: IMPALA-5677: limit clean page memory consumption .. IMPALA-5677: limit clean page memory consumption Adds the following

[Impala-ASF-CR] IMPALA-5412 Fix scan result with partitions on same file

2017-08-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5412 Fix scan result with partitions on same file .. Patch Set 3: (1 comment) > (2 comments) > > Gabor told me that he won't be able to work on this

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 3: > (5 comments) Comments addressed. The code is still a little redundant for resource releasing

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 2: (10 comments) This is very subtle. I think the solution works but maybe there are some

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 5: Code-Review+2 Thanks for doing this! LGTM. -- To view, visit

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1029/ -- To

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 6: Code-Review+2 rebase carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7587 To

[Impala-ASF-CR] PREVIEW: IMPALA-2615: support [[nodiscard]] on Status

2017-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: PREVIEW: IMPALA-2615: support [[nodiscard]] on Status .. Patch Set 5: (14 comments) Halfway through reviewing; though we should hash some of this out before I do

[Impala-ASF-CR] IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled

2017-08-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#15). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Add krb5 as a

[Impala-ASF-CR] IMPALA-4794: Partition distinct expr for skew data

2017-08-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7643 Change subject: IMPALA-4794: Partition distinct expr for skew data .. IMPALA-4794: Partition distinct expr for skew data Currently in an

[Impala-ASF-CR] IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled

2017-08-10 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled .. Patch Set 2: Should any startup scripts be modified to trap '' SIGUSR1 before

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7646 Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. IMPALA-5773: Correctly account for

[native-toolchain-CR] IMPALA-5743: Allow TLS version configuration

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5743: Allow TLS version configuration .. Patch Set 3: Code-Review+2 Verified+1 Had to #ifdef code for openssl versions that don't support TLSv1.1 or

[Impala-ASF-CR] IMPALA-5412 Fix scan result with partitions on same file

2017-08-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#2). Change subject: IMPALA-5412 Fix scan result with partitions on same file .. IMPALA-5412 Fix scan result with partitions on same file The maps storing file descriptors and file

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-10 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 1: needs rebase against merged changes, coming presently -- To view, visit

[native-toolchain-CR] IMPALA-5743: Allow TLS version configuration

2017-08-10 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7558 to look at the new patch set (#3). Change subject: IMPALA-5743: Allow TLS version configuration .. IMPALA-5743:

[Impala-ASF-CR] IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled

2017-08-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. IMPALA-5773: Correctly account for memory used in data stream receiver queue

[Impala-ASF-CR] IMPALA-5412 Fix scan result with partitions on same file

2017-08-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#3). Change subject: IMPALA-5412 Fix scan result with partitions on same file .. IMPALA-5412 Fix scan result with partitions on same file The maps storing file descriptors and file

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. IMPALA-5743: Support TLS version configuration for Thrift servers * Add

[Impala-ASF-CR] PREVIEW: IMPALA-2615: support [[nodiscard]] on Status

2017-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: PREVIEW: IMPALA-2615: support [[nodiscard]] on Status .. Patch Set 5: (14 comments) http://gerrit.cloudera.org:8080/#/c/7253/5/be/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1029/

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 6: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1029/

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1030/ -- To

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-10 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/7648 Change subject: IMPALA-5764: Allow overriding packaged components .. IMPALA-5764: Allow overriding packaged components For allowing

[Impala-ASF-CR] IMPALA-5412 Fix scan result with partitions on same file

2017-08-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. Change subject: IMPALA-5412 Fix scan result with partitions on same file .. Patch Set 1: (20 comments)

[Impala-ASF-CR] IMPALA-5778: clarify --read size option.

2017-08-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5778: clarify --read_size option. .. IMPALA-5778: clarify --read_size option. Remove BTS_BLOCK_OVERFLOW error code, which is no longer

[Impala-ASF-CR] IMPALA-5778: clarify --read size option.

2017-08-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5778: clarify --read_size option. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7623 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause

2017-08-10 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded a new patch set (#4). Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. IMPALA-1478: Improve error message when subquery is used in the

[native-toolchain-CR] IMPALA-5714: Add linker's version script for OpenSSL library

2017-08-10 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. Change subject: IMPALA-5714: Add linker's version script for OpenSSL library .. Abandoned Decided that we won't need it for KRPC. -- To view, visit http://gerrit.cloudera.org:8080/7484

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4833: Compute precise per-host reservation size .. IMPALA-4833: Compute precise per-host reservation size Before this change, the per-host reservation

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 1: (5 comments)