[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 11: Code-Review+1 rebased to pick up IMPALA-6137

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 6: rebased -- To view, visit

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 7: Code-Review+1 rebased -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#7). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. IMPALA-4835:

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#5). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. IMPALA-4835:

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 11: Taking a look now. -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#6). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. IMPALA-4835:

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (3 comments) Testing found one subtle bug.

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Mostafa Mokhtar, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8461 to look at the new patch set (#4). Change subject: IMPALA-6151: add query-level fragment/backend counters

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 2: Code-Review+1 (5 comments)

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8418 ) Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6105: Clarify argument order in single node perf run

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8470 ) Change subject: IMPALA-6105: Clarify argument order in single_node_perf_run .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness

2017-11-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8418 ) Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Bharath Vissapragada (Code Review)
Hello Sailesh Mukil, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8449 to look at the new patch set (#4). Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8172 to look at the new patch set (#12). Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-11-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 9: Verified-1 Build

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-11-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 19: (5 comments)

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Tim Armstrong (Code Review)
Hello anujphadke, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8323 to look at the new patch set (#6). Change subject: IMPALA-1575: part 2: yield admission control resources

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 6: Code-Review+1 carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 6: Code-Review+2 (1 comment) If you do decide to

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-11-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: (1 comment) Looked through the headers and

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: > That's a good point, will make that change.

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 1: (13 comments)

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. IMPALA-3436: Return a decimal when rounding a double Before

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. IMPALA-3436: Return a decimal when rounding a double Before

[Impala-ASF-CR] IMPALA-5999: Fix LLVM linkage errors due LibCache sync issues

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8487 ) Change subject: IMPALA-5999: Fix LLVM linkage errors due LibCache sync issues .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Bharath Vissapragada (Code Review)
Hello Sailesh Mukil, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8449 to look at the new patch set (#5). Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances

[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options

2017-11-06 Thread John Russell (Code Review)
Hello Bharath Vissapragada, Henry Robinson, Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8401 to look at the new patch set (#3). Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options

[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options

2017-11-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8401 ) Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: That's a good point, will make that change.

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 5: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-5999: Fix LLVM linkage errors due LibCache sync issues

2017-11-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8487 Change subject: IMPALA-5999: Fix LLVM linkage errors due LibCache sync issues .. IMPALA-5999: Fix LLVM linkage errors due LibCache sync

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-06 Thread Philip Zeyliger (Code Review)
Hello David Knupp, Joe McDonnell, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8456 to look at the new patch set (#3). Change subject: IMPALA-6148: Specifying thirdparty deps as URLs

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 12: (6 comments)

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. IMPALA-2494: Support for

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 11: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6155: Ensure TPC-DS result orders can't vary.

2017-11-06 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 ) Change subject: IMPALA-6155: Ensure TPC-DS result orders can't vary. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 7: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-11-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 3: (7 comments) Thanks for sending the patch. The core

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. IMPALA-1575: part 2: yield admission control

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: (1 comment) Also added it to

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-11-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 20: Code-Review+1 carrying +1

[Impala-ASF-CR] IMPALA-6105: Clarify argument order in single node perf run

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8470 ) Change subject: IMPALA-6105: Clarify argument order in single_node_perf_run .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Mostafa Mokhtar, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8461 to look at the new patch set (#5). Change subject: IMPALA-6151: add query-level fragment/backend counters

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 7: I took a brief look at how much work it would

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-11-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 19: (5 comments)

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-11-06 Thread Vuk Ercegovac (Code Review)
Hello Juan Yu, Michael Brown, Philip Zeyliger, Balazs Jeszenszky, Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8202 to look at the new patch set (#20). Change subject: IMPALA-4704: Turns on client connections

[Impala-ASF-CR] IMPALA-6155: Ensure TPC-DS result orders can't vary.

2017-11-06 Thread Tim Wood (Code Review)
Tim Wood has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8484 Change subject: IMPALA-6155: Ensure TPC-DS result orders can't vary. .. IMPALA-6155: Ensure TPC-DS result orders can't vary. Add a 3rd-rank

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-11-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 11: Code-Review+2 Carrying over

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-11-06 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Matthew Jacobs, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7822 to look at the new patch set (#11). Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet

[Impala-ASF-CR] IMPALA-6155: Ensure TPC-DS result orders can't vary.

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 ) Change subject: IMPALA-6155: Ensure TPC-DS result orders can't vary. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: Code-Review+1 (4 comments) I'm happy with the FE

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-06 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Zoltan Borok-Nagy, Philip Zeyliger, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8447 to look at the new patch set (#6). Change subject: IMPALA-2181: Add query

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 6: (5 comments) Thanks All to take a look! Phil, about

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. IMPALA-5019: Decimal V2 addition In this patch, we implement the new decimal

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-11-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 8: (23 comments)

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8428 to look at the new patch set (#2). Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable