[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. IMPALA-4187: Switch RPC latency metrics to histograms It's usually better to measure latency

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4516 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 4: Code-Review+2 Carry +2, made Matt's suggested changes as well. -- To view, visit http://

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: (1 comment) Added before and after to the commit msg. http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Henry Robinson (Code Review)
Hello Juan Yu, Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4516 to look at the new patch set (#4). Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: > (1 comment) > > Can you give an example of what the old and new metries look like?

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: Code-Review+2 (1 comment) Can you give an example of what the old and new metries look like?

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace.cc File be/sr

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace.cc File be/sr

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-23 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4516 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/util/histogram-metric.h File

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc File be/src/rpc/r

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (8 comments) Perf results are in the commit msg now. http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. IMPALA-4187: Switch RPC latency metrics to histograms It's usually better to measure latency distribution

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc File be/sr

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: What's the performance of updating this metrics? -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc File be/src/rpc/

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: The core change to HistogramMetric (adding a Reset() method) is needed for our proposed s

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4516 Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. IMPALA-4187: Switch RPC latency metrics to histograms It's usu