Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
IMPALA-4187: Switch RPC latency metrics to histograms
It's usually better to measure latency
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4516
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 4: Code-Review+2
Carry +2, made Matt's suggested changes as well.
--
To view, visit http://
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 3:
(1 comment)
Added before and after to the commit msg.
http://gerrit.cloudera.org:8080/#/
Hello Juan Yu, Matthew Jacobs, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4516
to look at the new patch set (#4).
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 3:
> (1 comment)
>
> Can you give an example of what the old and new metries look like?
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 3: Code-Review+2
(1 comment)
Can you give an example of what the old and new metries look like?
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace.cc
File be/sr
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace.cc
File be/sr
Juan Yu has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4516
To unsubscribe, visit http:
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/util/histogram-metric.h
File
Juan Yu has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc
File be/src/rpc/r
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 2:
(8 comments)
Perf results are in the commit msg now.
http://gerrit.cloudera.org:8080/#/c
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
IMPALA-4187: Switch RPC latency metrics to histograms
It's usually better to measure latency distribution
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc
File be/sr
Juan Yu has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 2:
What's the performance of updating this metrics?
--
To view, visit http://gerrit.cloudera.org:8
Juan Yu has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc
File be/src/rpc/
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
Patch Set 2:
The core change to HistogramMetric (adding a Reset() method) is needed for our
proposed s
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4516
Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
..
IMPALA-4187: Switch RPC latency metrics to histograms
It's usu
20 matches
Mail list logo