[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/6/src/kudu/tablet/compaction.cc File

[kudu-CR] Create tablet history GC randomized itest

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create tablet history GC randomized itest .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2874/ -- To view, visit

[kudu-CR] Improve some comments in the tablet compaction code

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Improve some comments in the tablet compaction code .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2876/ -- To view, visit

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2875/ -- To view, visit

[kudu-CR] Create tablet history GC randomized itest

2016-08-14 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#2). Change subject: Create tablet history GC randomized itest .. Create tablet

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#11). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2877/ -- To view, visit

[kudu-CR] Create tablet history GC randomized itest

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create tablet history GC randomized itest .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2873/ -- To view, visit

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2868/ -- To view, visit

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#10). Change subject: KUDU-236. Implement tablet history GC ..

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2872/ -- To view, visit

[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3972 to review the following change. Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file .. Pull

[kudu-CR] Improve some comments in the tablet compaction code

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Improve some comments in the tablet compaction code .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2871/ -- To view, visit

[kudu-CR] Use nullptr instead of NULL in compaction

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3971 to review the following change. Change subject: Use nullptr instead of NULL in compaction .. Use nullptr instead of

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3974 to review the following change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Create

[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2870/ -- To view, visit

[kudu-CR] Use nullptr instead of NULL in compaction

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Use nullptr instead of NULL in compaction .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2869/ -- To view, visit

[kudu-CR] KUDU-1559. Fix block manager metric for aborted blocks

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1559. Fix block manager metric for aborted blocks .. KUDU-1559. Fix block manager metric for aborted blocks We weren't properly decrementing the

[kudu-CR] monotime: remove granularity argument

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: monotime: remove granularity argument .. monotime: remove granularity argument In practice, we almost never used the 'COARSE' granularity. Instead, it

[kudu-CR] monotime: remove granularity argument

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: monotime: remove granularity argument .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3966/1//COMMIT_MSG Commit Message: Line 13: Let's remove

[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3972 To unsubscribe,

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: Could you also add a GCing thread to mt-tablet-test? It's a good way to test interactions between

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. Patch Set 1: (2 comments) Thanks for fixing this. Just a small style nit.

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1474: single to multi-master deployment migration .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2880/ -- To view, visit

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-14 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3880 to look at the new patch set (#6). Change subject: KUDU-1474: single to multi-master deployment migration ..

[kudu-CR] fs: allow format with arbitrary uuid

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: fs: allow format with arbitrary uuid .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2882/ -- To view, visit

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-14 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3969 to look at the new patch set (#2). Change subject: integration_tests: end-to-end master permanent failure test ..

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2881/ -- To view, visit

[kudu-CR] Create tablet history GC randomized itest

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create tablet history GC randomized itest .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2878/ -- To view, visit

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: (1 comment) Just passing through with a question.

[kudu-CR] Create tablet history GC randomized itest

2016-08-14 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#3). Change subject: Create tablet history GC randomized itest .. Create tablet

[kudu-CR] Create tablet history GC randomized itest

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create tablet history GC randomized itest .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2879/ -- To view, visit

[kudu-CR] Create tablet history GC randomized itest

2016-08-14 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#4). Change subject: Create tablet history GC randomized itest .. Create tablet

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/11/src/kudu/tablet/tablet_history_gc-test.cc File

[kudu-CR] Reorganize range partition client API

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Reorganize range partition client API .. Reorganize range partition client API This commit redesigns the client APIs dealing with adding and dropping

[kudu-CR] log block manager: replace custom RAII class with ScopedCleanup

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: log_block_manager: replace custom RAII class with ScopedCleanup .. log_block_manager: replace custom RAII class with ScopedCleanup Change-Id:

[kudu-CR] [java-client] Reorganize range partition client API

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [java-client] Reorganize range partition client API .. [java-client] Reorganize range partition client API Equivalient to the corresponding C++ commit

[kudu-CR] Use nullptr instead of NULL in compaction

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Use nullptr instead of NULL in compaction .. Use nullptr instead of NULL in compaction No functional changes here. Change-Id:

[kudu-CR] Various comment / doc improvements

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Various comment / doc improvements .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3977/1/src/kudu/tablet/delta_compaction.cc File

[kudu-CR] Create randomized tablet history GC itest

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#5). Change subject: Create randomized tablet history GC itest ..

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#12). Change subject: KUDU-236. Implement tablet history GC ..

[kudu-CR] Various comment / doc improvements

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Various comment / doc improvements .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2887/ -- To view, visit

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2885/ -- To view, visit

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2888/ -- To view, visit

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 2: (1 comment) will try to write a test. fwiw I've been testing this on a cluster ~2 days now and

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-14 Thread Todd Lipcon (Code Review)
Hello Anonymous Coward #80, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3976 to look at the new patch set (#2). Change subject: MergeIterator: don't stop iterating on an empty block

[kudu-CR] Replace gscoped ptr with unique ptr for ConsensusMetadata

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Replace gscoped_ptr with unique_ptr for ConsensusMetadata .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3967 To unsubscribe,

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1474: single to multi-master deployment migration .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/3880/6/src/kudu/gutil/strings/join.h File

[kudu-CR] Create randomized tablet history GC itest

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create randomized tablet history GC itest .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2883/ -- To view, visit

[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file .. Abandoned This might not be needed -- To view, visit http://gerrit.cloudera.org:8080/3972 To unsubscribe,

[kudu-CR] WIP: Fix ordered iterators

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Fix ordered iterators .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2886/ -- To view, visit http://gerrit.cloudera.org:8080/3976 To

[kudu-CR] WIP: Fix ordered iterators

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3976 to review the following change. Change subject: WIP: Fix ordered iterators .. WIP: Fix ordered iterators Needs test.

[kudu-CR] Various comment / doc improvements

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3977 to review the following change. Change subject: Various comment / doc improvements .. Various comment / doc

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2884/ -- To view, visit

[kudu-CR] fs: allow format with arbitrary uuid

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: fs: allow format with arbitrary uuid .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3968/2/src/kudu/fs/fs_manager.cc File

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 12: (3 comments)

[kudu-CR] Improve some comments in the tablet compaction code

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Improve some comments in the tablet compaction code .. Abandoned Superceded by https://gerrit.cloudera.org/3977 -- To view, visit http://gerrit.cloudera.org:8080/3973 To

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 3: (1 comment)