[kudu-CR] tool: port ts-cli

2016-09-11 Thread Adar Dembo (Code Review)
Hello Dinesh Bhat, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4373 to review the following change. Change subject: tool: port ts-cli .. tool: port ts-cli I chose to

[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory

2016-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1301 - [python] Tests leak tmp directory .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4372/1//COMMIT_MSG Commit Message: Line 11:

[kudu-CR] linked list-test: set longer history retention

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: linked_list-test: set longer history retention .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3356/ -- To view, visit

[kudu-CR] tablet history gc-itest: set scanner ttl ms high

2016-09-11 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4375 to review the following change. Change subject: tablet_history_gc-itest: set scanner_ttl_ms high ..

[kudu-CR] [python] Implement Scan Token API

2016-09-11 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4367 to look at the new patch set (#7). Change subject: [python] Implement Scan Token API .. [python] Implement Scan

[kudu-CR] [python] Implement Scan Token API

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [python] Implement Scan Token API .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3352/ -- To view, visit

[kudu-CR] dist test: enable sharding on more long tests

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: dist_test: enable sharding on more long tests .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3361/ -- To view, visit

[kudu-CR] dist test: enable sharding on more long tests

2016-09-11 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4377 to look at the new patch set (#2). Change subject: dist_test: enable sharding on more long tests ..

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 8: (38 comments) http://gerrit.cloudera.org:8080/#/c/4305/8/docs/release_notes.adoc File

[kudu-CR] tool: port ts-cli

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3354/ -- To view, visit http://gerrit.cloudera.org:8080/4373 To

[kudu-CR] tool: port ts-cli

2016-09-11 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4373 to look at the new patch set (#2). Change subject: tool: port ts-cli .. tool: port ts-cli I chose to expose

[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1301 - [python] Tests leak tmp directory .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3351/ -- To view, visit

[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1301 - [python] Tests leak tmp directory .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3358/ -- To view, visit

[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory

2016-09-11 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1301 - [python] Tests leak tmp directory .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4372/1//COMMIT_MSG Commit Message: Line 11:

[kudu-CR] linked list-test: set longer history retention

2016-09-11 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4374 to review the following change. Change subject: linked_list-test: set longer history retention .. linked_list-test:

[kudu-CR] linked list-test: set longer history retention

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: linked_list-test: set longer history retention .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3355/ -- To view, visit

[kudu-CR] python: update cython version check in setup.py

2016-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: python: update cython version check in setup.py .. python: update cython version check in setup.py This updates the required version to match

[kudu-CR] tool: port ts-cli

2016-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 2: (5 comments) I agree from the user perspective it's nice to expose the generic stuff in both 'master' and 'tserver', but

[kudu-CR] python: bump version number to 0.3.0

2016-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: python: bump version number to 0.3.0 .. python: bump version number to 0.3.0 There have been some changes to the Python client since our last ASF

[kudu-CR] tool: port ts-cli

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3353/ -- To view, visit http://gerrit.cloudera.org:8080/4373 To

[kudu-CR] flex partitioning-itest: shard into separate cases

2016-09-11 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4376 to review the following change. Change subject: flex_partitioning-itest: shard into separate cases ..

[kudu-CR] flex partitioning-itest: shard into separate cases

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: flex_partitioning-itest: shard into separate cases .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3359/ -- To view, visit

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list

2016-09-11 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list .. Patch Set 7: (1 comment) Thanks, please take a look at updated patch.

[kudu-CR] [python] Implement Scan Token API

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [python] Implement Scan Token API .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3350/ -- To view, visit

[kudu-CR] [python] Implement Scan Token API

2016-09-11 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4367 to look at the new patch set (#6). Change subject: [python] Implement Scan Token API .. [python] Implement Scan

[kudu-CR] [python] Implement Scan Token API

2016-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [python] Implement Scan Token API .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/4367/5/python/kudu/tests/test_scantoken.py File

[kudu-CR] [python] Implement Scan Token API

2016-09-11 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: [python] Implement Scan Token API .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4367/5/python/kudu/tests/test_scantoken.py File

[kudu-CR] Reorganize and fill out release notes for 1.0

2016-09-11 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Reorganize and fill out release notes for 1.0 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4369/1//COMMIT_MSG Commit Message: Line 10:

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/3349/ -- To view, visit

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-11 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#8). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool

[kudu-CR] WIP: [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client

2016-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client .. Patch Set 1: Verified+1 unrelated failure

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add RegexpKuduOperationsProducer class .. Patch Set 5: > Late thought: do we want this in 1.0? If so will make note to Todd > to add to his release note rework

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Add RegexpKuduOperationsProducer class .. Add RegexpKuduOperationsProducer class This patch adds the RegexpKuduOperationsProducer class. This class

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add RegexpKuduOperationsProducer class .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3883 To unsubscribe, visit

[kudu-CR] WIP: script to run clang-tidy against a patch

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: script to run clang-tidy against a patch .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3366/ -- To view, visit

[kudu-CR] linked list-test: set longer history retention

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: linked_list-test: set longer history retention .. linked_list-test: set longer history retention The default 15 minute history retention was causing

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/3362/ -- To view, visit

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-11 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#9). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-11 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 8: (35 comments) Thank you again Adar, addressed rev comments below, please see responses too

[kudu-CR] util: avoid redundant copies in various macros

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: util: avoid redundant copies in various macros .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4379 To unsubscribe, visit

[kudu-CR] util: avoid redundant copies in various macros

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: util: avoid redundant copies in various macros .. util: avoid redundant copies in various macros A lot of macros have the form: #define FOO(arg) \

[kudu-CR] Reorganize and fill out release notes for 1.0

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Reorganize and fill out release notes for 1.0 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4369/1//COMMIT_MSG Commit Message: Line 10: -

[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index

2016-09-11 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4378 Change subject: KUDU-1604 - [python] Fix bug getting table column by index .. KUDU-1604 - [python] Fix bug getting table column by

[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1604 - [python] Fix bug getting table column by index .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3363/ -- To view, visit

[kudu-CR] util: avoid redundant copies in various macros

2016-09-11 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4379 to review the following change. Change subject: util: avoid redundant copies in various macros

[kudu-CR] WIP: script to run clang-tidy against a patch

2016-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4381 Change subject: WIP: script to run clang-tidy against a patch .. WIP: script to run clang-tidy against a patch This is some WIP tooling

[kudu-CR] util: avoid redundant copies in various macros

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: util: avoid redundant copies in various macros .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3364/ -- To view, visit

[kudu-CR] Fix one more flakiness in tablet replacement-itest

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Fix one more flakiness in tablet_replacement-itest .. Fix one more flakiness in tablet_replacement-itest The same as

[kudu-CR] WIP: [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client

2016-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4380 Change subject: WIP: [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client .. WIP: [java] -

[kudu-CR] WIP: [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client .. Patch Set 1: Build Started

[kudu-CR] linked list-test: set longer history retention

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: linked_list-test: set longer history retention .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4374 To unsubscribe,

[kudu-CR] python: update cython version check in setup.py

2016-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: python: update cython version check in setup.py .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4368 To unsubscribe,

[kudu-CR] python: bump version number to 0.3.0

2016-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: python: bump version number to 0.3.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4364 To unsubscribe, visit