[kudu-CR] Add Google Breakpad support to Kudu

2017-01-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5750 Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Bump version in branch to 1.2.1-SNAPSHOT Change-Id:

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 22: > (7 comments) > > final q: does this still work with docker instances? Last time I checked that before I

[kudu-CR] docs: clarify guidelines on boost usage

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5752 to review the following change. Change subject: docs: clarify guidelines on boost usage .. docs: clarify

[kudu-CR](gh-pages) Change links for old releases to Apache archive

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5751 to review the following change. Change subject: Change links for old releases to Apache archive .. Change

[kudu-CR] docs: clarify guidelines on boost usage

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: docs: clarify guidelines on boost usage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5752 To unsubscribe, visit

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Bump version in branch to 1.2.1-SNAPSHOT Change-Id: Ide4527df249f91fe60c19f7a0a7be18a0cb012d5 --- M

[kudu-CR](branch-1.2.x) [util] fixed env-test on OS X

2017-01-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5753 To unsubscribe, visit

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5750 To unsubscribe, visit

[kudu-CR](gh-pages) Change links for old releases to Apache archive

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Change links for old releases to Apache archive .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5751 To unsubscribe, visit

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Bump version in branch to 1.2.1-SNAPSHOT Change-Id: Ide4527df249f91fe60c19f7a0a7be18a0cb012d5

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [kudu-jepsen] Kudu Jepsen tests .. [kudu-jepsen] Kudu Jepsen tests This patch contains David's code for the initial kudu-jepsen tests as it was

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 4: Verified+1 Unrelated TSAN flake in raft_consensus-itest due to DnsResolver lifecycle

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 22: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit

[kudu-CR](branch-1.2.x) [util] fixed env-test on OS X

2017-01-20 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5753 to review the following change. Change subject: [util] fixed env-test on OS X .. [util] fixed env-test

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: Yea, I pasted them to the JIRA. I will also include them in the commit message in the next rev of

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Patch Set 1: Need to also change python/setup.py -- To view, visit http://gerrit.cloudera.org:8080/5750 To

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 18: (7 comments) http://gerrit.cloudera.org:8080/#/c/5492/18//COMMIT_MSG Commit Message: PS18, Line 10: failing)

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#22). Change subject: [kudu-jepsen] Kudu Jepsen tests .. [kudu-jepsen] Kudu Jepsen

[kudu-CR] docs: clarify guidelines on boost usage

2017-01-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: docs: clarify guidelines on boost usage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5752 To unsubscribe, visit

[kudu-CR] docs: clarify guidelines on boost usage

2017-01-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: clarify guidelines on boost usage .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5752/1/docs/contributing.adoc File docs/contributing.adoc:

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 6: (21 comments) http://gerrit.cloudera.org:8080/#/c/5620/6//COMMIT_MSG Commit Message: PS6, Line 29: default >

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-20 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#9). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [kudu-jepsen] added Jenkins script .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5624/6//COMMIT_MSG Commit Message: PS6, Line 21: The Kudu

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5624 to look at the new patch set (#7). Change subject: [kudu-jepsen] added Jenkins script .. [kudu-jepsen] added

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] added Jenkins script .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5624 To unsubscribe, visit

[kudu-CR] [security] interface for certificate signing service

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] interface for certificate signing service .. Patch Set 3: > This seems pretty reasonable, but I'm not sure whether this makes > sense as a

[kudu-CR] [security] interface for certificate signing service

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] interface for certificate signing service .. Patch Set 3: OK. I'm starting to hack on the tablet server side to generate a cert and CSR and send it to

[kudu-CR] [security] interface for certificate signing service

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] interface for certificate signing service .. Patch Set 3: > OK. I'm starting to hack on the tablet server side to generate a > cert and CSR and send

[kudu-CR] [security] groundwork for cert signing service

2017-01-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5671 to look at the new patch set (#5). Change subject: [security] groundwork for cert signing service .. [security]

[kudu-CR] [security] groundwork for cert signing service

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] groundwork for cert signing service .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5671/4/src/kudu/security/ca/cert_management.cc

[kudu-CR] [security] Kudu certificate signing service

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] Kudu certificate signing service .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5674/3/src/kudu/master/master.cc File

[kudu-CR] [security] groundwork for cert signing service

2017-01-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5671 to look at the new patch set (#6). Change subject: [security] groundwork for cert signing service .. [security]

[kudu-CR] [security] groundwork for cert signing service

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] groundwork for cert signing service .. Patch Set 5: (2 comments)

[kudu-CR] [security] groundwork for cert signing service

2017-01-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5671 to look at the new patch set (#7). Change subject: [security] groundwork for cert signing service .. [security]

[kudu-CR] [security] groundwork for cert signing service

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] groundwork for cert signing service .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1835 (part 1). Move compression codec classes to util .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5735 To unsubscribe,

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 22: I'm merging this anyway. We can address any docker specific issues in follow up patches. -- To view,

[kudu-CR](branch-1.2.x) [util] fixed env-test on OS X

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X Prior to the fix, in some cases the uninitialized portion of 64-bit variable was non-zero

[kudu-CR](branch-1.2.x) [util] fixed env-test on OS X

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5753 To unsubscribe, visit

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] added Jenkins script .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/5624/6//COMMIT_MSG Commit Message: PS6, Line 12:

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

2017-01-20 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. env_util: Factor out helper DeleteExcessFilesByPattern() The logic contained in here is

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 6: (22 comments) > The right way to do it would probably be to have a signal-handling thread. Another option is

[kudu-CR] [security] groundwork for cert signing service

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] groundwork for cert signing service .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5671/4/src/kudu/security/ca/cert_management.cc

[kudu-CR] [security] interface for certificate signing service

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] interface for certificate signing service .. Patch Set 3: This seems pretty reasonable, but I'm not sure whether this makes sense as a standalone RPC

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-20 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#7). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] docs: clarify guidelines on boost usage

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: clarify guidelines on boost usage .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5752/1/docs/contributing.adoc File

[kudu-CR] rpc: add basic service and method-level authorization

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4897 to look at the new patch set (#2). Change subject: rpc: add basic service and method-level authorization .. rpc:

[kudu-CR] rpc: add basic service and method-level authorization

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: add basic service and method-level authorization .. Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/4897/1/src/kudu/rpc/protoc-gen-krpc.cc

[kudu-CR] [security] groundwork for cert signing service

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] groundwork for cert signing service .. Patch Set 1: (3 comments)

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-20 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#8). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] [security] Kudu certificate signing service

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] Kudu certificate signing service .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5674/3/src/kudu/master/master.cc File

[kudu-CR] docs: clarify guidelines on boost usage

2017-01-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: docs: clarify guidelines on boost usage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5752 To unsubscribe, visit

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-20 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#10). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1835 (part 1). Move compression codec classes to util .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5735/4/src/kudu/cfile/cfile-test.cc

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [kudu-jepsen] added Jenkins script .. [kudu-jepsen] added Jenkins script Added a shell script to build Kudu and run kudu-jepsen tests from a Jenkins

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-20 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#11). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5737 to look at the new patch set (#2). Change subject: KUDU-1836. Enable compression of DeltaFiles ..

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5736 to look at the new patch set (#7). Change subject: KUDU-1835 (part 2): enable WAL compression .. KUDU-1835 (part

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5735 to look at the new patch set (#5). Change subject: KUDU-1835 (part 1). Move compression codec classes to util ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5760 to review the following change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation

[kudu-CR] TLS-negotiation [5/n]: Rename sasl [client|server] to [client|server] negotiation

2017-01-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5759 to review the following change. Change subject: TLS-negotiation [5/n]: Rename sasl_[client|server] to [client|server]_negotiation

[kudu-CR] TLS-negotiation [3/n]: rename negotiation protobuf messages

2017-01-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5757 to review the following change. Change subject: TLS-negotiation [3/n]: rename negotiation protobuf messages

[kudu-CR] TLS-negotiation [2/n]: remove SASL ANONYMOUS mechanism

2017-01-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5756 to review the following change. Change subject: TLS-negotiation [2/n]: remove SASL ANONYMOUS mechanism

[kudu-CR] TLS-negotiation [4/n]: rename Negotiation steps

2017-01-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5758 to review the following change. Change subject: TLS-negotiation [4/n]: rename Negotiation steps

[kudu-CR] TLS-negotiation [1/n]: deprecate unused SaslAuth fields

2017-01-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5755 to review the following change. Change subject: TLS-negotiation [1/n]: deprecate unused SaslAuth fields

[kudu-CR] TLS-negotiation [8/n]: TLS negotiation

2017-01-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5762 to review the following change. Change subject: TLS-negotiation [8/n]: TLS negotiation ..

[kudu-CR] TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

2017-01-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5761 to review the following change. Change subject: TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

[kudu-CR] TLS-negotiation [8/n]: TLS negotiation

2017-01-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [8/n]: TLS negotiation .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5762/1/src/kudu/rpc/client_negotiation.h File

[kudu-CR] TLS-negotiation [3/n]: rename negotiation protobuf messages

2017-01-20 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5757 to look at the new patch set (#2). Change subject: TLS-negotiation [3/n]: rename negotiation protobuf messages ..

[kudu-CR] TLS-negotiation [5/n]: Rename sasl [client|server] to [client|server] negotiation

2017-01-20 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: TLS-negotiation [5/n]: Rename sasl_[client|server] to [client|server]_negotiation .. TLS-negotiation [5/n]: Rename sasl_[client|server] to

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-20 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#2). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [8/n]: TLS negotiation

2017-01-20 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5762 to look at the new patch set (#2). Change subject: TLS-negotiation [8/n]: TLS negotiation .. TLS-negotiation

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

2017-01-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5740/2/src/kudu/util/env_util-test.cc

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

2017-01-20 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5740 to look at the new patch set (#4). Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() ..

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: still planning on adding those numbers? -- To view, visit

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 18: (7 comments) final q: does this still work with docker instances?

[kudu-CR](gh-pages) Update site for 1.2.0 release

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Update site for 1.2.0 release .. Update site for 1.2.0 release Change-Id: Ie099f05bc9d2171051b1f9016ae93c47e7bbfefd Reviewed-on:

[kudu-CR](gh-pages) Update site for 1.2.0 release

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update site for 1.2.0 release .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5730 To unsubscribe, visit

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#21). Change subject: [kudu-jepsen] Kudu Jepsen tests .. [kudu-jepsen] Kudu Jepsen

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-20 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: Thanks for the discussion. Remove the new code from Schema

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

2017-01-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5740/2/src/kudu/util/env_util-test.cc