[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Andrew Wong (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8338 to look at the new patch set (#4). Change subject: log block manager: return early if read-only

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR] kudu-tool-test: adjust minicluster functions slightly

2017-10-20 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8351 to review the following change. Change subject: kudu-tool-test: adjust minicluster functions slightly ..

[kudu-CR] tool: new actions for adding and removing data directories

2017-10-20 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8352 to review the following change. Change subject: tool: new actions for adding and removing data directories

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 4: (3 comments)

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 24: (1 comment)

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Andrew Wong (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8338 to look at the new patch set (#5). Change subject: log block manager: return early if read-only

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 5: (4 comments)

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 29: (1 comment)

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 5: > Patch Set 5: > > (4 comments) Failure seems unrelated

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 29: (1 comment)

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 5: Verified+1 Agreed. Overriding Jenkins. -- To view, visit

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. log block manager: return early if read-only A container may be

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] WIP log block manager: return early if read-only

2017-10-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: WIP log block manager: return early if read-only .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager

2017-10-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8345 ) Change subject: KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager .. Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > >

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 4: (3 comments)

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Andrew Wong (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8338 to look at the new patch set (#3). Change subject: log block manager: return early if read-only

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 2: (1 comment)

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager

2017-10-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8345 ) Change subject: KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager .. Patch Set 1: > Patch Set 1: > > I dunno, I'm sort of

[kudu-CR] log block manager: return early if read-only

2017-10-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: log block manager: return early if read-only .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-20 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6755 to look at the new patch set (#7). Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help

[kudu-CR] WIP log block manager: return early if read-only

2017-10-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: WIP log block manager: return early if read-only .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 7: (8 comments)

[kudu-CR] WIP log block manager: return early if read-only

2017-10-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: WIP log block manager: return early if read-only .. Patch Set 2: (1 comment)

[kudu-CR] WIP log block manager: return early if read-only

2017-10-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 ) Change subject: WIP log block manager: return early if read-only .. Patch Set 2: (1 comment)