[kudu-CR] KUDU-2191: bump Hive package

2017-11-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8691 ) Change subject: KUDU-2191: bump Hive package .. Patch Set 1: Code-Review+2 I don't have a ton of context here, but the change looks

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2017-11-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8692 to look at the new patch set (#2). Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

[kudu-CR] KUDU-2191 (4/n): HMS Thrift client fault handling

2017-11-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8494 to look at the new patch set (#5). Change subject: KUDU-2191 (4/n): HMS Thrift client fault handling

[kudu-CR] [KUDU-2214] Voting while tablet copying says "voting while tombstoned"

2017-11-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8666 ) Change subject: [KUDU-2214] Voting while tablet copying says "voting while tombstoned" .. Patch Set 1: > (1 comment) OK. But looking

[kudu-CR] KUDU-2191: bump Hive package

2017-11-30 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8691 ) Change subject: KUDU-2191: bump Hive package .. KUDU-2191: bump Hive package Bumps the packaged Hive version in order to fix a

[kudu-CR] Add initial internal INT128/ int128 support

2017-11-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 ) Change subject: Add initial internal INT128/__int128 support .. Patch Set 15: (2 comments)

[kudu-CR] Add initial internal INT128/ int128 support

2017-11-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 ) Change subject: Add initial internal INT128/__int128 support .. Patch Set 15: (1 comment)

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-11-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8700 Change subject: [security] Make the kerberos principal configurable for Kudu servers .. [security] Make the kerberos principal

[kudu-CR](branch-1.5.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-30 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8699 to review the following change. Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag ..

[kudu-CR] [KUDU-2214] Voting while tablet copying says "voting while tombstoned"

2017-11-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8666 ) Change subject: [KUDU-2214] Voting while tablet copying says "voting while tombstoned" .. Patch Set 1: > OK. But looking at test logs

[kudu-CR] Add initial internal INT128/ int128 support

2017-11-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 ) Change subject: Add initial internal INT128/__int128 support .. Patch Set 15: (1 comment)

[kudu-CR] [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet

2017-11-30 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8704 to look at the new patch set (#2). Change subject: [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet

[kudu-CR] release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

2017-11-30 Thread Dan Burkert (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8703 to look at the new patch set (#3). Change subject: release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

[kudu-CR] [known issues] incompatibility note for bouncycastle <= 1.52

2017-11-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8706 Change subject: [known_issues] incompatibility note for bouncycastle <= 1.52 .. [known_issues] incompatibility note for bouncycastle <=

[kudu-CR] A couple of 1.6 release notes

2017-11-30 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8702 Change subject: A couple of 1.6 release notes .. A couple of 1.6 release notes Change-Id: Ia69cc1904b5e1a81fecf20a2ca5a8fb1908a6025 ---

[kudu-CR](branch-1.5.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

2017-11-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8699 ) Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

2017-11-30 Thread Dan Burkert (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8703 to review the following change. Change subject: release notes: add KUDU-2190 and KUDU-2173 for 1.6.0 .. release notes:

[kudu-CR] release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

2017-11-30 Thread Dan Burkert (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8703 to look at the new patch set (#2). Change subject: release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

[kudu-CR] [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet

2017-11-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8704 Change subject: [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet .. [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet

[kudu-CR] release notes: a couple micro-updates

2017-11-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8705 Change subject: release notes: a couple micro-updates .. release notes: a couple micro-updates Change-Id:

[kudu-CR] [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet

2017-11-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8704 ) Change subject: [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet .. Abandoned It seem this is not what we want. -- To view, visit

[kudu-CR] consensus: Make queue more debuggable

2017-11-30 Thread Mike Percy (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8708 to review the following change. Change subject: consensus: Make queue more debuggable .. consensus: Make queue more

[kudu-CR] consensus: Make queue more debuggable

2017-11-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8708 ) Change subject: consensus: Make queue more debuggable .. Patch Set 1: (1 comment) How's the overlap of the queue_state with what's

[kudu-CR] [consensus queue] local peer is always healthy

2017-11-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8709 Change subject: [consensus_queue] local peer is always healthy .. [consensus_queue] local peer is always healthy While iterating over

[kudu-CR] [consensus queue] local peer is always healthy

2017-11-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8709 ) Change subject: [consensus_queue] local peer is always healthy .. Patch Set 1: (2 comments)

[kudu-CR] [consensus queue] local peer is always healthy

2017-11-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8709 ) Change subject: [consensus_queue] local peer is always healthy .. Patch Set 2: (1 comment)

[kudu-CR] [consensus queue] local peer is always healthy

2017-11-30 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8709 to look at the new patch set (#2). Change subject: [consensus_queue] local peer is always healthy

[kudu-CR] [consensus queue] the leader is always a viable voter

2017-11-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8709 ) Change subject: [consensus_queue] the leader is always a viable voter .. Patch Set 2: (1 comment)

[kudu-CR] [consensus queue] the leader is always a viable voter

2017-11-30 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8709 to look at the new patch set (#3). Change subject: [consensus_queue] the leader is always a viable voter

[kudu-CR] consensus: Make queue more debuggable

2017-11-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8708 ) Change subject: consensus: Make queue more debuggable .. Patch Set 1: Code-Review+1 LGTM, maybe just address the stylistic issue, if

[kudu-CR] consensus: Make queue more debuggable

2017-11-30 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8708 to look at the new patch set (#2). Change subject: consensus: Make queue more debuggable

[kudu-CR] consensus: Make queue more debuggable

2017-11-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8708 ) Change subject: consensus: Make queue more debuggable .. Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) > > How's the overlap

[kudu-CR] [consensus queue] the leader is always a viable voter

2017-11-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8709 ) Change subject: [consensus_queue] the leader is always a viable voter .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] consensus: Make queue more debuggable

2017-11-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8708 ) Change subject: consensus: Make queue more debuggable .. Patch Set 2: Code-Review+2 Gotcha -- To view, visit

[kudu-CR] consensus: Make queue more debuggable

2017-11-30 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8708 ) Change subject: consensus: Make queue more debuggable .. consensus: Make queue more debuggable After the introduction of

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-11-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8700 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2230: the leader is always a viable voter

2017-11-30 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8709 to look at the new patch set (#4). Change subject: KUDU-2230: the leader is always a viable voter

[kudu-CR] KUDU-2229. consensus: Leader should not start FD

2017-11-30 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8711 to review the following change. Change subject: KUDU-2229. consensus: Leader should not start FD .. KUDU-2229.