[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

2018-08-07 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10983 to look at the new patch set (#13). Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. Patch Set 4: (5 comments) LGTM, just a few

[kudu-CR] python: copy pandas dependency into requirements.txt

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11146 ) Change subject: python: copy pandas dependency into requirements.txt .. Patch Set 1: (2 comments)

[kudu-CR] python: fix non-DECIMAL unit test breakage

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11148 ) Change subject: python: fix non-DECIMAL unit test breakage .. Patch Set 1: > I wonder if it'd be worth running tests with both

[kudu-CR] python: copy pandas dependency into requirements.txt

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11146 ) Change subject: python: copy pandas dependency into requirements.txt .. Patch Set 1: (2 comments)

[kudu-CR] python: get new pandas dependency working on Python 2.6

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11149 ) Change subject: python: get new pandas dependency working on Python 2.6 .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] python: copy pandas dependency into requirements.txt

2018-08-07 Thread Adar Dembo (Code Review)
Hello Jordan Birdsell, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11146 to review the following change. Change subject: python: copy pandas dependency into requirements.txt

[kudu-CR] tablet bootstrap: adjust mvcc safetime with no-ops

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11142 ) Change subject: tablet_bootstrap: adjust mvcc safetime with no-ops .. Patch Set 1: Ah, I omitted the part where we add the

[kudu-CR] tablet bootstrap: adjust mvcc safetime with no-ops

2018-08-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11142 to look at the new patch set (#2). Change subject: tablet_bootstrap: adjust mvcc safetime with no-ops ..

[kudu-CR] [docs] Add changing master hostnames workflow

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 ) Change subject: [docs] Add changing master hostnames workflow .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] python: fix non-DECIMAL unit test breakage

2018-08-07 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Jordan Birdsell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11148 to review the following change. Change subject: python: fix non-DECIMAL unit test breakage ..

[kudu-CR] python: get new pandas dependency working on Python 2.6

2018-08-07 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Jordan Birdsell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11149 to review the following change. Change subject: python: get new pandas dependency working on Python 2.6

[kudu-CR] KUDU-2528: thirdparty downloads should be more robust

2018-08-07 Thread Adar Dembo (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11152 to review the following change. Change subject: KUDU-2528: thirdparty downloads should be more robust .. KUDU-2528:

[kudu-CR](gh-pages) Blog: Getting Started with Kudu

2018-08-07 Thread Brock Noland (Code Review)
Hello Jordan Birdsell, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11136 to look at the new patch set (#3). Change subject: Blog: Getting Started with Kudu .. Blog:

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

2018-08-07 Thread Anupama Gupta (Code Review)
Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components .. Patch Set 11: (41 comments)

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

2018-08-07 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10983 to look at the new patch set (#12). Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components

[kudu-CR] python: copy pandas dependency into requirements.txt

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11146 ) Change subject: python: copy pandas dependency into requirements.txt .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] Assign locations to registering tablet servers

2018-08-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/5 ) Change subject: [location_awareness] Assign locations to registering tablet servers .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

2018-08-07 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#26). Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components

[kudu-CR] python: copy pandas dependency into requirements.txt

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11146 ) Change subject: python: copy pandas dependency into requirements.txt .. Patch Set 2: > I would like to discuss this before it’s

[kudu-CR] python: fix non-DECIMAL unit test breakage

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11148 ) Change subject: python: fix non-DECIMAL unit test breakage .. python: fix non-DECIMAL unit test breakage For reference, the

[kudu-CR] python: get new pandas dependency working on Python 2.6

2018-08-07 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Jordan Birdsell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11149 to look at the new patch set (#2). Change subject: python: get new pandas dependency working on Python 2.6

[kudu-CR] Implement BloomFilter Predicate in server side.

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11100 ) Change subject: Implement BloomFilter Predicate in server side. .. Patch Set 2: (6 comments) Interesting feature! I just did a pass

[kudu-CR] python: copy pandas dependency into requirements.txt

2018-08-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11146 ) Change subject: python: copy pandas dependency into requirements.txt .. Patch Set 2: Code-Review-1 I would like to discuss this

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

2018-08-07 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#25). Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

2018-08-07 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10983 to look at the new patch set (#11). Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

2018-08-07 Thread Anupama Gupta (Code Review)
Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components .. Patch Set 11: (2 comments)

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

2018-08-07 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#24). Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components

[kudu-CR] KUDU-2528: thirdparty downloads should be more robust

2018-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11152 ) Change subject: KUDU-2528: thirdparty downloads should be more robust .. Patch Set 1: (2 comments)

[kudu-CR] java: remove flaky TestServerInfo.testConstructorNotSlow

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11125 ) Change subject: java: remove flaky TestServerInfo.testConstructorNotSlow .. Patch Set 2: Verified+1 Overriding Jenkins, unrelated test

[kudu-CR] java: remove flaky TestServerInfo.testConstructorNotSlow

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11125 ) Change subject: java: remove flaky TestServerInfo.testConstructorNotSlow .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] WIP: Create parallelized loader Spark job

2018-08-07 Thread Mike Percy (Code Review)
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11147 Change subject: WIP: Create parallelized loader Spark job .. WIP: Create parallelized loader Spark job This patch adds a new tool called

[kudu-CR] Add const attribute to RpcContext::GetInboundSidecar()

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11150 ) Change subject: Add const attribute to RpcContext::GetInboundSidecar() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add const attribute to RpcContext::GetInboundSidecar()

2018-08-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11150 Change subject: Add const attribute to RpcContext::GetInboundSidecar() .. Add const attribute to RpcContext::GetInboundSidecar() Testing

[kudu-CR] python: fix non-DECIMAL unit test breakage

2018-08-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11148 ) Change subject: python: fix non-DECIMAL unit test breakage .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] python: fix non-DECIMAL unit test breakage

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11148 ) Change subject: python: fix non-DECIMAL unit test breakage .. Patch Set 1: Code-Review+2 I wonder if it'd be worth running tests with

[kudu-CR] java: remove flaky TestServerInfo.testConstructorNotSlow

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11125 ) Change subject: java: remove flaky TestServerInfo.testConstructorNotSlow .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] python: get new pandas dependency working on Python 2.6

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11149 ) Change subject: python: get new pandas dependency working on Python 2.6 .. Patch Set 1: Code-Review+1 (3 comments)

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

2018-08-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components .. Patch Set 10: (3 comments)

[kudu-CR] python: get new pandas dependency working on Python 2.6

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11149 ) Change subject: python: get new pandas dependency working on Python 2.6 .. Patch Set 1: Verified+1 Overriding Jenkins, unrelated test

[kudu-CR] python: get new pandas dependency working on Python 2.6

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11149 ) Change subject: python: get new pandas dependency working on Python 2.6 .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] python: get new pandas dependency working on Python 2.6

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11149 ) Change subject: python: get new pandas dependency working on Python 2.6 .. Patch Set 1: (3 comments)

[kudu-CR] java: remove flaky TestServerInfo.testConstructorNotSlow

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11125 ) Change subject: java: remove flaky TestServerInfo.testConstructorNotSlow .. java: remove flaky

[kudu-CR] python: copy pandas dependency into requirements.txt

2018-08-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11146 ) Change subject: python: copy pandas dependency into requirements.txt .. Patch Set 1: This was done intentionally. Pandas should be

[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components

2018-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components .. Patch Set 12: (13 comments)

[kudu-CR] python: copy pandas dependency into requirements.txt

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11146 ) Change subject: python: copy pandas dependency into requirements.txt .. python: copy pandas dependency into requirements.txt

[kudu-CR] python: copy pandas dependency into requirements.txt

2018-08-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11146 ) Change subject: python: copy pandas dependency into requirements.txt .. Patch Set 2: Ok by me. I think the right approach here

[kudu-CR] Add support for Java dist-tests on Jenkins

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 ) Change subject: Add support for Java dist-tests on Jenkins .. Patch Set 5: > I am not sure we should merge this yet given we don't have

[kudu-CR] python: get new pandas dependency working on Python 2.6

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11149 ) Change subject: python: get new pandas dependency working on Python 2.6 .. python: get new pandas dependency working on Python

[kudu-CR] KUDU-2528: thirdparty downloads should be more robust

2018-08-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11152 ) Change subject: KUDU-2528: thirdparty downloads should be more robust .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2528: thirdparty downloads should be more robust

2018-08-07 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11152 to look at the new patch set (#2). Change subject: KUDU-2528: thirdparty downloads should be more robust

[kudu-CR] python: copy pandas dependency into requirements.txt

2018-08-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has removed a vote on this change. Change subject: python: copy pandas dependency into requirements.txt .. Removed Code-Review-1 by Jordan Birdsell -- To view, visit http://gerrit.cloudera.org:8080/11146 To

[kudu-CR] KUDU-2528: thirdparty downloads should be more robust

2018-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11152 ) Change subject: KUDU-2528: thirdparty downloads should be more robust .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [Java] Update readme with Gradle commands

2018-08-07 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11135 to look at the new patch set (#3). Change subject: [Java] Update readme with Gradle commands

[kudu-CR] [Java] Update readme with Gradle commands

2018-08-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11135 ) Change subject: [Java] Update readme with Gradle commands .. Patch Set 3: Code-Review+2 (1 comment) Carrying the +2 through the nit

[kudu-CR] [Java] Update readme with Gradle commands

2018-08-07 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11135 ) Change subject: [Java] Update readme with Gradle commands .. [Java] Update readme with Gradle commands Updates the Java readme

[kudu-CR] tablet bootstrap: adjust mvcc safetime with no-ops

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11142 Change subject: tablet_bootstrap: adjust mvcc safetime with no-ops .. tablet_bootstrap: adjust mvcc safetime with no-ops Previously,

[kudu-CR] wip consensus: add RPC to replicate a NO OP

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11143 Change subject: wip consensus: add RPC to replicate a NO_OP .. wip consensus: add RPC to replicate a NO_OP This patch adds an RPC to

[kudu-CR] wip consensus: atomicize timestamp/opid assignment

2018-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11144 Change subject: wip consensus: atomicize timestamp/opid assignment .. wip consensus: atomicize timestamp/opid assignment This patch