[kudu-CR] exactly once rpc-test: properly propagate sleep parameter

2017-02-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: exactly_once_rpc-test: properly propagate sleep parameter .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5883 To

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#5). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5818/4/thirdparty/build-definitions.sh File

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 1: (3 comments)

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#34). Change subject: Add Google Breakpad support to Kudu ..

[kudu-CR] Add missing pb util proto dependency to token proto

2017-02-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add missing pb_util_proto dependency to token_proto .. Add missing pb_util_proto dependency to token_proto Change-Id:

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 37: Code-Review+2 haven't actually tested this last rev on mac, assuming there weren't any new breakages

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#6). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread David Ribeiro Alves (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5894 to look at the new patch set (#2). Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#8). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/5818/5//COMMIT_MSG Commit Message: PS5,

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#7). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 2: Verified+1 Overriding jenkins (unrelated jenkins flakes). also tested

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5818/1/CMakeLists.txt File CMakeLists.txt:

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: (1 comment)

[kudu-CR] compaction: Flush tablet metadata before updating stores

2017-02-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction: Flush tablet metadata before updating stores .. Patch Set 1: (3 comments)

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5919 To

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#9). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5818/5//COMMIT_MSG Commit Message: PS5,

[kudu-CR] [thirdparty] Make Boost a regular dependency

2017-02-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5818 to look at the new patch set (#10). Change subject: [thirdparty] Make Boost a regular dependency .. [thirdparty]

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5894 Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. [thirdparty] Avoid building tsan on macOS on

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1835 (part 2): enable WAL compression .. Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/5736/8/src/kudu/consensus/log.cc File

[kudu-CR] [kudu-jepsen] fixed misprints in packaged mode

2017-01-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] fixed misprints in packaged mode .. Patch Set 1: (1 comment) also are you sure that the regular jenkins job would not be broken by the

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5737 To unsubscribe, visit

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-01-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5819 Change subject: WIP: Add a new TIMESTAMP type .. WIP: Add a new TIMESTAMP type This adds a new timestamp type that matches

[kudu-CR] [timestamp] Build and and add boost's date time lib

2017-01-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5818 Change subject: [timestamp] Build and and add boost's date_time lib .. [timestamp] Build and and add boost's date_time lib

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-01-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: WIP: Add a new TIMESTAMP type .. WIP: Add a new TIMESTAMP type This adds a new timestamp type that matches Impala's. The new type can be used as a key and

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1835 (part 2): enable WAL compression .. Patch Set 9: just a tiny nit, feel free to ignore or fix and keep the +2 -- To view, visit

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1835 (part 2): enable WAL compression .. Patch Set 9: Code-Review+2 (1 comment)

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-01-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5819 to look at the new patch set (#3). Change subject: WIP: Add a new TIMESTAMP type .. WIP: Add a new TIMESTAMP type

[kudu-CR] [timestamp] Build and and add boost's date time lib

2017-01-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Build and and add boost's date_time lib .. Patch Set 1: (1 comment)

[kudu-CR] docs: clarify guidelines on boost usage

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: docs: clarify guidelines on boost usage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5752 To unsubscribe, visit

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [kudu-jepsen] Kudu Jepsen tests .. [kudu-jepsen] Kudu Jepsen tests This patch contains David's code for the initial kudu-jepsen tests as it was

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 22: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] added Jenkins script .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5624/6//COMMIT_MSG Commit Message: PS6, Line 21: The

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] added Jenkins script .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5624 To unsubscribe, visit

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 22: I'm merging this anyway. We can address any docker specific issues in follow up patches. -- To view,

[kudu-CR] [kudu-jepsen] added Jenkins script

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] added Jenkins script .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/5624/6//COMMIT_MSG Commit Message: PS6, Line 12:

[kudu-CR] [timestamp] Build and and add boost's date time lib

2017-01-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Build and and add boost's date_time lib .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 11: (2 comments)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 9: (9 comments)

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-16 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5965 to look at the new patch set (#8). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 18: (13 comments) http://gerrit.cloudera.org:8080/#/c/4363/18//COMMIT_MSG

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 20: Code-Review+2 (1 comment)

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/cfile/binary_dict_block.h File

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 19: Code-Review+1 code lgtm, just waiting on those dist-test/cluster test

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

2017-02-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 1: do you have a test that reproduces this bug? not saying we absolutely need it but it

[kudu-CR] WIP: [catalog manager] fixed deadlock on catalog shutdown

2017-02-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/6134/2//COMMIT_MSG Commit

[kudu-CR] WIP: [catalog manager] fixed deadlock on catalog shutdown

2017-02-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 2: could you post a failure trace in the commit message? -- To view, visit

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

2017-02-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 4: (1 comment)

[kudu-CR] master: Do not acquire lock during CatalogManager::Init()

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: master: Do not acquire lock_ during CatalogManager::Init() .. Patch Set 4: Which follow up patch? Was this related to the "server-wide" op? Now that we

[kudu-CR] client-test-util: Increase ScanTableToStrings() timeout

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: client-test-util: Increase ScanTableToStrings() timeout .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6104 To

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 17: (1 comment)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 9: (23 comments) http://gerrit.cloudera.org:8080/#/c/4363/9//COMMIT_MSG Commit

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 13: (11 comments)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 16: (7 comments)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 12: (14 comments)

[kudu-CR] [timestamp] Add a new TIMESTAMP type

2017-02-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5819 to look at the new patch set (#4). Change subject: [timestamp] Add a new TIMESTAMP type .. [timestamp] Add a new

[kudu-CR] [timestamp] Add a new TIMESTAMP type

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TIMESTAMP type .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/5819/3/src/kudu/client/schema.h File

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5986/2/thirdparty/build-definitions.sh File

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: (1 comment) todd: just for internal tests and hidden + unsafe, yeah. mj: my problem with

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5986/1/thirdparty/build-definitions.sh File

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP type

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP type .. Patch Set 2: Verified+1 unrelated java flake -- To view, visit

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5982/1/src/kudu/server/hybrid_clock.cc

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5986/4/thirdparty/build-definitions.sh File

[kudu-CR] [timestamp] Add a new TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5819 to look at the new patch set (#5). Change subject: [timestamp] Add a new TIMESTAMP_NANOS type .. [timestamp] Add a

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#4). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 3: (16 comments)

[kudu-CR] [timestamp] Add a new TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TIMESTAMP_NANOS type .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5819/3/src/kudu/client/schema.h File

[kudu-CR] Add a helper method to determine whether the OS is macOS to KuduTest

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5981 to look at the new patch set (#2). Change subject: Add a helper method to determine whether the OS is macOS to KuduTest

[kudu-CR] Add a helper method to determine whether the OS is macOS to KuduTest

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a helper method to determine whether the OS is macOS to KuduTest .. Patch Set 1: (1 comment)

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#3). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP type .. [timestamp] Add a new TimestampValue class to support the TIMESTAMP type This

[kudu-CR] Add a helper method to determine whether the OS is macOS to KuduTest

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5981 to look at the new patch set (#3). Change subject: Add a helper method to determine whether the OS is macOS to KuduTest

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5965 to look at the new patch set (#5). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 5: Verified+1 unrelated flake -- To view, visit

[kudu-CR] [timestamp] Add a new TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5819 to look at the new patch set (#6). Change subject: [timestamp] Add a new TIMESTAMP_NANOS type .. [timestamp] Add a

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 4: (3 comments)

[kudu-CR] Add a helper method to determine whether the OS is macOS to KuduTest

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a helper method to determine whether the OS is macOS to KuduTest .. Patch Set 3: Verified+1 unrelated flake -- To view, visit

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5965 to look at the new patch set (#6). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 5: (7 comments)

[kudu-CR] [timestamp] Add a new TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TIMESTAMP_NANOS type .. Patch Set 6: Verified+1 unrelated flake RpcBench.BenchmarkCallsAsync -- To view, visit

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 6: (1 comment)

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5982 Change subject: Refactor HybridClock and add a local clock mode .. Refactor HybridClock and add a local clock mode Some test

[kudu-CR] Add a helper method to determine whether the OS is macOS to KuduTest

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5981 Change subject: Add a helper method to determine whether the OS is macOS to KuduTest .. Add a helper method to determine whether

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP type

2017-02-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5965 Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP type .. [timestamp] Add a new TimestampValue

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-02-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Add a new TIMESTAMP type .. Patch Set 3: (44 comments) Addressed all comments on the TimestampValue class (posted in another patch). Remaining

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 6: (1 comment)

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 6: (1 comment)

[kudu-CR] [timestamp] Add a new TIMESTAMP NANOS type

2017-02-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#7). Change subject: [timestamp] Add a new TIMESTAMP_NANOS type .. [timestamp] Add a new TIMESTAMP_NANOS type This adds a new type to Kudu and adds the ability to use it in

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-16 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5965 to look at the new patch set (#7). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5737/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: still planning on adding those numbers? -- To view, visit

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] Kudu Jepsen tests .. Patch Set 18: (7 comments) final q: does this still work with docker instances?

[kudu-CR] WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-02-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 1: (1 comment)

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 2: (2 comments)

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

2017-02-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6134 To unsubscribe,

  1   2   3   4   5   6   7   8   9   10   >