[kudu-CR] KUDU-1866: [WIP] Add request-side sidecars

Henry Robinson has uploaded a new patch set (#2). Change subject: KUDU-1866: [WIP] Add request-side sidecars .. KUDU-1866: [WIP] Add request-side sidecars This patch adds sidecars to client requests. Using the same mechanism as

[kudu-CR] KUDU-1866: [WIP] Add request-side sidecars

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5908 to look at the new patch set (#4). Change subject: KUDU-1866: [WIP] Add request-side sidecars .. KUDU-1866: [WIP]

[kudu-CR] KUDU-1866: [WIP] Add request-side sidecars

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5908 to look at the new patch set (#3). Change subject: KUDU-1866: [WIP] Add request-side sidecars .. KUDU-1866: [WIP]

[kudu-CR] KUDU-1866: Add request-side sidecars

Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 6: Rebased to include boost changes. -- To view, visit http://gerrit.cloudera.org:8080/5908 To unsubscribe,

[kudu-CR] KUDU-1866: Add request-side sidecars

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5908 to look at the new patch set (#5). Change subject: KUDU-1866: Add request-side sidecars .. KUDU-1866: Add

[kudu-CR] KUDU-1866: Add request-side sidecars

Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 4: (20 comments) http://gerrit.cloudera.org:8080/#/c/5908/4//COMMIT_MSG Commit Message: Line 7: KUDU-1866:

[kudu-CR] KUDU-1866: Add request-side sidecars

Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 6: Looks like an unrelated test failure to me, although I'm unable to build locally to confirm. -- To

[kudu-CR] KUDU-1866: Add request-side sidecars

Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5908/6/src/kudu/rpc/outbound_call.h File

[kudu-CR] KUDU-1866: Add request-side sidecars

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5908 to look at the new patch set (#7). Change subject: KUDU-1866: Add request-side sidecars .. KUDU-1866: Add

[kudu-CR] KUDU-1866: Add request-side sidecars

Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/5908/7/src/kudu/client/scanner-internal.cc File

[kudu-CR] KUDU-1866: Add request-side sidecars

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5908 to look at the new patch set (#8). Change subject: KUDU-1866: Add request-side sidecars .. KUDU-1866: Add

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6212 to look at the new patch set (#3). Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. KUDU-1887: Add

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

Henry Robinson has posted comments on this change. Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. Patch Set 1: Sorry, just saw the test comment. Coming up. -- To view, visit

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

Henry Robinson has uploaded a new patch set (#2). Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. KUDU-1887: Add RpcContext::DiscardTransfer() DiscardTransfer() allows RPC handlers to release the memory backing

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

Henry Robinson has posted comments on this change. Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6212/1/src/kudu/rpc/rpc_context.h File

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

Henry Robinson has posted comments on this change. Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. Patch Set 3: I will note, respectfully, that this will conflict with a trunk that doesn't include

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

Henry Robinson has posted comments on this change. Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. Patch Set 3: Test failure seems unrelated:

[kudu-CR] KUDU-1805: Properly qualify classes in generated svc headers

Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5478 Change subject: KUDU-1805: Properly qualify classes in generated svc headers .. KUDU-1805: Properly qualify classes in generated svc

[kudu-CR] Don't build kudu test * if NO TESTS set

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5711 to look at the new patch set (#2). Change subject: Don't build kudu_test_* if NO_TESTS set .. Don't build

[kudu-CR] Add NO NVM SUPPORT cmake var to suppress linking or compiling with nvm support

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5712 to look at the new patch set (#2). Change subject: Add NO_NVM_SUPPORT cmake var to suppress linking or compiling with nvm support

[kudu-CR] Add NO NVM SUPPORT cmake var to suppress linking or compiling with nvm support

Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5712 Change subject: Add NO_NVM_SUPPORT cmake var to suppress linking or compiling with nvm support .. Add NO_NVM_SUPPORT cmake var to

[kudu-CR] Add one more missing include in trace event impl.h

Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5713 Change subject: Add one more missing include in trace_event_impl.h .. Add one more missing include in trace_event_impl.h Change-Id:

[kudu-CR] Add NO NVM SUPPORT cmake var to suppress linking or compiling with nvm support

Henry Robinson has posted comments on this change. Change subject: Add NO_NVM_SUPPORT cmake var to suppress linking or compiling with nvm support .. Patch Set 2: We consume kudu_util by dropping it in our source dir, and

[kudu-CR] Don't build kudu test * if NO TESTS set

Henry Robinson has posted comments on this change. Change subject: Don't build kudu_test_* if NO_TESTS set .. Patch Set 2: My reason is that adding set(NO_TESTS 1) in an Impala CMakefile.txts looks weird if it doesn't

[kudu-CR] Don't build kudu test * if NO TESTS set

Henry Robinson has posted comments on this change. Change subject: Don't build kudu_test_* if NO_TESTS set .. Patch Set 2: > If you volunteer to make the changes I'm fine with it. I can point you in the > right direction.

[kudu-CR] Don't build kudu test * if NO TESTS set

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5711 to look at the new patch set (#3). Change subject: Don't build kudu_test_* if NO_TESTS set .. Don't build

[kudu-CR] Add NO NVM SUPPORT cmake var to suppress linking or compiling with nvm support

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5712 to look at the new patch set (#3). Change subject: Add NO_NVM_SUPPORT cmake var to suppress linking or compiling with nvm support

[kudu-CR] Add NO NVM SUPPORT cmake var to suppress linking or compiling with nvm support

Henry Robinson has posted comments on this change. Change subject: Add NO_NVM_SUPPORT cmake var to suppress linking or compiling with nvm support .. Patch Set 2: (1 comment)

[kudu-CR] Fix some minor compilation issues

Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5643 Change subject: Fix some minor compilation issues .. Fix some minor compilation issues A few small issues manifested themselves while

[kudu-CR] rpc-bench: add ability to enable encryption

Henry Robinson has posted comments on this change. Change subject: rpc-bench: add ability to enable encryption .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6551 To unsubscribe, visit

[kudu-CR] Add InboundCall::GetTransferSize()

Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6374 Change subject: Add InboundCall::GetTransferSize() .. Add InboundCall::GetTransferSize() Returns what you might expect: the size of

[kudu-CR] KUDU-1866: Add request-side sidecars

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5908 to look at the new patch set (#9). Change subject: KUDU-1866: Add request-side sidecars .. KUDU-1866: Add

[kudu-CR] KUDU-1866: Add request-side sidecars

Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 8: Test failures due to Java client incompatibility. Will have to rethink (and probably revert) use of

[kudu-CR] KUDU-1866: Add request-side sidecars

Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 8: (13 comments) Thanks for the review!

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6212 Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() .. KUDU-1887: Add RpcContext::DiscardTransfer() DiscardTransfer() allows

[kudu-CR] KUDU-1887: Add RpcContext::DiscardTransfer()

Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6212 to look at the new patch set (#4). Change subject: KUDU-1887: Add RpcContext::DiscardTransfer() ..

[kudu-CR] KUDU-1866: Add request-side sidecars

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5908 to look at the new patch set (#11). Change subject: KUDU-1866: Add request-side sidecars .. KUDU-1866: Add

[kudu-CR] KUDU-1866: Add request-side sidecars

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5908 to look at the new patch set (#10). Change subject: KUDU-1866: Add request-side sidecars .. KUDU-1866: Add

[kudu-CR] KUDU-1866: Add request-side sidecars

Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 11: Reverted to 32-bit offsets, and rebased to fix a merge conflict. -- To view, visit

[kudu-CR] Add NO NVM SUPPORT cmake var to suppress linking or compiling with nvm support

Henry Robinson has abandoned this change. Change subject: Add NO_NVM_SUPPORT cmake var to suppress linking or compiling with nvm support .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5712 To unsubscribe,

[kudu-CR] KUDU-2041: Fix negotiation deadlock

Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7177 Change subject: KUDU-2041: Fix negotiation deadlock .. KUDU-2041: Fix negotiation deadlock With N threads in the negotiation

[kudu-CR] KUDU-2041: Fix negotiation deadlock

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7177 to look at the new patch set (#2). Change subject: KUDU-2041: Fix negotiation deadlock .. KUDU-2041: Fix

[kudu-CR] KUDU-2041: Fix negotiation deadlock

Henry Robinson has posted comments on this change. Change subject: KUDU-2041: Fix negotiation deadlock .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7177/1/src/kudu/rpc/messenger.cc File

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

Henry Robinson has posted comments on this change. Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 2: (1 comment)