[kudu-CR] Kudu-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-18 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9069 Change subject: Kudu-2126: Add conditional check to prevent unnecessary fsyncs .. Kudu-2126: Add conditional check to prevent

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has abandoned this change. ( http://gerrit.cloudera.org:8080/9042 ) Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess .. Abandoned Wrong commit -- To view, visit

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9042 Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess .. KUDU-2208 Add RETRY_ON_EINTR() to Subprocess This patch submits a

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9015 ) Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess .. Patch Set 12: (4 comments)

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#12). Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess ..

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#5). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

[kudu-CR] Kudu-2208 Avoid system call interruption in Subprocess

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9011 ) Change subject: Kudu-2208 Avoid system call interruption in Subprocess .. Patch Set 1: (12 comments)

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#8). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#7). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#9). Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess ..

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9015 ) Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug .. Patch Set

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#6). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

[kudu-CR] Kudu-2208 Avoid system call interruption in Subprocess

2018-01-11 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9011 Change subject: Kudu-2208 Avoid system call interruption in Subprocess .. Kudu-2208 Avoid system call interruption in Subprocess

[kudu-CR] KUDU-2208 Refine unit test and move RETRY ON EINTR() to os-util.h

2018-01-11 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9015 Change subject: KUDU-2208 Refine unit test and move RETRY_ON_EINTR() to os-util.h .. KUDU-2208 Refine unit test and move

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-11 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#2). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#3). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#10). Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess ..

[kudu-CR] Kudu-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-18 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9069 ) Change subject: Kudu-2126: Add conditional check to prevent unnecessary fsyncs .. Patch Set 1: (5 comments)

[kudu-CR] KUDU-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-18 Thread Jeffrey F. Lukman (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9069 to look at the new patch set (#2). Change subject: KUDU-2126: Add conditional check to prevent unnecessary fsyncs

[kudu-CR] Kudu-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-18 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9069 ) Change subject: Kudu-2126: Add conditional check to prevent unnecessary fsyncs .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-19 Thread Jeffrey F. Lukman (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9069 to look at the new patch set (#3). Change subject: KUDU-2126: Add conditional check to prevent unnecessary fsyncs

[kudu-CR] KUDU-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-19 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9069 ) Change subject: KUDU-2126: Add conditional check to prevent unnecessary fsyncs .. Patch Set 3: (9 comments)

[kudu-CR] KUDU-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-19 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9069 ) Change subject: KUDU-2126: Add conditional check to prevent unnecessary fsyncs .. Patch Set 3: > Quick question: did you try