[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-08 Thread Adar Dembo (Code Review) 
Adar Dembo has submitted this change and it was merged.

Change subject: [server] clean-up: stringstream --> ostringstream
..


[server] clean-up: stringstream --> ostringstream

Replaced std::stringstream with std::ostringstream in places
where only output stream functionality is required from the
stream buffer class.

Include iosfwd instead of stream headers for forward declarations.
Minor clean-up on header files include order to be in line
with the styling guide.

There are not any functional changes in this changelist.

Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Reviewed-on: http://gerrit.cloudera.org:8080/4303
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley 
---
M src/kudu/client/samples/sample.cc
M src/kudu/codegen/code_generator.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-path-handlers.h
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/pprof-path-handlers.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/server_base.cc
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/server/tracing-path-handlers.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/server/webui_util.cc
M src/kudu/server/webui_util.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/fs_dump-tool.cc
M src/kudu/tools/fs_list-tool.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tserver/tablet_server-stress-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/tserver/tserver-path-handlers.h
M src/kudu/util/jsonwriter.cc
M src/kudu/util/jsonwriter.h
M src/kudu/util/logging.cc
M src/kudu/util/mem_tracker.cc
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/os-util.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/spinlock_profiling-test.cc
M src/kudu/util/spinlock_profiling.cc
M src/kudu/util/spinlock_profiling.h
M src/kudu/util/thread.cc
M src/kudu/util/thread.h
M src/kudu/util/trace.cc
M src/kudu/util/url-coding-test.cc
M src/kudu/util/url-coding.cc
M src/kudu/util/url-coding.h
M src/kudu/util/web_callback_registry.h
43 files changed, 228 insertions(+), 192 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Will Berkeley: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: [server] clean-up: stringstream --> ostringstream
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Alexey Serbin (Code Review) 
Hello Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4303

to look at the new patch set (#3).

Change subject: [server] clean-up: stringstream --> ostringstream
..

[server] clean-up: stringstream --> ostringstream

Replaced std::stringstream with std::ostringstream in places
where only output stream functionality is required from the
stream buffer class.

Include iosfwd instead of stream headers for forward declarations.
Minor clean-up on header files include order to be in line
with the styling guide.

There are not any functional changes in this changelist.

Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
---
M src/kudu/client/samples/sample.cc
M src/kudu/codegen/code_generator.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-path-handlers.h
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/pprof-path-handlers.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/server_base.cc
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/server/tracing-path-handlers.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/server/webui_util.cc
M src/kudu/server/webui_util.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/fs_dump-tool.cc
M src/kudu/tools/fs_list-tool.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tserver/tablet_server-stress-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/tserver/tserver-path-handlers.h
M src/kudu/util/jsonwriter.cc
M src/kudu/util/jsonwriter.h
M src/kudu/util/logging.cc
M src/kudu/util/mem_tracker.cc
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/os-util.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/spinlock_profiling-test.cc
M src/kudu/util/spinlock_profiling.cc
M src/kudu/util/spinlock_profiling.h
M src/kudu/util/thread.cc
M src/kudu/util/thread.h
M src/kudu/util/trace.cc
M src/kudu/util/url-coding-test.cc
M src/kudu/util/url-coding.cc
M src/kudu/util/url-coding.h
M src/kudu/util/web_callback_registry.h
43 files changed, 228 insertions(+), 192 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/4303/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: [server] clean-up: stringstream --> ostringstream
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/3215/

-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change.

Change subject: [server] clean-up: stringstream --> ostringstream
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4303/2/src/kudu/util/mem_tracker.cc
File src/kudu/util/mem_tracker.cc:

Line 78: using std::shared_ptr;
> Nit: not your fault, but this should precede std::string.
Good catch!  Somehow I missed that while re-ordering the rest of the 'using' 
directives.  I'll fix this.


-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: [server] clean-up: stringstream --> ostringstream
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/3214/

-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change.

Change subject: [server] clean-up: stringstream --> ostringstream
..


Patch Set 1:

(1 comment)

> (1 comment)
 > 
 > If you're interested in fixing these kinds of issues, you can take
 > a crack at getting include-what-you-use (http://include-what-you-use.org/)
 > working with Kudu. Bonus points if you can make it part of
 > precommit builds.

Thank you for the link!  It seems to be a useful tool to have.  Will take a 
look how to make it work for the Kudu project.

http://gerrit.cloudera.org:8080/#/c/4303/1/src/kudu/client/samples/sample.cc
File src/kudu/client/samples/sample.cc:

Line 51: using std::ostringstream;
> Nit: resort. Here and in other places where you've changed "using std::stri
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Will Berkeley (Code Review) 
Will Berkeley has posted comments on this change.

Change subject: [server] clean-up: stringstream --> ostringstream
..


Patch Set 1: Code-Review+1

LGTM besides Adar's nit.

-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: [server] clean-up: stringstream --> ostringstream
..


Patch Set 1:

(1 comment)

If you're interested in fixing these kinds of issues, you can take a crack at 
getting include-what-you-use (http://include-what-you-use.org/) working with 
Kudu. Bonus points if you can make it part of precommit builds.

http://gerrit.cloudera.org:8080/#/c/4303/1/src/kudu/client/samples/sample.cc
File src/kudu/client/samples/sample.cc:

Line 51: using std::ostringstream;
Nit: resort. Here and in other places where you've changed "using 
std::stringstream" to "using std::ostringstream".


-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-02 Thread Alexey Serbin (Code Review) 
Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4303

Change subject: [server] clean-up: stringstream --> ostringstream
..

[server] clean-up: stringstream --> ostringstream

Replaced std::stringstream with std::ostringstream in places
where only output stream functionality is required from the
stream buffer class.

Include iosfwd instead of stream headers for forward declarations.
Minor clean-up on header files include order to be in line
with the styling guide.

There are no functional changes in this changelist.

Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
---
M src/kudu/client/samples/sample.cc
M src/kudu/codegen/code_generator.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-path-handlers.h
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/pprof-path-handlers.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/server_base.cc
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/server/tracing-path-handlers.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/server/webui_util.cc
M src/kudu/server/webui_util.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/fs_dump-tool.cc
M src/kudu/tools/fs_list-tool.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tserver/tablet_server-stress-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/tserver/tserver-path-handlers.h
M src/kudu/util/jsonwriter.cc
M src/kudu/util/jsonwriter.h
M src/kudu/util/logging.cc
M src/kudu/util/mem_tracker.cc
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/os-util.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/spinlock_profiling-test.cc
M src/kudu/util/spinlock_profiling.cc
M src/kudu/util/spinlock_profiling.h
M src/kudu/util/thread.cc
M src/kudu/util/thread.h
M src/kudu/util/trace.cc
M src/kudu/util/url-coding-test.cc
M src/kudu/util/url-coding.cc
M src/kudu/util/url-coding.h
M src/kudu/util/web_callback_registry.h
43 files changed, 222 insertions(+), 187 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/4303/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin