[kudu-CR] Fix compilation warnings under debian8.9

2019-02-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Fix compilation warnings under debian8.9 It seems there are some comp

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12294 to look at the new patch set (#4). Change subject: Fix compilation warnings under debian8.9 .. Fix comp

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12294/3/src/kudu/c

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12294/3/src/ku

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12294 to look at the new patch set (#3). Change subject: Fix compilation warnings under debian8.9 .. Fix comp

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 2: "and the same to the other files" means: src/kudu/consensus/log-test

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12294/1/src/kudu/c

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12294/1/src/ku

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-13 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12294 to look at the new patch set (#2). Change subject: Fix compilation warnings under debian8.9 .. Fix comp

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-13 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/12294/1/src/kudu/c

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 1: (8 comments) I think the main point of contention is over what

[kudu-CR] Fix compilation warnings under debian8.9

2019-01-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/12294/1/src/kudu/c

[kudu-CR] Fix compilation warnings under debian8.9

2019-01-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 1: (9 comments) I started to review this but stopped because it lo

[kudu-CR] Fix compilation warnings under debian8.9

2019-01-29 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12294 Change subject: Fix compilation warnings under debian8.9 .. Fix compilation warnings under debian8.9 It seems there are some compilation warni