[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL

2016-08-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4067/1/java/kudu-csd/check_csd_compatibility.py

[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL

2016-08-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 2: Oops, just realized I missed Mike's code review comments above. Will address these in a follow-on

[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL

2016-08-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. KUDU-1571. Generate "deprecated" metrics in MDL This checks in the "--dump_metrics_json" output from al

[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL

2016-08-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 1: To fill in anyone following along, adar and I had an offline discussion about this over the weeken

[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL

2016-08-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 1: -Code-Review Removing my -1 based on our discussion. -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL

2016-08-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 1: Code-Review-1 I would prefer we don't go down this route. It's adding complexity to our release pro

[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL

2016-08-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 1: Code-Review+2 (2 comments) I found a couple nits, if you have time to fix them please just +2 this

[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL

2016-08-19 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4067 to review the following change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. KUDU-157

[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL

2016-08-19 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3001/ -- To view, visit http://gerrit.cloude