[kudu-CR] KUDU-2645: schema: Validate that defaults are provided for virtual columns
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12416 ) Change subject: KUDU-2645: schema: Validate that defaults are provided for virtual columns .. KUDU-2645: schema: Validate that defaults are provided for virtual columns Virtual columns must not be nullable and must have read defaults. Instead of crashing when we encounter violations of these requirements, return a bad status code when mapping such a projection onto a tablet schema. TODO(KUDU-2692): Consider removing the requirement to specify a read default on a virtual column by defining a built-in read default for each virtual column type, such as a default of false for IS_DELETED. Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe Reviewed-on: http://gerrit.cloudera.org:8080/12416 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M src/kudu/common/schema-test.cc M src/kudu/common/schema.cc M src/kudu/common/schema.h 3 files changed, 33 insertions(+), 1 deletion(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe Gerrit-Change-Number: 12416 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2645: schema: Validate that defaults are provided for virtual columns
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12416 ) Change subject: KUDU-2645: schema: Validate that defaults are provided for virtual columns .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe Gerrit-Change-Number: 12416 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 28 Feb 2019 00:40:35 + Gerrit-HasComments: No
[kudu-CR] KUDU-2645: schema: Validate that defaults are provided for virtual columns
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12416 ) Change subject: KUDU-2645: schema: Validate that defaults are provided for virtual columns .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12416/4/src/kudu/common/schema-test.cc File src/kudu/common/schema-test.cc: http://gerrit.cloudera.org:8080/#/c/12416/4/src/kudu/common/schema-test.cc@448 PS4, Line 448: ASSERT_OK(tablet_schema.GetMappedReadProjection(projection, &mapped)); > Maybe also test that the new error paths are taken given the appropriate in Done -- To view, visit http://gerrit.cloudera.org:8080/12416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe Gerrit-Change-Number: 12416 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 28 Feb 2019 00:10:51 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2645: schema: Validate that defaults are provided for virtual columns
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12416 to look at the new patch set (#5). Change subject: KUDU-2645: schema: Validate that defaults are provided for virtual columns .. KUDU-2645: schema: Validate that defaults are provided for virtual columns Virtual columns must not be nullable and must have read defaults. Instead of crashing when we encounter violations of these requirements, return a bad status code when mapping such a projection onto a tablet schema. TODO(KUDU-2692): Consider removing the requirement to specify a read default on a virtual column by defining a built-in read default for each virtual column type, such as a default of false for IS_DELETED. Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe --- M src/kudu/common/schema-test.cc M src/kudu/common/schema.cc M src/kudu/common/schema.h 3 files changed, 33 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/12416/5 -- To view, visit http://gerrit.cloudera.org:8080/12416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe Gerrit-Change-Number: 12416 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2645: schema: Validate that defaults are provided for virtual columns
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12416 ) Change subject: KUDU-2645: schema: Validate that defaults are provided for virtual columns .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12416/4/src/kudu/common/schema-test.cc File src/kudu/common/schema-test.cc: http://gerrit.cloudera.org:8080/#/c/12416/4/src/kudu/common/schema-test.cc@448 PS4, Line 448: ASSERT_OK(tablet_schema.GetMappedReadProjection(projection, &mapped)); Maybe also test that the new error paths are taken given the appropriate input? -- To view, visit http://gerrit.cloudera.org:8080/12416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe Gerrit-Change-Number: 12416 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 13 Feb 2019 04:35:24 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2645: schema: Validate that defaults are provided for virtual columns
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12416 to look at the new patch set (#3). Change subject: KUDU-2645: schema: Validate that defaults are provided for virtual columns .. KUDU-2645: schema: Validate that defaults are provided for virtual columns Virtual columns must not be nullable and must have read defaults. Instead of crashing when we encounter violations of these requirements, return a bad status code when mapping such a projection onto a tablet schema. TODO(KUDU-2692): Consider removing the requirement to specify a read default on a virtual column by defining a built-in read default for each virtual column type, such as a default of false for IS_DELETED. Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe --- M src/kudu/common/schema-test.cc M src/kudu/common/schema.cc M src/kudu/common/schema.h 3 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/12416/3 -- To view, visit http://gerrit.cloudera.org:8080/12416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe Gerrit-Change-Number: 12416 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2645: schema: Validate that defaults are provided for virtual columns
Hello Will Berkeley, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12416 to review the following change. Change subject: KUDU-2645: schema: Validate that defaults are provided for virtual columns .. KUDU-2645: schema: Validate that defaults are provided for virtual columns Virtual columns must not be nullable and must have read defaults. Instead of crashing when we encounter violations of these requirements, return a bad status code when mapping such a projection onto a tablet schema. TODO(KUDU-2692): Consider removing the requirement to specify a read default on a virtual column by defining a built-in read default for each virtual column type, such as a default of false for IS_DELETED. Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe --- M src/kudu/common/schema.cc M src/kudu/common/schema.h 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/12416/1 -- To view, visit http://gerrit.cloudera.org:8080/12416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe Gerrit-Change-Number: 12416 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Will Berkeley
