[kudu-CR] Timestamp::FromUint64 should return void

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged.

Change subject: Timestamp::FromUint64 should return void
..


Timestamp::FromUint64 should return void

It does no validation, can't fail, and has the same signature as one of
Timestamp's explicit constructors.

Change-Id: I98d487abb7b9e947b6c8c0a291812f790407242e
Reviewed-on: http://gerrit.cloudera.org:8080/3943
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M src/kudu/common/timestamp.cc
M src/kudu/common/timestamp.h
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/tablet_bootstrap.cc
4 files changed, 5 insertions(+), 7 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98d487abb7b9e947b6c8c0a291812f790407242e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Timestamp::FromUint64 should return void

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Timestamp::FromUint64 should return void
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98d487abb7b9e947b6c8c0a291812f790407242e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Timestamp::FromUint64 should return void

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change.

Change subject: Timestamp::FromUint64 should return void
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3943/1/src/kudu/common/timestamp.h
File src/kudu/common/timestamp.h:

Line 61:   void FromUint64(uint64_t value);
> hrm, maybe better to just remove this and use: ts = Timestamp(value) instea
I don't know if it helps to not provide this mutation method because we also 
have bool DecodeFrom(Slice *input), as well as symmetrical methods ToUint64() 
and EncodeTo(faststring* s)


-- 
To view, visit http://gerrit.cloudera.org:8080/3943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98d487abb7b9e947b6c8c0a291812f790407242e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Timestamp::FromUint64 should return void

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Timestamp::FromUint64 should return void
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3943/1/src/kudu/common/timestamp.h
File src/kudu/common/timestamp.h:

Line 61:   void FromUint64(uint64_t value);
hrm, maybe better to just remove this and use: ts = Timestamp(value) instead?


-- 
To view, visit http://gerrit.cloudera.org:8080/3943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98d487abb7b9e947b6c8c0a291812f790407242e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes