[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. cfile: change BlockBuilder API to yield a vector of

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 7: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded a new patch set (#7) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. cfile: cha

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-07 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-06 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded a new patch set (#6) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. cfile: cha

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-03 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 5: > Patch Set 5: Verified-1 > > Build Failed

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-03 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded a new patch set (#5) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. cfile: cha

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 4: Code-Review+2 For some reason, IWYU is stil

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15042 to look at the new patch set (#4). Change subject: cfile: change BlockBuilder API to yield a vector of Slices ..

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:80

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:80

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15042 to look at the new patch set (#2). Change subject: cfile: change BlockBuilder API to yield a vector of Slices ..

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:80

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15042 to review the following change. Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. cfile