[kudu-CR] decimal util: do not produce warnings when building with gcc
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9499 ) Change subject: decimal_util: do not produce warnings when building with gcc .. decimal_util: do not produce warnings when building with gcc When I build with gcc5, I get the following warning: ../../src/kudu/util/decimal_util.cc:31:45: warning: ‘no_sanitize’ attribute directive ignored [-Wattributes] int128_t MaxUnscaledDecimal(int8_t precision) { This is because gcc doesn't recognize the "no_sanitize" attribute, so let's deal with this as we've dealt with other sanitizer suppressions: compile it conditionally using ASAN support as a proxy. Change-Id: Iac9b145a914d551e3a18d62a0984aad34b95f4dd Reviewed-on: http://gerrit.cloudera.org:8080/9499 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke --- M src/kudu/gutil/port.h M src/kudu/util/decimal_util.cc 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Kudu Jenkins: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iac9b145a914d551e3a18d62a0984aad34b95f4dd Gerrit-Change-Number: 9499 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] decimal util: do not produce warnings when building with gcc
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9499 ) Change subject: decimal_util: do not produce warnings when building with gcc .. Patch Set 1: Code-Review+2 Sorry I missed this pattern. Thanks for fixing it. -- To view, visit http://gerrit.cloudera.org:8080/9499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac9b145a914d551e3a18d62a0984aad34b95f4dd Gerrit-Change-Number: 9499 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 06 Mar 2018 01:55:23 + Gerrit-HasComments: No
[kudu-CR] decimal util: do not produce warnings when building with gcc
Hello Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9499 to review the following change. Change subject: decimal_util: do not produce warnings when building with gcc .. decimal_util: do not produce warnings when building with gcc When I build with gcc5, I get the following warning: ../../src/kudu/util/decimal_util.cc:31:45: warning: ‘no_sanitize’ attribute directive ignored [-Wattributes] int128_t MaxUnscaledDecimal(int8_t precision) { This is because gcc doesn't recognize the "no_sanitize" attribute, so let's deal with this as we've dealt with other sanitizer suppressions: compile it conditionally using ASAN support as a proxy. Change-Id: Iac9b145a914d551e3a18d62a0984aad34b95f4dd --- M src/kudu/gutil/port.h M src/kudu/util/decimal_util.cc 2 files changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9499/1 -- To view, visit http://gerrit.cloudera.org:8080/9499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iac9b145a914d551e3a18d62a0984aad34b95f4dd Gerrit-Change-Number: 9499 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Todd Lipcon