[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 5: Verified+1 Overriding Jenkins, unrelated TSAN failure. -- To

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. rpc-test: fix TestClientConnectionMetrics Every now and then, this

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 5: (1 comment)

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11819 to look at the new patch set (#5). Change subject: rpc-test: fix TestClientConnectionMetrics

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 4: Verified+1 Overriding Jenkins, unrelated test failure. -- To

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11819 to look at the new patch set (#4). Change subject: rpc-test: fix TestClientConnectionMetrics

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11819 to look at the new patch set (#3). Change subject: rpc-test: fix TestClientConnectionMetrics

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11819 to look at the new patch set (#2). Change subject: rpc-test: fix TestClientConnectionMetrics

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 1: (2 comments)

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11819 ) Change subject: rpc-test: fix TestClientConnectionMetrics .. Patch Set 1: (2 comments) Looks good, just a couple of nits.

[kudu-CR] rpc-test: fix TestClientConnectionMetrics

2018-10-29 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11819 to review the following change. Change subject: rpc-test: fix TestClientConnectionMetrics .. rpc-test: fix