[GitHub] risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r251874471 ## File path: server/src/main/scala/org/apache/livy/server/batch/BatchSession.scala ## @@ -55,12

[GitHub] risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r251920501 ## File path: server/src/main/scala/org/apache/livy/server/batch/BatchSession.scala ## @@ -55,12

[GitHub] risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r251969368 ## File path: server/src/main/scala/org/apache/livy/server/AccessManager.scala ## @@ -98,46 +99,51

[GitHub] vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r251979904 ## File path: server/src/test/scala/org/apache/livy/sessions/SessionManagerSpec.scala ## @@

[GitHub] vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r251975051 ## File path: server/src/main/scala/org/apache/livy/sessions/Session.scala ## @@ -135,13

[GitHub] vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r251979096 ## File path: server/src/test/scala/org/apache/livy/server/recovery/BlackholeStateStoreSpec.scala

[GitHub] vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r251974744 ## File path: server/src/main/scala/org/apache/livy/sessions/Session.scala ## @@ -135,13

[GitHub] vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r251978290 ## File path: server/src/test/scala/org/apache/livy/server/batch/BatchSessionSpec.scala ## @@

[GitHub] vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r251977754 ## File path: server/src/test/scala/org/apache/livy/server/batch/BatchServletSpec.scala ## @@

[GitHub] vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r251979737 ## File path: server/src/test/scala/org/apache/livy/sessions/SessionManagerSpec.scala ## @@

[GitHub] vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r251978628 ## File path:

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r251888435 ## File path: server/src/main/scala/org/apache/livy/server/AccessManager.scala ## @@ -98,46 +99,51

[GitHub] codecov-io edited a comment on issue #141: [LIVY-551] Add "doAs" impersonation support

codecov-io edited a comment on issue #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#issuecomment-457216469 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/141?src=pr=h1) Report > Merging

[GitHub] meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r252050251 ## File path: server/src/main/scala/org/apache/livy/sessions/Session.scala ## @@ -135,13

[GitHub] meisam commented on issue #48: [LIVY-41] Let users access sessions by session name

meisam commented on issue #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#issuecomment-458758500 > To support multi-master HA without this feature, the only thing we need is a distributed atomic counter (which ZK offers).

[GitHub] meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r252070640 ## File path: server/src/test/scala/org/apache/livy/sessions/SessionManagerSpec.scala ## @@

[GitHub] alex-the-man commented on issue #48: [LIVY-41] Let users access sessions by session name

alex-the-man commented on issue #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#issuecomment-458735263 Have we considered the potential impact of this change for Livy multi-master HA? To support multi-master HA without this

[GitHub] meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r252071059 ## File path: server/src/main/scala/org/apache/livy/sessions/Session.scala ## @@ -135,13

[GitHub] meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r252070991 ## File path: server/src/main/scala/org/apache/livy/sessions/Session.scala ## @@ -135,13

[GitHub] meisam edited a comment on issue #48: [LIVY-41] Let users access sessions by session name

meisam edited a comment on issue #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#issuecomment-458758500 > To support multi-master HA without this feature, the only thing we need is a distributed atomic counter (which ZK

[GitHub] meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r252070742 ## File path: server/src/test/scala/org/apache/livy/server/interactive/InteractiveSessionSpec.scala

[GitHub] meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r252070775 ## File path:

[GitHub] meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r252070896 ## File path: server/src/test/scala/org/apache/livy/server/batch/BatchServletSpec.scala ## @@

[GitHub] meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name

meisam commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r252070692 ## File path: server/src/test/scala/org/apache/livy/sessions/SessionManagerSpec.scala ## @@

[GitHub] alex-the-man commented on issue #136: [LIVY-545] Try to clear buffer by judge expired or not, rather than drop Eldest …

alex-the-man commented on issue #136: [LIVY-545] Try to clear buffer by judge expired or not, rather than drop Eldest … URL: https://github.com/apache/incubator-livy/pull/136#issuecomment-458846204 Would you mind describing how you are using interactive sessions?

[GitHub] alex-the-man commented on a change in pull request #142: [LIVY-552][WIP] Add JWTFilter to validate incoming JWT tokens

alex-the-man commented on a change in pull request #142: [LIVY-552][WIP] Add JWTFilter to validate incoming JWT tokens URL: https://github.com/apache/incubator-livy/pull/142#discussion_r252144906 ## File path: server/src/main/scala/org/apache/livy/LivyConf.scala ## @@

[GitHub] alex-the-man commented on a change in pull request #142: [LIVY-552][WIP] Add JWTFilter to validate incoming JWT tokens

alex-the-man commented on a change in pull request #142: [LIVY-552][WIP] Add JWTFilter to validate incoming JWT tokens URL: https://github.com/apache/incubator-livy/pull/142#discussion_r252144906 ## File path: server/src/main/scala/org/apache/livy/LivyConf.scala ## @@

[GitHub] alex-the-man commented on issue #138: [LIVY-547]do not check expire when session in state busy

alex-the-man commented on issue #138: [LIVY-547]do not check expire when session in state busy URL: https://github.com/apache/incubator-livy/pull/138#issuecomment-458838900 I agree the current GC behaviour is not well documented. As a first step I will document them in LivyConf.scala.

[GitHub] meisam closed pull request #48: [LIVY-41] Let users access sessions by session name

meisam closed pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] alex-the-man commented on issue #140: quick failure when error happens in spark-submit process

alex-the-man commented on issue #140: quick failure when error happens in spark-submit process URL: https://github.com/apache/incubator-livy/pull/140#issuecomment-458835733 Without this fix, the app state should still transit to FAILED after 2 minutes with default configuration. Is this

[GitHub] alex-the-man commented on issue #110: [LIVY-508][Server] Support custom auth filter for livy server

alex-the-man commented on issue #110: [LIVY-508][Server] Support custom auth filter for livy server URL: https://github.com/apache/incubator-livy/pull/110#issuecomment-45884 Can I merge this? I believe this will enable #142.

[GitHub] risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r251865586 ## File path: server/src/main/scala/org/apache/livy/server/AccessManager.scala ## @@ -98,46 +99,51

[GitHub] risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r251865832 ## File path: server/src/main/scala/org/apache/livy/server/SessionServlet.scala ## @@ -156,9

[GitHub] risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r251865549 ## File path: server/src/main/scala/org/apache/livy/server/AccessManager.scala ## @@ -98,46 +99,51