[GitHub] [incubator-livy] yiheng commented on a change in pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-05 Thread GitBox
yiheng commented on a change in pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224#discussion_r321206825 ## File path: rsc/src/main/java/org/apache/livy/rsc/RSCClient.java ## @@

[GitHub] [incubator-livy] mgaido91 commented on issue #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on issue #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#issuecomment-528339029 Thanks. Merging to master. This is an automated message from the Apache Git

[GitHub] [incubator-livy] mgaido91 commented on issue #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on issue #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer URL: https://github.com/apache/incubator-livy/pull/195#issuecomment-528373150 > However, if we do it, it also means livy-server module will have a dependency on

[GitHub] [incubator-livy] mgaido91 edited a comment on issue #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

2019-09-05 Thread GitBox
mgaido91 edited a comment on issue #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer URL: https://github.com/apache/incubator-livy/pull/195#issuecomment-528373150 > However, if we do it, it also means livy-server module will have a

[GitHub] [incubator-livy] mgaido91 closed pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 closed pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-livy] yiheng commented on a change in pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-05 Thread GitBox
yiheng commented on a change in pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224#discussion_r321209809 ## File path:

[GitHub] [incubator-livy] codecov-io edited a comment on issue #212: [LIVY-11] Enable HA support

2019-09-05 Thread GitBox
codecov-io edited a comment on issue #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#issuecomment-525101672 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/212?src=pr=h1) Report > Merging

[GitHub] [incubator-livy] codecov-io edited a comment on issue #205: [LIVY-628][LIVY-629][LIVY-630][THRIFT][WIP]: Support getDelegationToken, cancelDelegationToken, renewDelegationToken

2019-09-05 Thread GitBox
codecov-io edited a comment on issue #205: [LIVY-628][LIVY-629][LIVY-630][THRIFT][WIP]: Support getDelegationToken, cancelDelegationToken, renewDelegationToken URL: https://github.com/apache/incubator-livy/pull/205#issuecomment-528695104 #

[GitHub] [incubator-livy] codecov-io commented on issue #205: [LIVY-628][LIVY-629][LIVY-630][THRIFT][WIP]: Support getDelegationToken, cancelDelegationToken, renewDelegationToken

2019-09-05 Thread GitBox
codecov-io commented on issue #205: [LIVY-628][LIVY-629][LIVY-630][THRIFT][WIP]: Support getDelegationToken, cancelDelegationToken, renewDelegationToken URL: https://github.com/apache/incubator-livy/pull/205#issuecomment-528695104 #

[GitHub] [incubator-livy] jerryshao commented on issue #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

2019-09-05 Thread GitBox
jerryshao commented on issue #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer URL: https://github.com/apache/incubator-livy/pull/195#issuecomment-528711140 Hi @mgaido91 , I think what I mean is whether we could unify two authentication

[GitHub] [incubator-livy] lys0716 opened a new pull request #227: [DOC] Add missing session kind in documentation

2019-09-05 Thread GitBox
lys0716 opened a new pull request #227: [DOC] Add missing session kind in documentation URL: https://github.com/apache/incubator-livy/pull/227 ## What changes were proposed in this pull request? Add missing session kind in documentation. ## How was this patch tested?

[GitHub] [incubator-livy] runzhiwang opened a new pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished

2019-09-05 Thread GitBox
runzhiwang opened a new pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished URL: https://github.com/apache/incubator-livy/pull/222 ## What changes were proposed in this pull request? Fix travis failed on "batch session

[GitHub] [incubator-livy] jerryshao closed pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished

2019-09-05 Thread GitBox
jerryshao closed pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished URL: https://github.com/apache/incubator-livy/pull/222 This is an automated message from the

[GitHub] [incubator-livy] jerryshao closed pull request #207: [LIVY-645]Add Session Name, Owner, Proxy User information to Web UI

2019-09-05 Thread GitBox
jerryshao closed pull request #207: [LIVY-645]Add Session Name, Owner, Proxy User information to Web UI URL: https://github.com/apache/incubator-livy/pull/207 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-livy] jerryshao commented on a change in pull request #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names

2019-09-05 Thread GitBox
jerryshao commented on a change in pull request #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225#discussion_r321090816 ## File path:

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321144138 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321149400 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] jerryshao commented on a change in pull request #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names

2019-09-05 Thread GitBox
jerryshao commented on a change in pull request #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225#discussion_r321090816 ## File path:

[GitHub] [incubator-livy] codecov-io commented on issue #226: [LIVY-659]Fix travis failed on can kill spark-submit while it's running

2019-09-05 Thread GitBox
codecov-io commented on issue #226: [LIVY-659]Fix travis failed on can kill spark-submit while it's running URL: https://github.com/apache/incubator-livy/pull/226#issuecomment-528291564 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/226?src=pr=h1) Report > Merging

[GitHub] [incubator-livy] codecov-io edited a comment on issue #226: [LIVY-659]Fix travis failed on can kill spark-submit while it's running

2019-09-05 Thread GitBox
codecov-io edited a comment on issue #226: [LIVY-659]Fix travis failed on can kill spark-submit while it's running URL: https://github.com/apache/incubator-livy/pull/226#issuecomment-528291564 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/226?src=pr=h1) Report > Merging

[GitHub] [incubator-livy] codecov-io commented on issue #226: [LIVY-659]Fix travis failed on can kill spark-submit while it's running

2019-09-05 Thread GitBox
codecov-io commented on issue #226: [LIVY-659]Fix travis failed on can kill spark-submit while it's running URL: https://github.com/apache/incubator-livy/pull/226#issuecomment-528291563 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/226?src=pr=h1) Report > Merging

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321151966 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] Jassy1994 commented on issue #119: [LIVY-527] added autocompletion api and implementation for ipython

2019-09-05 Thread GitBox
Jassy1994 commented on issue #119: [LIVY-527] added autocompletion api and implementation for ipython URL: https://github.com/apache/incubator-livy/pull/119#issuecomment-528290091 Hello @wangqiaoshi I use jupyter pyspark kernel in livy yarn-cluster mode, and merged this patch in my

[GitHub] [incubator-livy] codecov-io edited a comment on issue #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names

2019-09-05 Thread GitBox
codecov-io edited a comment on issue #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225#issuecomment-528246905 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/225?src=pr=h1) Report >

[GitHub] [incubator-livy] codecov-io commented on issue #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names

2019-09-05 Thread GitBox
codecov-io commented on issue #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225#issuecomment-528246905 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/225?src=pr=h1) Report > Merging

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321127246 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321128060 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321127849 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321128139 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321128758 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321127396 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] jerryshao commented on a change in pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-05 Thread GitBox
jerryshao commented on a change in pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224#discussion_r321100769 ## File path:

[GitHub] [incubator-livy] jerryshao commented on a change in pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-05 Thread GitBox
jerryshao commented on a change in pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224#discussion_r321099292 ## File path:

[GitHub] [incubator-livy] jerryshao commented on a change in pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-05 Thread GitBox
jerryshao commented on a change in pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224#discussion_r321098795 ## File path: rsc/src/main/java/org/apache/livy/rsc/RSCClient.java ##

[GitHub] [incubator-livy] yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-05 Thread GitBox
yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-528250103 The unit test I add demonstrate how NullPointerException happens: a request send to RSCDriver while

[GitHub] [incubator-livy] captainzmc closed pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
captainzmc closed pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-livy] captainzmc opened a new pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
captainzmc opened a new pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209 ## What changes were proposed in this pull request? 1、Added some tests in BinaryThriftServerSuite that ThriftServer is currently missing(The tests

[GitHub] [incubator-livy] runzhiwang commented on a change in pull request #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names

2019-09-05 Thread GitBox
runzhiwang commented on a change in pull request #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225#discussion_r321203537 ## File path: