---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34894/#review87062
---
Ship it!
Ship It!
- Ian Downes
On June 3, 2015, 2:54 p.m., Paul
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments in the
On June 3, 2015, 4:37 p.m., Ben Mahler wrote:
docs/home.md, line 36
https://reviews.apache.org/r/35037/diff/1/?file=977892#file977892line36
Should this be linking to the framework part of the C++ API? For
example: http://mesos.apache.org/api/latest/c++/namespacemesos.html
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
---
(Updated June 8, 2015, 5:48 p.m.)
Review request for Michael Park.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/#review87049
---
Ship it!
Nice comments! Please adjust the comments as I suggested.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/
---
(Updated June 8, 2015, 6:47 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35165/
---
(Updated June 8, 2015, 8:47 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35229/
---
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/#review87074
---
src/tests/mesos.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35207/#review87089
---
Patch looks great!
Reviews applied: [35207]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35207/
---
(Updated June 8, 2015, 8:44 p.m.)
Review request for mesos, Benjamin Hindman
On June 8, 2015, 8:44 p.m., Alexander Rojas wrote:
src/master/detector.cpp, line 452
https://reviews.apache.org/r/35043/diff/1/?file=978200#file978200line452
Can you add a line break here.
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Conditionals
On June 8,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/#review87093
---
Patch looks great!
Reviews applied: [35206]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/
---
(Updated June 8, 2015, 10:58 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/
---
(Updated June 8, 2015, 8:42 p.m.)
Review request for Benjamin Hindman and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/
---
(Updated June 8, 2015, 8:51 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/#review87088
---
src/linux/routing/queueing/htb.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35118/#review87083
---
Ship it!
Ship It!
- Vinod Kone
On June 5, 2015, 9:09 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/
---
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/
---
(Updated June 8, 2015, 4:41 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35234/
---
Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review87099
---
src/master/main.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/#review87100
---
3rdparty/libprocess/include/process/firewall.hpp
On June 5, 2015, 9:58 p.m., Vinod Kone wrote:
src/master/master.cpp, line 3462
https://reviews.apache.org/r/35118/diff/1/?file=980131#file980131line3462
woah. didn't realize this was handled automagically by the install
handler.
Yeah, we didn't do this for framework provided
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35234/#review87118
---
Patch looks great!
Reviews applied: [33752, 35084, 35234]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35239/#review87121
---
Patch looks great!
Reviews applied: [35239]
All tests passed.
-
On June 9, 2015, 12:28 a.m., Cody Maloney wrote:
Partial review, going to review more thoroughly later, just posting so it
doesn't get lost since it was on the old revision
- Cody
---
This is an automatically generated e-mail. To
On June 9, 2015, 12:34 a.m., Jie Yu wrote:
I think the interface of getting resource usage is going to change per
discussion here:
https://issues.apache.org/jira/browse/MESOS-2818
Niklas Nielsen wrote:
The new proposal doesn't mention changing the callback, does it?
The new
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35229/#review87098
---
Patch looks great!
Reviews applied: [35225, 35229]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35164/#review87106
---
I think the interface of getting resource usage is going to change
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/#review87115
---
Patch looks great!
Reviews applied: [35164, 35157]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/#review86739
---
configure.ac
https://reviews.apache.org/r/35084/#comment138798
On June 8, 2015, 10:38 p.m., Niklas Nielsen wrote:
src/tests/oversubscription_tests.cpp, line 256
https://reviews.apache.org/r/35157/diff/3/?file=980318#file980318line256
Why not await ready? Here and below :)
hmm because when we receive status 'running' from task, then we are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35239/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-2776
On June 8, 2015, 5:34 p.m., Jie Yu wrote:
I think the interface of getting resource usage is going to change per
discussion here:
https://issues.apache.org/jira/browse/MESOS-2818
The new proposal doesn't mention changing the callback, does it?
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35120/#review87113
---
docs/mesos-c++-style-guide.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34921/#review87117
---
src/cli/mesos-ps
https://reviews.apache.org/r/34921/#comment139443
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33752/
---
(Updated June 9, 2015, 12:02 a.m.)
Review request for mesos, Cody Maloney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/
---
(Updated June 9, 2015, 12:02 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34258/
---
(Updated June 9, 2015, 12:01 a.m.)
Review request for mesos and Cody Maloney.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35234/#review87101
---
Great updates - quick style review which applies to the
On June 8, 2015, 10:38 p.m., Niklas Nielsen wrote:
src/tests/oversubscription_tests.cpp, line 582
https://reviews.apache.org/r/35157/diff/3/?file=980318#file980318line582
Why copy the offer?
Because we use it several time, however i didn't notice that it wasn't
consistent -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35120/#review87111
---
Ship it!
Ship It!
- Ben Mahler
On June 5, 2015, 9:34 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/
---
(Updated June 9, 2015, 12:17 a.m.)
Review request for mesos, Ben Mahler, Jie
On June 2, 2015, 3:19 p.m., Niklas Nielsen wrote:
Ping @benm :) Do you want this in?
Thanks, I'll land it now. Kept pinging benh to take a look but let's follow up
if he has feedback, since there seems to be consensus around these.
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34921/
---
(Updated 六月 9, 2015, 2:58 a.m.)
Review request for mesos.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33057/#review87009
---
Patch looks great!
Reviews applied: [32850, 33057]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33057/
---
(Updated June 8, 2015, 9:42 a.m.)
Review request for mesos, Adam B and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review87028
---
3rdparty/libprocess/include/process/time.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/
---
(Updated June 8, 2015, 2:11 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review87013
---
Looks pretty good. I just am unsure about the class naming - the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
---
(Updated June 8, 2015, 12:58 p.m.)
Review request for Michael Park.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33730/
---
(Updated June 8, 2015, 2:06 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review87023
---
Patch looks great!
Reviews applied: [33295, 33296]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/
---
(Updated June 8, 2015, 4:22 p.m.)
Review request for mesos and Bernd Mathiske.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/#review87045
---
Ship it!
Ship It!
- Bernd Mathiske
On June 8, 2015, 9:22 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032/#review87041
---
Patch looks great!
Reviews applied: [34703, 30032]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/
---
(Updated June 8, 2015, 4:35 p.m.)
Review request for mesos, Chi Zhang, Ian
58 matches
Mail list logo
