-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/#review86739
-----------------------------------------------------------



configure.ac
<https://reviews.apache.org/r/35084/#comment138798>

    nit: Could you document auto here? Right now it's an implicit magic value 
like 'bundled' in a lot of ways.
    
    I also wonder if it is possible to have this macro set the AC_ARG_WITH / 
AC_ARG_ENABLE, but that definitely isn't necessary / blocker here.



configure.ac
<https://reviews.apache.org/r/35084/#comment138799>

    Since these all follow about the same structure could we add an autoconf 
macro which takes the package name followed by the help description and  does 
the rest automatically?


- Cody Maloney


On June 9, 2015, 12:02 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35084/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2537
>     https://issues.apache.org/jira/browse/MESOS-2537
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
> consistent behavior for bundled packages selected by either
> --enable-bundled-$PACKAGE or --with-$PACKAGE.
> 
> The default policy is set by --enable-bundled and overridden when
> the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
> option. If --with-$PACKAGE is specified as "bundled", the bundled
> version is selected.
> 
> 
> Diffs
> -----
> 
>   configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 
> 
> Diff: https://reviews.apache.org/r/35084/diff/
> 
> 
> Testing
> -------
> 
> Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not 
> exhaustive!) combinations of enabling and disableing bundled packages.
> 
> For example, on CentOS, this alost works:
>   $ onfigure.developer  --disable-bundled --with-zookeeper=bundled 
> --with-gmock=bundled
> 
> To work completely, this change needs to be propagated to libprocess, which I 
> can do once reviewers agree that it's the right behavior.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Reply via email to