Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34976/#review87679 --- Bad patch! Reviews applied: [34976] Failed command:

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34976/ --- (Updated June 12, 2015, 6:23 a.m.) Review request for mesos and Dave Lester.

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34976/#review87686 --- LGTM, but I'd still like to see a Mac user review the Mac

Re: Review Request 35179: MESOS-1733 Variadic Path Join

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/#review87699 --- Looks like Cody already made path::join() variadic in commit

Re: Review Request 34720: Added kill executor correction to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34720/ --- (Updated June 12, 2015, 2:48 p.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34720: Added kill executor correction to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34720/#review87767 --- src/slave/slave.hpp

Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

On April 20, 2015, 5:55 a.m., Adam B wrote: LGTM, barring a question about ordering/synchronization. I'll let another committer take a look before we commit it. Adam B wrote: Would also like to see a successful ReviewBot pass. That MasterFailover segfault seems like it could be

Review Request 35405: Enable deleting MasterDetector in MesosSchedulerDriver::join.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35405/ --- Review request for mesos and Niklas Nielsen. Repository: mesos Description

Re: Review Request 34720: Added kill executor correction to slave.

On June 12, 2015, 6:43 p.m., Jie Yu wrote: src/slave/slave.cpp, lines 4383-4400 https://reviews.apache.org/r/34720/diff/4/?file=983235#file983235line4383 First of all, we don't need to check if 'executor' is NULL or not here. If you looked at the callers, it's guaranteed that

Re: Review Request 14960: implementation of CLI mesos-status

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14960/#review87773 --- Hi Du! I am sorry this ended up being a stale reviewl: If you

Re: Review Request 14460: Add debian directory to create mesos packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14460/#review87772 --- Hi Damien, I am sorry that this ended up being a stale review: do

Re: Review Request 35395: Improvements to Synchronized.

On June 12, 2015, 6:21 p.m., Ben Mahler wrote: Are (1) and (2) independent changes? Any performance implications from (1)? A benchmark for 'synchronized' would be great! Are (1) and (2) independent changes? Yeah, they're more or less independent. Any performance implications from

Re: Review Request 34719: Added QOS_KILLED as status reason

On June 12, 2015, 10 p.m., Jie Yu wrote: include/mesos/mesos.proto, line 875 https://reviews.apache.org/r/34719/diff/4/?file=983929#file983929line875 REASON_EXECUTOR_PREEMPTED ? cc @vinod @bmahler SGTM. - Vinod

Review Request 35404: Fixed http::Request::client to be set correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35404/ --- Review request for mesos and Jie Yu. Bugs: MESOS-2519

Re: Review Request 35164: Added callback to the QoS Controller to retrieve usages from the monitor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35164/ --- (Updated June 12, 2015, 8:39 p.m.) Review request for mesos, Jie Yu, Niklas

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068/#review87743 --- Ship it! Minor style issue, I'll clean it up for you and get this

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/#review87745 --- Ship it! Just some minor style items, I'll clean them up and get

Re: Review Request 35157: Added unit tests for fetching ResourceUsage in both QoS Controller and Resource Estimator .

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/#review87755 --- Ship it! Ship It! - Jie Yu On June 12, 2015, 8:40 p.m., Bartek

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

framework 20150612-182649-1787367596-40122-13591- 18:26:49 DEBUG: I0612 18:26:49.245582 13610 sched.cpp:448] Framework registered with 20150612-182649-1787367596-40122-13591- 18:26:49 DEBUG: I0612 18:26:49.245728 13609 master.cpp:4108] Sending 1 offers to framework 20150612-182649-1787367596

Re: Review Request 35179: MESOS-1733 Variadic Path Join

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/ --- (Updated June 12, 2015, 7:04 p.m.) Review request for mesos, Adam B and Cody

Re: Review Request 35157: Added unit tests for fetching ResourceUsage in both QoS Controller and Resource Estimator .

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/ --- (Updated June 12, 2015, 8:40 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 12, 2015, 3:37 p.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review87784 --- Patch looks great! Reviews applied: [35079, 34631, 34632, 34633,

Re: Review Request 14460: Add debian directory to create mesos packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14460/#review87786 --- Bad patch! Reviews applied: [14460] Failed command:

Re: Review Request 14309: Properly get gethostbyname2_r error on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14309/#review87791 --- Bad patch! Reviews applied: [14309] Failed command:

Re: Review Request 35404: Fixed http::Request::client to be set correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35404/#review87795 --- Patch looks great! Reviews applied: [35403, 35404] All tests

Review Request 35411: Send oversubscribable resources during (re-)registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35411/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-2866

Review Request 35410: Minor cleanups to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35410/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 35404: Fixed http::Request::client to be set correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35404/#review87781 --- Ship it! Have you tested this?

Re: Review Request 35403: Added the ability to get the peer address of a connected or accepted Socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35403/#review87780 --- 3rdparty/libprocess/src/socket.cpp

Re: Review Request 35405: Enable deleting MasterDetector in MesosSchedulerDriver::join.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35405/ --- (Updated June 12, 2015, 11:08 p.m.) Review request for mesos and Niklas

Re: Review Request 35403: Added the ability to get the peer address of a connected or accepted Socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35403/#review87779 --- Maybe add @joris to this review? - Niklas Nielsen On June 12,

Re: Review Request 14960: implementation of CLI mesos-status

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14960/#review87790 --- Patch looks great! Reviews applied: [14960] All tests passed. -

Re: Review Request 35179: MESOS-1733 Variadic Path Join

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/ --- (Updated June 12, 2015, 5:17 p.m.) Review request for mesos, Adam B and Cody

Re: Review Request 35179: MESOS-1733 Variadic Path Join

On June 12, 2015, 11:15 a.m., Adam B wrote: Looks like Cody already made path::join() variadic in commit b08fccf8f5ea325b8c38055b5f2c03509744dd9b Switched path::join() to be variadic. How is your patch an improvement? What problem is it solving? Please remove the Might have some

Review Request 35395: Improvements to Synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35395/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere.

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 12, 2015, 6:06 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87735 --- Are the changes to process.cpp, libevent.{hpp|cpp} independent?

Re: Review Request 29406: Introduce libevent ssl socket.

On June 12, 2015, 6:17 p.m., Ben Mahler wrote: Are the changes to process.cpp, libevent.{hpp|cpp} independent? Hard to tell if these are related to SSL, can you pull them out into separate reviews? Ben: I've been reviewing this closely with Joris and asked him to keep these in the

Re: Review Request 29406: Introduce libevent ssl socket.

On June 12, 2015, 6:17 p.m., Ben Mahler wrote: Are the changes to process.cpp, libevent.{hpp|cpp} independent? Hard to tell if these are related to SSL, can you pull them out into separate reviews? Benjamin Hindman wrote: Ben: I've been reviewing this closely with Joris and

Re: Review Request 35395: Improvements to Synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35395/#review87737 --- Are (1) and (2) independent changes? Any performance implications

Re: Review Request 35395: Improvements to Synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35395/ --- (Updated June 12, 2015, 6:24 p.m.) Review request for mesos, Benjamin Hindman