Re: Review Request 43893: Made sure that spawned processes terminated before leaving test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43893/#review120466 --- Ship it! Ship It! - Adam B On Feb. 23, 2016, 11:50 a.m., Ben

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 24, 2016, 2:50 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 286 > > > > > > some comments here For variables which such narrow usage I would prefer to give them a speaking

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On Feb. 24, 2016, 1:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > > > > > The allocatd may keeps changing due the resource offer and resource > > recovery, I think

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 24, 2016, 9:46 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 24, 2016, 9:46 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On 二月 24, 2016, 12:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > > > > > The allocatd may keeps changing due the resource offer and resource > > recovery, I think t

Review Request 43937: Added missing `json` declaration for `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43937/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Bugs: MESO

Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43850/ --- (Updated Feb. 24, 2016, 1:10 a.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120473 --- src/master/allocator/mesos/hierarchical.cpp (line 1156)

Review Request 43939: Required jsonifying of generic protobuf to be explicit opt-in [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43939/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Bugs: MESO

Review Request 43938: Required jsonifying of generic protobuf to be explicit opt-in [stout].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43938/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Bugs: MESO

Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43850/#review120475 --- Ship it! src/tests/containerizer/memory_pressure_tests.cpp (li

Re: Review Request 43938: Required jsonifying of generic protobuf to be explicit opt-in [stout].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43938/#review120476 --- 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (line

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 24, 2016, 1:53 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2369-2370 > > > > > > What about following format? > > > > allocator->setQuota( > > framework1

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On Feb. 24, 2016, 1:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > > > > > The allocatd may keeps changing due the resource offer and resource > > recovery, I think

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 24, 2016, 10:18 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43884: Added allocator metrics for satisfied quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 24, 2016, 10:20 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On 二月 24, 2016, 12:53 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2369-2370 > > > > > > What about following format? > > > > allocator->setQuota( > > framework1.

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On 二月 24, 2016, 12:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > > > > > The allocatd may keeps changing due the resource offer and resource > > recovery, I think t

Re: Review Request 43864: Fix typo of roles doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/#review120480 --- Patch looks great! Reviews applied: [43864] Passed command: expo

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On 二月 24, 2016, 1:50 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 286 > > > > > > some comments here > > Benjamin Bannier wrote: > For variables which such narrow usage I woul

Re: Review Request 43884: Added allocator metrics for satisfied quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 24, 2016, 11:21 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 24, 2016, 11:22 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43883: Added allocator metrics for number of filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated Feb. 24, 2016, 11:21 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 24, 2016, 11:23 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 24, 2016, 11:22 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 24, 2016, 11:22 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 24, 2016, 1:53 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1354 > > > > > > The counter may count twice for some cases, one framework may get > > resource allocation in

Re: Review Request 43939: Required jsonifying of generic protobuf to be explicit opt-in [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43939/ --- (Updated Feb. 24, 2016, 10:32 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43939: Required jsonifying of generic protobuf to be explicit opt-in [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43939/ --- (Updated Feb. 24, 2016, 10:32 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43939: Required jsonifying of generic protobuf to be explicit opt-in [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43939/#review120485 --- Patch looks great! Reviews applied: [43937, 43938, 43939] Passed

Re: Review Request 43884: Added allocator metrics for satisfied quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 24, 2016, 11:47 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 24, 2016, 11:49 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 24, 2016, 11:49 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43883: Added allocator metrics for number of filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated Feb. 24, 2016, 11:53 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 24, 2016, 11:53 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 24, 2016, 11:58 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On Feb. 24, 2016, 1:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > > > > > The allocatd may keeps changing due the resource offer and resource > > recovery, I think

Re: Review Request 43884: Added allocator metrics for satisfied quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review120489 --- Patch looks great! Reviews applied: [43879, 43880, 43881, 43882,

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On 二月 24, 2016, 12:53 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1354 > > > > > > The counter may count twice for some cases, one framework may get > > resource allocation in b

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120492 --- src/master/allocator/mesos/hierarchical.hpp (lines 25 - 26)

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 24, 2016, 2:25 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43884: Added allocator metrics for satisfied quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review120496 --- src/master/allocator/mesos/hierarchical.cpp (lines 1077 - 1080) <

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On 二月 24, 2016, 1:06 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2398 > > > > > > I saw that most are using `Seconds(15)` Can you please clarify why using `Seconds{15}` but not `

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 24, 2016, 2:06 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2398 > > > > > > I saw that most are using `Seconds(15)` > > Guangya Liu wrote: > Can you please clarify wh

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 24, 2016, 2:06 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2398 > > > > > > I saw that most are using `Seconds(15)` > > Guangya Liu wrote: > Can you please clarify wh

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 24, 2016, 2:49 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43884: Added allocator metrics for satisfied quotas.

> On Feb. 24, 2016, 2:26 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1077-1080 > > > > > > I think that we cannot say that the quota here is satisfied, but those > > are just quo

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated Feb. 24, 2016, 2:05 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/macros/External.cmake, line 38 > > > > > > And why we need change `EXTERNAL` macro here? I prososal add a version > > to our leveldb.

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/macros/External.cmake, line 38 > > > > > > And why we need change `EXTERNAL` macro here? I prososal add a version > > to our leveldb.

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/ --- (Updated Feb. 24, 2016, 2:10 p.m.) Review request for mesos, Guangya Liu, haosd

Re: Review Request 43884: Added allocator metrics for used quotas.

> On 二月 24, 2016, 1:26 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1077-1080 > > > > > > I think that we cannot say that the quota here is satisfied, but those > > are just quota

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review120506 --- Patch looks great! Reviews applied: [43879, 43880, 43881, 43882,

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120507 --- src/tests/hierarchical_allocator_tests.cpp (line 2385)

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review120510 --- Bad patch! Reviews applied: [43889] Failed command: ./support/ap

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review120511 --- src/master/allocator/mesos/hierarchical.cpp (line 416)

Re: Review Request 43328: Title for documentation webpages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/ --- (Updated Feb. 24, 2016, 4:33 p.m.) Review request for mesos, Kevin Klues and Ne

Re: Review Request 43328: Added a title to all documentation markdown files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/ --- (Updated Feb. 24, 2016, 4:36 p.m.) Review request for mesos, Kevin Klues and Ne

Review Request 43932: Added overlayfs provisioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/ --- Review request for mesos and Jie Yu. Bugs: MESOS-2971 https://issues.apache

Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43914/ --- (Updated Feb. 24, 2016, 4:44 p.m.) Review request for mesos and Jie Yu. Summa

Re: Review Request 42390: Fixed fetching uris when slave is running inside a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42390/#review120516 --- Ship it! Ship It! - Timothy Chen On Jan. 20, 2016, 2:12 p.m.

Re: Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43915/ --- (Updated Feb. 24, 2016, 4:45 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43916/ --- (Updated Feb. 24, 2016, 4:54 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review120525 --- Patch looks great! Reviews applied: [43032] Passed command: expo

Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43850/#review120526 --- src/tests/containerizer/memory_pressure_tests.cpp (lines 158 - 16

Re: Review Request 43328: Added a title to all documentation markdown files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review120528 --- Ship it! Ship It! - Kevin Klues On Feb. 24, 2016, 4:36 p.m.,

Re: Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/ --- (Updated Feb. 24, 2016, 6:30 p.m.) Review request for mesos, Kevin Klues and Ne

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/ --- (Updated Feb. 24, 2016, 6:39 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43864: Fix typo of roles doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/#review120531 --- Ship it! Ship It! - Neil Conway On Feb. 24, 2016, 3:34 a.m.,

Re: Review Request 43777: Removed unnecessary parameter from validation function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43777/ --- (Updated Feb. 24, 2016, 6:41 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43328: Added a title to all documentation markdown files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/ --- (Updated Feb. 24, 2016, 6:41 p.m.) Review request for mesos, Kevin Klues and Ne

Re: Review Request 43778: Added '/create-volumes' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43778/ --- (Updated Feb. 24, 2016, 6:42 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/ --- (Updated Feb. 24, 2016, 6:42 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43328: Added a title to all documentation markdown files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/ --- (Updated Feb. 24, 2016, 6:42 p.m.) Review request for mesos, Kevin Klues and Ne

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/ --- (Updated Feb. 24, 2016, 6:43 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/ --- (Updated Feb. 24, 2016, 6:42 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43715: Title for endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 24, 2016, 6:44 p.m.) Review request for mesos, Kevin Klues and Ne

Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title in generated markdown files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 24, 2016, 6:49 p.m.) Review request for mesos, Kevin Klues and Ne

Review Request 43958: Added a verbose logging in docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43958/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Reposi

Review Request 43959: Fixed the docker registry puller to properly handle duplicated blobsums.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43959/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Reposi

Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title in generated markdown files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/#review120536 --- Ship it! Ship It! - Kevin Klues On Feb. 24, 2016, 6:49 p.m.,

Review Request 43960: Added an end-to-end test for docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43960/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Reposi

Re: Review Request 43716: Added title to every endpoint markdown file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/ --- (Updated Feb. 24, 2016, 6:51 p.m.) Review request for mesos, Ben Mahler, Kevin

Re: Review Request 43716: Added title to every endpoint markdown file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review120538 --- Ship it! Ship It! - Kevin Klues On Feb. 24, 2016, 6:51 p.m.,

Re: Review Request 43932: Added overlayfs provisioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/#review120540 --- Patch looks great! Reviews applied: [43718, 43932] Passed comman

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/ --- (Updated Feb. 24, 2016, 7:19 p.m.) Review request for mesos, Ben Mahler, Ian Do

Re: Review Request 43462: Used list::splice() for clock::tick().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43462/ --- (Updated Feb. 24, 2016, 7:20 p.m.) Review request for mesos, Ben Mahler, Ian Do

Re: Review Request 43958: Added a verbose logging in docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43958/#review120548 --- Ship it! The size should be appropriate for VLOG(1). - Gilbert

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/ --- (Updated Feb. 24, 2016, 7:23 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

> On Feb. 24, 2016, 5:16 a.m., Kevin Klues wrote: > > support/push-reviews.py, lines 123-125 > > > > > > Ah, I see it now. There is another call to `if not options['dry_run']` > > inside the `close_reviews()` call w

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 24, 2016, 4:21 p.m., Klaus Ma wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2385 > > > > > > Why a anonymous namespace? `static` should be fine. In C `static` has more usages than just denot

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On Feb. 24, 2016, 5:09 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 428 > > > > > > Not yours, but I think we need to update roleSorter when slave > > active/deactive. > > > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 24, 2016, 8:24 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 24, 2016, 8:25 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43462: Used list::splice() for clock::tick().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43462/#review120551 --- Ship it! Ship It! - Vinod Kone On Feb. 24, 2016, 7:20 p.m.,

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/#review120550 --- Thanks for the cleanup! 3rdparty/libprocess/include/process/futu

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/#review120552 --- Ship it! LGTM. Though I'm not sure why we used iterators instea

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

> On Feb. 24, 2016, 7:29 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 791 > > > > > > * Mesos currently uses `foreach` from stout rather than > > range-based`for`. > > * Mes

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

> On Feb. 24, 2016, 7:30 p.m., Vinod Kone wrote: > > LGTM. Though I'm not sure why we used iterators instead of foreach in the > > first place. cc @mcypark Because it was written before `foreach` was introduced to stout. The last of the `for` loops here was authored 2011-10-31 and `foreach` wa

  1   2   >