Re: Review Request 45375: Implemented cleanup() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/ --- (Updated 四月 2, 2016, 7:13 a.m.) Review request for mesos, Gilbert Song and Jie

Review Request 45616: Renamed 'NetworkInfo' to 'ContainerNetwork'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45616/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs: ME

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 2, 2016, 6:32 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 93-95 > > > > > > This is very confusing. We have both 'network' and 'networkInfo' in > > 'NetworkIn

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/ --- (Updated April 2, 2016, 8:07 a.m.) Review request for mesos, Adam B, Ben Mahler

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap`.

> On March 21, 2016, 6:07 p.m., Kevin Klues wrote: > > Ship It! Thank you very much for your review. @adam-mesos, @bmahler, may I have your reviews? Thank you in advance. - haosdent --- This is an automatically generated e-mail. To rep

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/ --- (Updated April 2, 2016, 10:31 a.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

> On March 31, 2016, 7:14 p.m., Jie Yu wrote: > > src/slave/slave.hpp, line 550 > > > > > > Can you move this field to Http class because this is a limiter for the > > http endpoint. Also, `limiter` sounds too gener

Re: Review Request 45377: Updated prepare() logic for unified container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 2, 2016, 1:46 p.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126690 --- src/cli/execute.cpp (line 283)

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On April 2, 2016, 2:38 p.m., haosdent huang wrote: > > By the way, use comma "," as delimiter looks a bit wired. Usually we use space or tab " ", right? - haosdent --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 四月 2, 2016, 3:01 p.m.) Review request for mesos, Gilbert Song and Jie

Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Descript

Re: Review Request 44837: Added force_pull_image to Image protobuf.

> On 三月 15, 2016, 4:42 p.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 1501 > > > > > > s/force_pull_image/no_cache/ > > > > IMO, force pull is a mean, not a description. Please adjust the > > comm

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126696 --- Ship it! Ship It! - Jie Yu On April 2, 2016, 3:18 a.m., Qian

Re: Review Request 45616: Renamed 'NetworkInfo' to 'ContainerNetwork'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45616/#review126697 --- Ship it! Ship It! - Jie Yu On April 2, 2016, 7:44 a.m., Qian

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126698 --- Qian, I followed up with a patch here. Please review it: https://r

Review Request 45620: Adjusted the status semantics in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Bugs: MESOS-4764

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/#review126699 --- Fix it, then Ship it! Ship It! src/slave/containerizer/mesos/

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/ --- (Updated April 2, 2016, 1:20 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 45621: Added tests for docker spec helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45621/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs: ME

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126700 --- src/docker/spec.cpp (lines 103 - 105)

Review Request 45622: Fixed Nvidia GPU isolator build for gcc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45622/ --- Review request for mesos, Ben Mahler and switched to 'mcypark'. Bugs: MESOS-508

Re: Review Request 45533: Explicitly typed quota role sorter in Mesos allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45533/#review126703 --- src/master/allocator/mesos/hierarchical.hpp (line 479)

Re: Review Request 45533: Explicitly typed quota role sorter in Mesos allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45533/#review126704 --- It seems you are linking to a wrong bug, should be MESOS-5073 ? -

Re: Review Request 45621: Added tests for docker spec helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45621/#review126705 --- src/tests/containerizer/docker_spec_tests.cpp (line 158)

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/#review126713 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line