Re: Review Request 45214: Updated protobuf to support external storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/#review126791 --- Ditto to the v1. Thanks, Guangya! include/mesos/mesos.proto

Re: Review Request 45310: Removed unnecessary constructors in `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45310/#review126796 --- Ship it! Ship It! - Daniel Pravat On March 24, 2016, 8:22

Re: Review Request 45311: Added an additional template parameter to 'Try' for typeful error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45311/#review126797 --- Ship it! Ship It! - Daniel Pravat On March 24, 2016, 8:23

Re: Review Request 45313: Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45313/#review126798 --- Ship it! Ship It! - Daniel Pravat On March 28, 2016, 8:57

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review126799 --- Ship it! Ship It! - Daniel Pravat On April 3, 2016, 9:34

Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- Review request for mesos, Alex Clemmer and Vinod Kone. Repository: mesos

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Abr. 4, 2016, 6:54 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 8:08 a.m., Anand Mazumdar wrote: > > include/mesos/v1/mesos.proto, lines 1796-1813 > > > > > > hmmm .. Did you test if the health check workflow works? > > > > IIUC, the

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 12:08 a.m., Anand Mazumdar wrote: > > include/mesos/v1/mesos.proto, lines 1796-1813 > > > > > > hmmm .. Did you test if the health check workflow works? > > > > IIUC, the

Review Request 45670: Added tests for HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3558

Re: Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/ --- (Updated April 4, 2016, 7:40 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45377: Updated prepare() logic for unified container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 4, 2016, 9:28 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/ --- (Updated April 4, 2016, 5:11 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45623: Renamed the parameter 'override' to '_override'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45623/#review126809 --- Patch looks great! Reviews applied: [45623] Passed command:

Re: Review Request 44454: Checkpointed the external mount info for container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/ --- (Updated 四月 4, 2016, 9:58 a.m.) Review request for mesos, Gilbert Song and Jie

Review Request 45671: Updated checkpoint external mount info in cleanup().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45671/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5104

Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated April 4, 2016, 7:26 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45670: Added tests for HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review126814 --- Patch looks great! Reviews applied: [44423, 44424, 44427, 45670]

Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5104

Re: Review Request 45370: Implemented prepare() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 4, 2016, 9:21 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated April 4, 2016, 7:33 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 10:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

> On Abr. 4, 2016, 12:32 p.m., Joerg Schad wrote: > > support/docker_build.sh, line 19 > > > > > > What is the reason for this change? Was it a bug before? (Feel free to > > drop if there is a good reason, it just

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 113 > > > > > > Nit-pick: We do not have a Python style, but e.g., the Google Python > > style guide would set `if` right

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- (Updated April 4, 2016, 2:34 p.m.) Review request for mesos, Alexander

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- (Updated April 4, 2016, 2:35 p.m.) Review request for mesos, Alexander

Re: Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/#review126825 --- Patch looks great! Reviews applied: [45527, 45528] Passed

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review126819 --- support/docker_build.sh (line 1)

Re: Review Request 45534: Added per-role and quota share metrics to the DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45534/ --- (Updated April 4, 2016, 2:32 p.m.) Review request for mesos, Alexander

Re: Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/#review126821 --- Patch looks great! Reviews applied: [45214, 45217, 45265, 45270,

Re: Review Request 44571: Added timeout for destroying Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44571/ --- (Updated April 4, 2016, 4:05 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 4, 2016, 2:31 p.m.) Review request for mesos, Alexander

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45717/#review127020 --- Patch looks great! Reviews applied: [45717] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 311-320 > > > > > > Conceptutally, `Try` is not something we pass around like this. A > > function

Re: Review Request 45707: Minor cleanups to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/#review127005 --- Patch looks great! Reviews applied: [45707] Passed command:

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/#review127023 --- Can you also add a test case for the empty string case? e.g.,

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review127027 --- src/slave/containerizer/fetcher.cpp (line 150)

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/#review126992 --- Patch looks great! Reviews applied: [45620] Passed command:

Re: Review Request 45707: Minor cleanups to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/#review127009 --- Ship it! Ship It! - Klaus Ma On April 5, 2016, 5:32 a.m.,

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 350-364 > > > > > > We should be able to just use the ones in `src/tests/mesos.hpp`. I'd like to

Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5114

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45717/#review126991 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 45217: Implemented docker volume driver isolator interface.

> On 四月 4, 2016, 11:01 p.m., Gilbert Song wrote: > > src/Makefile.am, line 860 > > > > > > Could you move it below runtime.cpp? There are some files such as spec.proto, dvd_client.cpp, dvd_client.hpp, dvd.cpp,

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, line 308 > > > > > > `static const Resources TASK_RESOURCES;` If we mark it `const`, we have to move the

Review Request 45731: Introduced '--networks' flag to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5117

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/#review127021 --- Ship it! Ship It! - Jie Yu On April 5, 2016, 2:57 a.m.,

Re: Review Request 45726: Fixed a bug in the `flags::parse` function and added a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/#review127032 --- Patch looks great! Reviews applied: [45726] Passed command:

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated April 4, 2016, 4:48 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

> On April 3, 2016, 2:22 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 825-826 > > > > > > I think that here should be `||` but not `&&` > > haosdent huang wrote: > Actually these code

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- (Updated April 4, 2016, 5:17 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45362/ --- (Updated April 4, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44947: Add tests for XFS project quota utilities.

> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/xfs_quota_tests.cpp, lines 292-294 > > > > > > Instead of doing cleanups here, we can register the projectIds with a > > member

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/#review126862 --- CHANGELOG (line 49)

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated April 4, 2016, 5:26 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated April 4, 2016, 5:27 p.m.) Review request for mesos, Jie Yu and Jiang

Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45690/ --- Review request for mesos, Ian Downes and Cong Wang. Bugs: MESOS-4662

Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/ --- Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.

Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/#review126871 --- Ship it! You don't have to pass the real path to all the

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/ --- (Updated April 4, 2016, 4:47 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

> On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 426-429 > > > > > > What about using reference here? > > > > const ExecutorInfo& executorInfo =

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44670: Added master_detector and master_contender flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 45083: Added a any mechanism for futures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/ --- (Updated April 4, 2016, 5:12 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45084/ --- (Updated April 4, 2016, 5:12 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45350/ --- (Updated April 4, 2016, 5:14 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45085: Add cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated April 4, 2016, 5:15 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 4, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45364/ --- (Updated April 4, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 4, 2016, 5:28 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 4, 2016, 5:27 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated April 4, 2016, 5:27 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated April 4, 2016, 5:28 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review126866 --- src/tests/cluster.cpp (line 437)

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 5:35 p.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45534: Added per-role and quota share metrics to the DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45534/#review126835 --- Patch looks great! Reviews applied: [45529, 45533, 45534]

Re: Review Request 44670: Added master_detector and master_contender flags.

> On March 31, 2016, 5:26 p.m., Kapil Arya wrote: > > src/master/main.cpp, lines 247-248 > > > > > > These two should fit on one line :-). putting them on the same line is causing the line lenght to increase to 89.

Re: Review Request 44571: Added timeout for destroying Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44571/#review126848 --- Patch looks great! Reviews applied: [44571] Passed command:

Re: Review Request 44546: Moved functions in promises to a common header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44545: Separated standalone and zookeeper classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45350/#review126858 --- src/slave/flags.cpp (line 335)

Re: Review Request 45353: Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45353/ --- (Updated April 4, 2016, 5:19 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45354: Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45354/ --- (Updated April 4, 2016, 5:19 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/ --- (Updated April 4, 2016, 5:29 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` +1 this is

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review126867 --- Not insisting on addressing it here but just would like to

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126877 --- Patch looks great! Reviews applied: [45033, 45659, 45660]

Re: Review Request 44547: Added functions in promises to the future header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 45351: Migrate test cases for `cpu` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45351/ --- (Updated April 4, 2016, 5:18 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45352/ --- (Updated April 4, 2016, 5:19 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45473: Migrate test cases for `net_cls` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45473/ --- (Updated April 4, 2016, 5:22 p.m.) Review request for mesos, Avinash

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 4, 2016, 3:21 p.m.) Review request for mesos, Alexander

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- (Updated April 4, 2016, 3:22 p.m.) Review request for mesos, Alexander

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126838 --- Ship it! Ship It! - Jie Yu On April 2, 2016, 8:20 p.m.,

  1   2   >