Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 8:08 a.m., Anand Mazumdar wrote: > > include/mesos/v1/mesos.proto, lines 1796-1813 > > > > > > hmmm .. Did you test if the health check workflow works? > > > > IIUC, the `mesos-health-ch

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 12:08 a.m., Anand Mazumdar wrote: > > include/mesos/v1/mesos.proto, lines 1796-1813 > > > > > > hmmm .. Did you test if the health check workflow works? > > > > IIUC, the `mesos-health-c

Re: Review Request 45623: Renamed the parameter 'override' to '_override'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45623/#review126802 --- Ship it! Ship It! - Anand Mazumdar On April 3, 2016, 8:30 a.

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review126804 --- Patch looks great! Reviews applied: [45668] Passed command: expo

Re: Review Request 45214: Updated protobuf to support external storage.

> On 四月 4, 2016, 6:05 a.m., Gilbert Song wrote: > > include/mesos/mesos.proto, line 1576 > > > > > > Let's make it 0.30. OK, I will reflect this in `message Source` section. - Guangya --

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126806 --- Fix it, then Ship it! support/mesos-style.py (line 113)

Re: Review Request 45214: Updated protobuf to support external storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/ --- (Updated 四月 4, 2016, 8:39 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45373/ --- (Updated 四月 4, 2016, 8:49 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On March 8, 2016, 8:08 a.m., Anand Mazumdar wrote: > > include/mesos/v1/mesos.proto, lines 1796-1813 > > > > > > hmmm .. Did you test if the health check workflow works? > > > > IIUC, the `mesos-health-ch

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/ --- (Updated April 4, 2016, 5:11 p.m.) Review request for mesos, Anand Mazumdar and

Review Request 45670: Added tests for HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3558 h

Re: Review Request 45370: Implemented prepare() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 4, 2016, 9:21 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45377: Updated prepare() logic for unified container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 4, 2016, 9:28 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45623: Renamed the parameter 'override' to '_override'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45623/#review126809 --- Patch looks great! Reviews applied: [45623] Passed command: expo

Re: Review Request 44454: Checkpointed the external mount info for container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/ --- (Updated 四月 4, 2016, 9:58 a.m.) Review request for mesos, Gilbert Song and Jie

Review Request 45671: Updated checkpoint external mount info in cleanup().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45671/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5104 https:/

Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5104 https:/

Re: Review Request 45670: Added tests for HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review126814 --- Patch looks great! Reviews applied: [44423, 44424, 44427, 45670]

Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated April 4, 2016, 7:26 p.m.) Review request for mesos, Greg Mann and Vino

Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated April 4, 2016, 7:33 p.m.) Review request for mesos, Greg Mann and Vino

Re: Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/ --- (Updated April 4, 2016, 7:40 p.m.) Review request for mesos, Greg Mann and Vino

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review126819 --- support/docker_build.sh (line 1)

Re: Review Request 45534: Added per-role and quota share metrics to the DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45534/ --- (Updated April 4, 2016, 2:32 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/#review126821 --- Patch looks great! Reviews applied: [45214, 45217, 45265, 45270,

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

> On Abr. 4, 2016, 12:32 p.m., Joerg Schad wrote: > > support/docker_build.sh, line 19 > > > > > > What is the reason for this change? Was it a bug before? (Feel free to > > drop if there is a good reason, it just se

Re: Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/#review126825 --- Patch looks great! Reviews applied: [45527, 45528] Passed comman

Re: Review Request 44571: Added timeout for destroying Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44571/ --- (Updated April 4, 2016, 4:05 p.m.) Review request for mesos, Jie Yu and Joris V

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 4, 2016, 2:31 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 113 > > > > > > Nit-pick: We do not have a Python style, but e.g., the Google Python > > style guide would set `if` right below

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- (Updated April 4, 2016, 2:34 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- (Updated April 4, 2016, 2:35 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 10:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 4, 2016, 3:21 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- (Updated April 4, 2016, 3:22 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).

> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 120 > > > > > > It would be great if we could `+ 1` the `chars` here like we already > > do for the `line_number` in order to

Re: Review Request 45534: Added per-role and quota share metrics to the DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45534/#review126835 --- Patch looks great! Reviews applied: [45529, 45533, 45534] Passed

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- (Updated April 4, 2016, 3:22 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126838 --- Ship it! Ship It! - Jie Yu On April 2, 2016, 8:20 p.m., Gilb

Re: Review Request 45621: Added tests for docker spec helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45621/#review126839 --- Fix it, then Ship it! src/tests/containerizer/docker_spec_test

Re: Review Request 44670: Added master_detector and master_contender flags.

> On March 31, 2016, 5:26 p.m., Kapil Arya wrote: > > src/master/main.cpp, lines 247-248 > > > > > > These two should fit on one line :-). putting them on the same line is causing the line lenght to increase to 89.

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated April 4, 2016, 4:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

> On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, lines 180-182 > > > > > > one line > > haosdent huang wrote: > The remain spaces is not allowed to one line

Re: Review Request 44571: Added timeout for destroying Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44571/#review126848 --- Patch looks great! Reviews applied: [44571] Passed command: expo

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/ --- (Updated April 4, 2016, 4:47 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

> On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 426-429 > > > > > > What about using reference here? > > > > const ExecutorInfo& executorInfo = re

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated April 4, 2016, 4:48 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

> On April 3, 2016, 2:22 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 825-826 > > > > > > I think that here should be `||` but not `&&` > > haosdent huang wrote: > Actually these code e

Re: Review Request 44670: Added master_detector and master_contender flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 44546: Moved functions in promises to a common header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 44545: Separated standalone and zookeeper classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 44547: Added functions in promises to the future header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45084/ --- (Updated April 4, 2016, 5:12 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45083: Added a any mechanism for futures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/ --- (Updated April 4, 2016, 5:12 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45350/ --- (Updated April 4, 2016, 5:14 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45085: Add cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated April 4, 2016, 5:15 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45350/#review126858 --- src/slave/flags.cpp (line 335)

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- (Updated April 4, 2016, 5:17 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45351: Migrate test cases for `cpu` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45351/ --- (Updated April 4, 2016, 5:18 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45352/ --- (Updated April 4, 2016, 5:19 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45354: Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45354/ --- (Updated April 4, 2016, 5:19 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45353: Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45353/ --- (Updated April 4, 2016, 5:19 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45362/ --- (Updated April 4, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 4, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45364/ --- (Updated April 4, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45473: Migrate test cases for `net_cls` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45473/ --- (Updated April 4, 2016, 5:22 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 43284: Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- (Updated April 4, 2016, 5:23 p.m.) Review request for mesos, Ian Downes, Jan Sc

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45472/ --- (Updated April 4, 2016, 5:22 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/ --- (Updated April 4, 2016, 5:23 p.m.) Review request for mesos, Ian Downes, Jan Sc

Re: Review Request 45573: Add PerfEventHandleManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated April 4, 2016, 5:23 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45575/ --- (Updated April 4, 2016, 5:23 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 4, 2016, 5:23 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45087/ --- (Updated April 4, 2016, 5:18 p.m.) Review request for mesos, Gilbert Song, Guan

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/#review126862 --- CHANGELOG (line 49)

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated April 4, 2016, 5:26 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated April 4, 2016, 5:27 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 44947: Add tests for XFS project quota utilities.

> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/xfs_quota_tests.cpp, lines 292-294 > > > > > > Instead of doing cleanups here, we can register the projectIds with a > > member variabl

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 4, 2016, 5:27 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated April 4, 2016, 5:27 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated April 4, 2016, 5:28 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 4, 2016, 5:28 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/ --- (Updated April 4, 2016, 5:29 p.m.) Review request for mesos, Ian Downes and Con

Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45690/ --- Review request for mesos, Ian Downes and Cong Wang. Bugs: MESOS-4662 https:

Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/ --- Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu. Re

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review126866 --- src/tests/cluster.cpp (line 437)

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review126867 --- Not insisting on addressing it here but just would like to mention

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` +1 this is b

Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/#review126871 --- Ship it! You don't have to pass the real path to all the places

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 5:35 p.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang Yan

Re: Review Request 45689: Make Cluster::Slave more tolerant of start failures.

> On April 4, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/cluster.cpp, line 437 > > > > > > how about > > > > ``` > > if (!containerizer) { > > return; > > } > > ``` > > Jiang Ya

Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126877 --- Patch looks great! Reviews applied: [45033, 45659, 45660] Passed

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126880 --- src/cli/execute.cpp (line 284)

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

> On March 31, 2016, 7:14 p.m., Jie Yu wrote: > > src/slave/slave.hpp, line 550 > > > > > > Can you move this field to Http class because this is a limiter for the > > http endpoint. Also, `limiter` sounds too gener

  1   2   >