Re: Review Request 44370: Fixed incorrect http authenticator module type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44370/#review131794 --- Ship it! Ship It! - Adam B On March 3, 2016, 4:14 p.m., Till

Re: Review Request 46609: Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46609/ --- (Updated May 5, 2016, 3:39 p.m.) Review request for mesos, Anand Mazumdar and V

Re: Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46969/#review131795 --- Good start, but I have some basic questions. include/mesos/autho

Re: Review Request 46966: Form controls must have associated labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46966/#review131798 --- Patch looks great! Reviews applied: [46966] Passed command: expo

Re: Review Request 44425: Removed "__linux__" marco and "using namespace" in system isolator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44425/ --- (Updated 五月 5, 2016, 9:21 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 41439: Removed unused variables from filesystem isolator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41439/ --- (Updated 五月 5, 2016, 9:25 a.m.) Review request for mesos, Gilbert Song, Jie Yu,

Re: Review Request 41439: Removed unused variables from filesystem isolator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41439/ --- (Updated 五月 5, 2016, 9:28 a.m.) Review request for mesos, Gilbert Song, Jie Yu,

Re: Review Request 44390: Updated indent when creating MockScheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44390/ --- (Updated 五月 5, 2016, 9:28 a.m.) Review request for mesos, Gilbert Song and Jie

Review Request 44160: Replaced ".get().xxx" with "->xxx".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44160/ --- Review request for mesos, Gilbert Song and Jie Yu. Summary (updated) --

Review Request 42290: Removed "__linux__" marco from runtime isolator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42290/ --- Review request for mesos, Gilbert Song and Jie Yu. Summary (updated) --

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

> On 五月 4, 2016, 10:56 p.m., Guangya Liu wrote: > > Thanks Yu Jie, I saw that > > https://github.com/apache/mesos/blob/master/src/tests/containerizer/filesystem_isolator_tests.cpp > > also have some issues you listed, will try to make a cleanp after the test > > case done. I filed a JIRA http

Re: Review Request 46964: Using the summary attribute of the table element.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46964/#review131808 --- Patch looks great! Reviews applied: [46964] Passed command: expo

Review Request 47008: Corrected formatting in framework development guide doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47008/ --- Review request for mesos. Repository: mesos Description --- This change

Re: Review Request 47008: Corrected formatting in framework development guide doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47008/ --- (Updated May 5, 2016, 12:19 p.m.) Review request for mesos and Joerg Schad. R

Re: Review Request 47008: Corrected formatting in framework development guide doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47008/#review131814 --- Ship it! docs/app-framework-development-guide.md (line 10)

Re: Review Request 47008: Corrected formatting in framework development guide doc.

> On May 5, 2016, 12:26 p.m., Joerg Schad wrote: > > docs/app-framework-development-guide.md, line 10 > > > > > > I am not sure we have an official 80 char limit, it is ok for me to > > change it to make it more read

Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46883/ --- (Updated May 5, 2016, 1:38 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.

> On May 4, 2016, 3:24 a.m., Kapil Arya wrote: > > src/common/http.cpp, line 599 > > > > > > Does non-existing `subject` mean "ANY"? Yep, that's correct. In the local authorizer code (src/authorizer/local/authorize

Re: Review Request 46880: Added authorization to '/logging/toggle'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46880/ --- (Updated May 5, 2016, 1:45 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46881: Added authorization callback for '/logging/toggle'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46881/ --- (Updated May 5, 2016, 1:45 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46989/ --- (Updated May 5, 2016, 1:46 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

> On April 22, 2016, 8:07 a.m., Avinash sridharan wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 169 > > > > > > We shouldn't need this since "network/cni" is enabled by default. Since this is the t

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 5, 2016, 7:44 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 31 > > > > > > No need for `#ifdef __linux__` because the file is guarded by `if > > OS_LINUX` in makefile. OK. And

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated May 5, 2016, 10:29 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46435/ --- (Updated May 5, 2016, 10:30 p.m.) Review request for mesos, Avinash sridharan a

Review Request 47019: Fixed incorrect include sections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47019/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti

Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46436/ --- (Updated May 5, 2016, 10:56 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/ --- (Updated May 5, 2016, 10:57 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 46975: Add title and heading in Mesos Log Page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46975/ --- (Updated 五月 5, 2016, 2:55 p.m.) Review request for mesos, Zhiwei Chen and haosd

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

> On April 27, 2016, 8:55 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 44-46 > > > > > > Doesn't look like we need these anymore. Update: We do need them in the new changeset. > On Ap

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

> On April 27, 2016, 8:55 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 13-42 > > > > > > It seems like most of these are no longer necessary. Can we prune this > > a little bit, please?

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/ --- (Updated May 5, 2016, 3:35 p.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 46321: Renamed a variable in command executors for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46321/ --- (Updated May 5, 2016, 3:37 p.m.) Review request for mesos and Ben Mahler. Rep

Re: Review Request 46322: Added KillPolicy to scheduler and executor Kill protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46322/ --- (Updated May 5, 2016, 3:37 p.m.) Review request for mesos and Ben Mahler. Bug

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- (Updated May 5, 2016, 3:37 p.m.) Review request for mesos, Benjamin Bannier and

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- (Updated May 5, 2016, 3:38 p.m.) Review request for mesos and Ben Mahler. Bug

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated May 5, 2016, 3:39 p.m.) Review request for mesos, Ben Mahler and Qian

Re: Review Request 47019: Split includes into sections by subfolders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47019/#review131839 --- Ship it! Ship It! - Alexander Rukletsov On May 5, 2016, 3:52

Re: Review Request 47019: Split includes into sections by subfolders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47019/ --- (Updated May 5, 2016, 3:52 p.m.) Review request for mesos and Alexander Ruklets

Re: Review Request 43555: Removed extra blank line in strings_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43555/#review131840 --- Ship it! Ship It! - Alexander Rukletsov On April 29, 2016, 1

Re: Review Request 43555: Removed extra blank line in strings_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43555/ --- (Updated May 5, 2016, 3:54 p.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 47019: Fixed include sections style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47019/ --- (Updated May 5, 2016, 3:54 p.m.) Review request for mesos and Alexander Ruklets

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

> On May 4, 2016, 10:53 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2240-2270 > > > > > > Consider this if you would to preserve the guarantee: > > > > ```cpp > > struct >

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/ --- (Updated May 5, 2016, 3:55 p.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

> On May 4, 2016, 8:34 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, lines 623-624 > > > > > > How about something like: "The principal should be authorized to query > > this endpoint"? +1, although I'd

Re: Review Request 46936: Documented the agent endpoint '/flags'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46936/#review131848 --- docs/endpoints/slave/flags.md (line 15)

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/#review131846 --- src/tests/hierarchical_allocator_tests.cpp (lines 197 - 199)

Re: Review Request 44425: Removed "__linux__" marco and "using namespace" in system isolator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44425/#review131855 --- Fix it, then Ship it! src/tests/containerizer/filesystem_isola

Re: Review Request 42290: Removed "__linux__" marco from runtime isolator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42290/#review131854 --- Ship it! Ship It! - Gilbert Song On May 5, 2016, 2:35 a.m.,

Re: Review Request 41439: Removed unused variables from filesystem isolator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41439/#review131857 --- Since you are alraedy here. Could you please grep it and fix all?

Re: Review Request 41439: Removed unused variables from filesystem isolator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41439/#review131859 --- Ship it! Nvm, just see they are fixed. Thanks! - Gilbert Song

Re: Review Request 44390: Updated indent when creating MockScheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44390/#review131861 --- Ship it! Ship It! - Gilbert Song On May 5, 2016, 2:28 a.m.,

Re: Review Request 44160: Replaced ".get().xxx" with "->xxx".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44160/#review131862 --- Ship it! Ship It! - Gilbert Song On May 5, 2016, 2:30 a.m.,

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/#review131866 --- src/slave/http.cpp (line 373)

Re: Review Request 44160: Replaced ".get().xxx" with "->xxx".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44160/#review131868 --- Patch looks great! Reviews applied: [44425, 41439, 44390, 44160]

Re: Review Request 46920: Added validation hook inside Slave::runTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131869 --- The hooks looks good but I have a high-level question. Instead of

Re: Review Request 46321: Renamed a variable in command executors for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46321/#review131877 --- Let's punt on this rename in favor of introducing explicit task li

Review Request 47032: Fixed HttpCachedConcurrent flakiness in slow machine.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47032/ --- Review request for mesos, Bernd Mathiske, Joseph Wu, and Till Toenshoff. Bugs:

Re: Review Request 46975: Add title and heading in Mesos Log Page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46975/#review131882 --- src/webui/master/static/pailer.html (line 24)

Re: Review Request 46966: Form controls must have associated labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46966/#review131883 --- I think change the `Summary`(the commit message) to `Added associa

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/#review131880 --- Can you move the introduction of 'terminated' into this patch? Cur

Re: Review Request 42028: Added test "ROOT_CommandTaskNoRootfsFailedWithSameVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42028/#review131887 --- Ship it! Ship It! - Jie Yu On May 4, 2016, 11:32 p.m., Guang

Re: Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46876/ --- (Updated May 5, 2016, 6:40 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/#review131891 --- Ship it! Ship It! - Jie Yu On May 5, 2016, 1:46 a.m., Guangy

Re: Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.

> On May 4, 2016, 3:24 a.m., Kapil Arya wrote: > > src/tests/scheduler_driver_tests.cpp, line 99 > > > > > > Why this change? This test broke with the new changes, and after looking at the HTTP handling code again,

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46989/ --- (Updated May 5, 2016, 6:58 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/#review131894 --- Fix it, then Ship it! src/tests/containerizer/docker_volume_is

Re: Review Request 44440: Added test "ROOT_CommandTaskNoRootfsSingleVolumeMultipleContainers".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/0/#review131896 --- Ship it! Ship It! - Jie Yu On May 5, 2016, 6:04 a.m., Guangy

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/#review131897 --- Patch looks great! Reviews applied: [46096, 46097, 46435, 46436,

Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39474/#review131899 --- src/tests/containerizer/docker_volume_isolator_tests.cpp (line 83

Re: Review Request 42290: Removed "__linux__" marco from runtime isolator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42290/#review131901 --- Ship it! Ship It! - Jie Yu On May 5, 2016, 9:35 a.m., Guangy

Re: Review Request 41439: Removed unused variables from filesystem isolator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41439/#review131903 --- Ship it! Ship It! - Jie Yu On May 5, 2016, 9:28 a.m., Guangy

Re: Review Request 44390: Updated indent when creating MockScheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44390/#review131904 --- Ship it! Ship It! - Jie Yu On May 5, 2016, 9:28 a.m., Guangy

Re: Review Request 44160: Replaced ".get().xxx" with "->xxx".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44160/#review131905 --- Ship it! Ship It! - Jie Yu On May 5, 2016, 9:30 a.m., Guangy

Re: Review Request 46370: Introduced linux capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 5, 2016, 7:42 p.m.) Review request for mesos, Jie Yu and Kevin Klu

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46866/ --- (Updated May 5, 2016, 8:11 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46989/ --- (Updated May 5, 2016, 8:15 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review131890 --- src/launcher/http_command_executor.cpp (lines 569 - 575)

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review131920 --- Patch looks great! Reviews applied: [46321, 46491, 46322, 46323,

Re: Review Request 46504: Constructed error string in MethodNotAllowed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46504/#review131919 --- 3rdparty/libprocess/include/process/http.hpp (lines 584 - 603)

Re: Review Request 46920: Added validation hook inside Slave::runTask.

> On May 5, 2016, 10:27 a.m., Kapil Arya wrote: > > The hooks looks good but I have a high-level question. Instead of having > > two separate hooks for validation and label-decoration, I am wondering, if > > we can have one consolidated hook. That hook would then update the labels > > (and any

Re: Review Request 46504: Constructed error string in MethodNotAllowed.

> On May 5, 2016, 8:49 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 584-603 > > > > > > Is this a strict format? That is, are we required to phraes it this > > way? Can we just t

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46798/ --- (Updated May 5, 2016, 9 p.m.) Review request for mesos and Jie Yu. Repository

Re: Review Request 46371: Added basic tests for capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- (Updated May 5, 2016, 9:01 p.m.) Review request for mesos and Jie Yu. Reposit

Re: Review Request 46504: Constructed error string in MethodNotAllowed.

> On May 5, 2016, 8:49 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 616-617 > > > > > > Why not just use a lambda? > > > > ```cpp > > MethodNotAllowed( > >

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 4, 2016, 11:44 p.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 31 > > > > > > No need for `#ifdef __linux__` because the file is guarded by `if > > OS_LINUX` in makefile. > > Qi

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review131933 --- src/tests/containerizer/cni_isolator_tests.cpp (line 53)

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review131935 --- 3rdparty/libprocess/include/process/windows/subprocess.hpp (line

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review131937 --- This test failed on my machine: ``` E0505 14:28:48.309273 42478 s

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

> On May 4, 2016, 10:53 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2240-2270 > > > > > > Consider this if you would to preserve the guarantee: > > > > ```cpp > > struct >

Re: Review Request 46779: Clarified and improved maintenance docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46779/#review131940 --- Ship it! Ship It! - Jie Yu On May 1, 2016, 8:49 a.m., Neil C

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On May 2, 2016, 9:14 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess_windows.cpp, line 414 > > > > > > Remove newline. > > Alex Clemmer wrote: > I wasn't sure of intent here. You mean, remove

Re: Review Request 46780: Clarify that slave checkpoint is always enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46780/#review131941 --- Ship it! Ship It! - Jie Yu On April 28, 2016, 2:53 p.m., Nei

Re: Review Request 46781: Fixed invalid JSON in scheduler HTTP API examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46781/#review131943 --- Ship it! Ship It! - Jie Yu On April 28, 2016, 3:50 p.m., Nei

Re: Review Request 46782: Removed false claim that TEARDOWN can remove persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46782/#review131944 --- Ship it! Ship It! - Jie Yu On May 2, 2016, 9:15 a.m., Neil C

Re: Review Request 46783: Minor clarifications to HA framework guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46783/#review131945 --- Ship it! Ship It! - Jie Yu On May 2, 2016, 2:38 p.m., Neil C

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review131946 --- Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/inclu

Re: Review Request 46814: Refactored FlagsBase::load().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46814/#review131948 --- Ship it! Ship It! - Michael Park On April 30, 2016, 1:59 a.m

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 5, 2016, 9:29 p.m., Jie Yu wrote: > > This test failed on my machine: > > > > ``` > > E0505 14:28:48.309273 42478 slave.cpp:3995] Container > > '33dc5d83-125f-4da2-8c69-cba76d95955b' for executor > > '0e6076e9-9cc3-4319-aacd-6b6bb8651e9b' of framework > > 9ecf5fd8-ad54-4973-9688-bcc6

Re: Review Request 47032: Fixed HttpCachedConcurrent flakiness in slow machine.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47032/#review131958 --- Patch looks great! Reviews applied: [47032] Passed command: expo

  1   2   >