Re: Review Request 50810: Fixed provisioner appc support on windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/#review145223 --- Second thought. we should just to the following in `__provision`:

Re: Review Request 50920: Removed extra spaces in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50920/#review145232 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 9, 2016,

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

> On Aug. 6, 2016, 6:06 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, lines 282-283 > > > > > > what about a new line here? I did it on purpose. But you are right. One more

Re: Review Request 50921: Fixed the incorrect order of header files in executor.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50921/#review145233 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 9, 2016,

Re: Review Request 50810: Fixed provisioner appc support on windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/#review145221 --- Ship it! Ship It! - Jie Yu On Aug. 4, 2016, 5:05 p.m.,

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50922/ --- (Updated Aug. 9, 2016, 6:13 p.m.) Review request for mesos, Alexander

Re: Review Request 50810: Fixed provisioner appc support on windows build.

> On Aug. 9, 2016, 10:06 a.m., Jie Yu wrote: > > Second thought. we should just to the following in `__provision`: > > ``` > > #ifdef WINDOWS > > return ProvisionInfo{...}; > > #else > > // the original logic. > > #endif > > ``` Agree. Obviously more clear in this way. Will fix it. - Gilbert

Re: Review Request 50936: Kept poll socket alive while sending.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50936/ --- (Updated Aug. 9, 2016, 11:31 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50769: Fixed a broken link to CNI repo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50769/ --- (Updated Aug. 10, 2016, 1:11 a.m.) Review request for mesos and Jie Yu.

Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50941/ --- Review request for mesos. Bugs: MESOS-5985

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50941/#review145297 --- docs/cni.md (lines 221 - 222)

Re: Review Request 50936: Kept poll socket alive during 'send()' continuations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50936/#review145284 --- Thanks Greg! 3rdparty/libprocess/src/poll_socket.cpp (line 166)

Re: Review Request 50936: Kept poll socket alive during 'send()' continuations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50936/ --- (Updated Aug. 9, 2016, 11:30 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50936: Kept poll socket alive while sending.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50936/ --- (Updated Aug. 10, 2016, 12:06 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50941/ --- (Updated Aug. 10, 2016, 1:41 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 50936: Kept poll socket alive while sending.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50936/#review145293 --- Ship it! Ship It! - Benjamin Mahler On Aug. 9, 2016, 11:31

Re: Review Request 50771: Added coverity build to build_docker.sh.

> On Aug. 9, 2016, 9:58 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 134 > > > > > > can the email be d...@mesos.apache.org? Done - Joerg ---

Re: Review Request 50771: Added coverity build to build_docker.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50771/ --- (Updated Aug. 10, 2016, 12:58 a.m.) Review request for mesos and Vinod Kone.

Review Request 50940: Removed a limitation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50940/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-5985

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated Aug. 10, 2016, 2 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/#review145288 --- Ship it! Ship It! - Jie Yu On Aug. 9, 2016, 6:38 p.m.,

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

> On Aug. 10, 2016, 1:26 a.m., Qian Zhang wrote: > > docs/cni.md, lines 221-222 > > > > > > I think it keeps an in-memory copy in > > `NetworkCniIsolatorProcess::NetworkConfigInfo::config`.

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/#review145305 --- support/mesos-style.py (line 219)

Re: Review Request 50907: Abstracted mesos-style.py to wrap the cpp linter in a class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50907/#review145304 --- Ship it! Ship It! - Vinod Kone On Aug. 8, 2016, 7:49 p.m.,

Re: Review Request 50899: Removed unneeded extra space in stout code base.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50899/#review145190 --- Ship it! Ship It! - Tomasz Janiszewski On Aug. 8, 2016,

Re: Review Request 50921: Fixed the incorrect order of header files in executor.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50921/ --- (Updated Aug. 9, 2016, 10:18 a.m.) Review request for mesos, Alexander

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50922/ --- (Updated Aug. 9, 2016, 10:18 a.m.) Review request for mesos, Alexander

Re: Review Request 50920: Removed extra spaces in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50920/ --- (Updated Aug. 9, 2016, 10:18 a.m.) Review request for mesos, Alexander

Re: Review Request 50920: Removed extra spaces in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50920/#review145194 --- Ship it! Ship It! - Gastón Kleiman On Aug. 9, 2016, 10:18

Re: Review Request 50887: Trimmed unneeded extra space between right angle brackets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50887/#review145189 --- Ship it! Ship It! - Tomasz Janiszewski On Aug. 8, 2016,

Re: Review Request 50897: Added compiler information to the output of ./configure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50897/#review145195 --- While working on https://reviews.apache.org/r/50853/, I thought

Re: Review Request 50923: Updated the links of Homebrew in release-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50923/#review145199 --- Patch looks great! Reviews applied: [50923] Passed command:

Re: Review Request 50921: Fixed the incorrect order of header files in executor.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50921/#review145196 --- Ship it! Ship It! - Gastón Kleiman On Aug. 9, 2016, 10:18

Re: Review Request 50900: Removed unneeded extra space in libprocess code base.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50900/#review145191 --- Ship it! Ship It! - Tomasz Janiszewski On Aug. 8, 2016,

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50922/ --- (Updated Aug. 9, 2016, 9:17 a.m.) Review request for mesos, Alexander

Review Request 50920: Removed extra spaces in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50920/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón

Review Request 50921: Fixed the incorrect order of header files in executor.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50921/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón

Review Request 50922: Moved the implementation of health check to health_checker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50922/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 八月 9, 2016, 9:25 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50763/#review145179 --- Patch looks great! Reviews applied: [50762, 50763] Passed

Review Request 50923: Updated the links of Homebrew in release-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50923/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50763/ --- (Updated Aug. 9, 2016, 6:19 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50269: Added basic tests for capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/ --- (Updated Aug. 9, 2016, 2:30 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50889: Introduce parsing and stringification of `CapabilityInfo`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50889/ --- (Updated Aug. 9, 2016, 2:30 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 50266: Introduced linux capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50266/ --- (Updated Aug. 9, 2016, 2:30 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50922/#review145214 --- Patch looks great! Reviews applied: [50920, 50921, 50922]

Re: Review Request 50923: Updated the links of Homebrew in release-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50923/#review145217 --- Ship it! Ship It! - Vinod Kone On Aug. 9, 2016, 9:25 a.m.,

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50763/#review145218 --- Ship it! Ship It! - Jie Yu On Aug. 9, 2016, 6:19 a.m.,

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated Aug. 9, 2016, 6:40 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated Aug. 9, 2016, 6:41 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 45573: Added `PerfEventHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated Aug. 9, 2016, 6:40 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated Aug. 9, 2016, 6:41 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50914: Removed the external containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50914/ --- (Updated Aug. 9, 2016, 1:12 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review145265 --- src/Makefile.am (line 535)

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > src/Makefile.am, line 535 > > > > > > This will break agent headers. > > > > FOr instance, isolator.hpp has the following: > > ``` > > #include > >

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > Look back at the thread above started by Vinod. This was dicussed in there, though it's not clear what the outcome was. - Kevin --- This is an automatically generated e-mail. To reply,

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > > > Kevin Klues wrote: > Look back at the thread above started by Vinod. This was dicussed in > there, though it's not clear what the outcome was. Also, if you look further down in the patch, the line: ``` ln -s

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > > > Kevin Klues wrote: > Look back at the thread above started by Vinod. This was dicussed in > there, though it's not clear what the outcome was. > > Kevin Klues wrote: > Also, if you look further down in the patch, the line: > >

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > src/Makefile.am, line 535 > > > > > > This will break agent headers. > > > > FOr instance, isolator.hpp has the following: > > ``` > > #include > >

Review Request 50936: Kept poll socket alive during 'send()' continuations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50936/ --- Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone. Bugs:

Re: Review Request 50936: Kept poll socket alive during 'send()' continuations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50936/ --- (Updated Aug. 9, 2016, 9:56 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50540: Add systemd watchdog support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50540/#review144525 --- configure.ac (lines 615 - 616)

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated Aug. 9, 2016, 6:39 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated Aug. 9, 2016, 6:38 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated Aug. 9, 2016, 6:42 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50922/#review145244 --- Patch looks great! Reviews applied: [50922] Passed command:

Re: Review Request 50810: Fixed provisioner appc support on windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/ --- (Updated Aug. 9, 2016, 12:24 p.m.) Review request for mesos, Artem

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/#review145259 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 9, 2016, 6:40 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated Aug. 9, 2016, 6:39 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

> On Aug. 7, 2016, 1 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, lines 172-175 > > > > > > Just curious why we need this method? When will it be called? Now it called

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Aug. 9, 2016, 6:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- (Updated Aug. 9, 2016, 6:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- (Updated Aug. 9, 2016, 6:44 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/#review145257 --- Patch looks great! Reviews applied: [49819, 49820, 49821, 49823,

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated Aug. 9, 2016, 6:38 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50810: Fixed provisioner appc support on windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/#review145251 --- Ship it! Note: The original code compiles on Windows :) -

Re: Review Request 50837: Fixed minor code style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50837/#review145249 --- Ship it! Ship It! - Joseph Wu On Aug. 5, 2016, 1:15 a.m.,

Re: Review Request 50771: Added coverity build to build_docker.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50771/#review145273 --- Fix it, then Ship it! support/docker_build.sh (line 125)

Re: Review Request 50266: Introduced linux capabilities API.

> On July 22, 2016, 12:32 a.m., Jie Yu wrote: > > src/linux/capabilities.cpp, lines 34-39 > > > > > > Any reason why we need to declare them here? Shouldn't > > `` already declared them? > > Benjamin Bannier wrote:

Re: Review Request 50266: Introduced linux capabilities API.

> On July 22, 2016, 12:32 a.m., Jie Yu wrote: > > src/linux/capabilities.hpp, lines 108-110 > > > > > > No need to for this friend unqulified function. This can just be a > > member function. > > Benjamin Bannier

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

> On 八月 6, 2016, 1:06 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, lines 295-299 > > > > > > I think we may need a test case to cover select backend smartly? > > Gilbert

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/ --- (Updated Aug. 9, 2016, 6:42 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- (Updated Aug. 9, 2016, 6:42 p.m.) Review request for mesos, Gilbert Song, Jie