Re: Review Request 50981: Fix volumes help message example mistake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50981/#review152734 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 11, 2016,

Review Request 52898: Tweaked description of framework checkpointing behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52898/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 52899: Added "os/wait.hpp" to stout's "os.hpp" header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52899/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6310

Re: Review Request 40487: MESOS-3959: show slave hostname on executor page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40487/ --- (Updated Oct. 14, 2016, 8:19 p.m.) Review request for mesos and Benjamin

Re: Review Request 40487: MESOS-3959: show slave hostname on executor page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40487/#review152729 --- Fix it, then Ship it! Looks like the file has been renamed.

Re: Review Request 52827: Added backend suffix to image layer rootfs path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52827/#review152721 --- Fix it, then Ship it! Can you follow up with a test to test

Re: Review Request 52880: Added "launcher_dir" to the default executor flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52880/#review152730 --- This is conversation carried over from /r/52556/ Now that we're

Re: Review Request 52898: Tweaked description of framework checkpointing behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52898/#review152746 --- Ship it! Ship It! - Vinod Kone On Oct. 14, 2016, 9:36 p.m.,

Review Request 52901: Added documentation for default executor and LAUNCH_GROUP event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52901/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Repository: mesos

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 十月 14, 2016, 10:07 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review152647 --- src/tests/containerizer/docker_containerizer_tests.cpp (lines

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 十月 14, 2016, 9:57 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review152638 --- src/tests/containerizer/docker_containerizer_tests.cpp (lines

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 14, 2016, 9:58 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

> On 十月 14, 2016, 10:06 a.m., Guangya Liu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, lines 3994-3996 > > > > > > Missed update here? ``` EXPECT_TRUE(inspect->devices[i].access.read);

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

> On 十月 14, 2016, 10:06 a.m., Guangya Liu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, lines 3994-3996 > > > > > > Missed update here? > > Guangya Liu wrote: > ``` >

Re: Review Request 52853: Fixed typo in a comment in hooks.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52853/#review152653 --- Patch looks great! Reviews applied: [52853] Passed command:

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/ --- (Updated Oct. 14, 2016, 7:19 a.m.) Review request for hbase. Changes ---

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 14, 2016, 9:56 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 14, 2016, 9:55 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 14, 2016, 9:56 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 十月 14, 2016, 10:01 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated 十月 14, 2016, 10:01 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52848: Cleaned up style in stout rmdir_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52848/#review152639 --- Patch looks great! Reviews applied: [50673, 52848] Passed

Re: Review Request 52899: Added "os/wait.hpp" to stout's "os.hpp" header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52899/#review152749 --- Ship it! Ship It! - Jie Yu On Oct. 14, 2016, 9:50 p.m.,

Re: Review Request 52387: Consistently used virtual inheritance for Flags classes in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52387/#review152754 --- Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:58

Re: Review Request 49833: Consistently used virtual inheritance for Flags classes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49833/#review152753 --- Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:58

Re: Review Request 49829: Consistently used virtual inheritance for Flags classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49829/#review152755 --- Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:58

Re: Review Request 52817: Added utils method to check if `ExecutorInfo` different.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52817/#review152756 --- src/common/type_utils.cpp (line 327)

Re: Review Request 50675: Libprocess: Enabled tests that pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50675/#review152750 --- Fix it, then Ship it! I can fix the one test you missed. ---

Re: Review Request 52856: Reverted incorrect changes in 1c2ee5c.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52856/#review152752 --- Fix it, then Ship it! src/local/local.cpp (line 179)

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review152763 --- This will no longer be necessary after

Re: Review Request 52817: Added utils method to check if `ExecutorInfo` different.

> On Oct. 14, 2016, 11:09 p.m., Vinod Kone wrote: > > src/common/type_utils.cpp, line 327 > > > > > > didn't realize there is this new patch when i commited this chain! > > > > anyway, i think you can kill

Review Request 52906: Simplify the comparison log for `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52906/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6283

Re: Review Request 52906: Simplify the comparison logic for `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52906/ --- (Updated Oct. 15, 2016, 5:06 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52803: Changed agent to send TASK_GONE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52803/#review152771 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review152772 --- Patch looks great! Reviews applied: [52828, 52058] Passed

Re: Review Request 52906: Simplify the comparison log for `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52906/ --- (Updated Oct. 15, 2016, 5:03 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52906: Simplify the comparison logic for `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52906/ --- (Updated Oct. 15, 2016, 5:04 a.m.) Review request for mesos, Anand Mazumdar

Review Request 52869: Ensured command executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52869/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.

Review Request 52868: Added pause/resume functionality to HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review152670 --- Ship it! src/tests/health_check_tests.cpp (line 997)

Review Request 52871: Ensured default executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52871/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and

Re: Review Request 52608: Reordered the list of executor env variables in code and documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52608/#review152667 --- Superseded by the chain starting with

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/ --- (Updated Oct. 14, 2016, 12:51 p.m.) Review request for mesos, Daniel Pravat,

Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- Review request for mesos, Adam B, Benjamin Bannier, and Michael Park. Bugs:

Re: Review Request 52864: Removed unnecessary sleep in HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52864/#review152669 --- Ship it! Ship It! - Gastón Kleiman On Oct. 14, 2016, 12:35

Review Request 52863: Refactored HealthCheck validation for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52863/ --- Review request for mesos, Gastón Kleiman and haosdent huang. Repository: mesos

Re: Review Request 52855: Re-enabled the change user test in slave tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52855/#review152661 --- Patch looks great! Reviews applied: [52854, 52855] Passed

Review Request 52872: Used callback instead of `send()` for health status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52872/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and

Review Request 52873: Cleaned up private members in HealthChecker class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52873/ --- Review request for mesos, Gastón Kleiman and haosdent huang. Repository: mesos

Re: Review Request 52871: Ensured default executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52871/ --- (Updated Oct. 14, 2016, 12:52 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52556/#review152666 --- Superseded by the chain starting with

Review Request 52878: Removed outdated TODO in stout::flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52878/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, and Jiang Yan Xu.

Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and

Review Request 52870: Ensured docker executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.

Review Request 52879: Updated the way in which the default and command executors load options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Jie Yu, and

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- (Updated Oct. 14, 2016, 3:14 p.m.) Review request for mesos, Michael Park and

Review Request 52887: Added a CHANGELOG description for partition-aware frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52887/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Repository:

Re: Review Request 52803: Changed agent to send TASK_GONE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52803/ --- (Updated Oct. 14, 2016, 4:02 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52868: Added pause/resume functionality to HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/ --- (Updated Oct. 14, 2016, 12:52 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 52880: Added "launcher_dir" to the default executor flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52880/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Jie Yu, and

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/ --- (Updated Oct. 14, 2016, 3:26 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 52827: Added backend suffix to image layer rootfs path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52827/ --- (Updated Oct. 14, 2016, 11:36 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/ --- (Updated Oct. 14, 2016, 4:01 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Oct. 14, 2016, 3:20 p.m.) Review request for mesos, Michael Park and

Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/ --- Review request for mesos, Michael Park and Neil Conway. Bugs: MESOS-6239

Re: Review Request 52868: Added pause/resume functionality to HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/#review152684 --- Ship it! Ship It! - Gastón Kleiman On Oct. 14, 2016, 12:52

Re: Review Request 52869: Ensured command executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52869/#review152685 --- Ship it! Ship It! - Gastón Kleiman On Oct. 14, 2016, 12:41

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Oct. 14, 2016, 3:20 p.m.) Review request for mesos, Michael Park and

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Oct. 14, 2016, 3:20 p.m.) Review request for mesos, Michael Park and

Re: Review Request 52827: Added backend suffix to image layer rootfs path.

> On Oct. 14, 2016, 7:34 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/docker/paths.cpp, lines 61-64 > > > > > > In fact, i think we should use aufs style whiteout by default because > > that's

Review Request 52881: Made sure required capabilities are not dropped in capabilities test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52881/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6386

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review152671 --- Ship it! Ship It! - Gastón Kleiman On Oct. 14, 2016, 12:38

Re: Review Request 52873: Cleaned up private members in HealthChecker class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52873/#review152676 --- Patch looks great! Reviews applied: [52863, 52864, 52865, 52866,

Re: Review Request 52873: Cleaned up private members in HealthChecker class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52873/#review152672 --- Ship it! Ship It! - Gastón Kleiman On Oct. 14, 2016, 12:45

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/#review152675 --- Ship it! Ship It! - Gastón Kleiman On Oct. 14, 2016, 12:51

Re: Review Request 52901: Added documentation for default executor and LAUNCH_GROUP event.

> On Oct. 14, 2016, 11:23 p.m., Benjamin Mahler wrote: > > CHANGELOG, lines 5-10 > > > > > > It would be nice to distinguish the nested container support and the > > task group support in the changelog, i.e. we

Review Request 52902: Updated default value of the '--runtime_dir' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52902/ --- Review request for mesos. Repository: mesos Description --- Previously,

Re: Review Request 52901: Added documentation for default executor and LAUNCH_GROUP event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52901/ --- (Updated Oct. 15, 2016, 12:03 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 52814: Added note to CHANGELOG about --runtime_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52814/ --- (Updated Oct. 15, 2016, 12:04 a.m.) Review request for mesos, Alexander

Re: Review Request 52902: Updated default value of the '--runtime_dir' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52902/ --- (Updated Oct. 15, 2016, 12:05 a.m.) Review request for mesos. Bugs:

Re: Review Request 52814: Added note to CHANGELOG about --runtime_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52814/#review152764 --- Fix it, then Ship it! CHANGELOG (line 18)

Re: Review Request 52902: Updated default value of the '--runtime_dir' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52902/#review152765 --- Ship it! Ship It! - Vinod Kone On Oct. 15, 2016, 12:05

Re: Review Request 52814: Added note to CHANGELOG about --runtime_dir.

> On Oct. 15, 2016, 12:08 a.m., Vinod Kone wrote: > > CHANGELOG, line 18 > > > > > > I would move this to "Additional API Changes" section since that's > > where we have been calling out important flags changes.

Re: Review Request 52887: Added a CHANGELOG description for partition-aware frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52887/#review152767 --- Patch looks great! Reviews applied: [52887] Passed command:

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52783/#review152768 --- I would like to have another separate docs/linux_capabilities.md

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review152761 --- I have a feeling that if you kept around a stringstream with the

Re: Review Request 52901: Added documentation for default executor and LAUNCH_GROUP event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52901/#review152759 --- Fix it, then Ship it! CHANGELOG (lines 5 - 10)

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/#review152636 --- Ship it! Committing with minor edits.

Re: Review Request 51617: Added the `remove` and `insert` methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/#review152637 --- Patch looks great! Reviews applied: [52671, 52771, 52772, 52773,

Re: Review Request 52854: Fixed the sandbox owner for command tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52854/#review152698 --- Ship it! src/launcher/posix/executor.cpp (lines 99 - 100)

Re: Review Request 52870: Ensured docker executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/#review152699 --- Ship it! Ship It! - Gastón Kleiman On Oct. 14, 2016, 12:42

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review152704 --- This still doesn't have the right semantics: ```

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review152692 --- Patch looks great! Reviews applied: [52877] Passed command:

Re: Review Request 52705: Added 'stout/wait.hpp' header.

> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 25 > > > > > > Couple of questions here: > > > > * This seems useful for POSIX platforms, but I don't really

Re: Review Request 52705: Added 'stout/wait.hpp' header.

> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 25 > > > > > > Couple of questions here: > > > > * This seems useful for POSIX platforms, but I don't really

Review Request 52867: Used `Duration::create` for double -> Duration conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/ --- Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and

Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/ --- Review request for mesos, Gastón Kleiman and haosdent huang. Repository: mesos

Re: Review Request 52863: Refactored HealthCheck validation for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52863/#review152668 --- Ship it! Ship It! - Gastón Kleiman On Oct. 14, 2016, 12:35

  1   2   >