Re: Review Request 56742: Updated CHANGELOG for Mesos 1.2.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56742/ --- (Updated Feb. 20, 2017, 1:22 a.m.) Review request for mesos, Jie Yu and Vinod

Review Request 56851: Updated OCI protobuf messages with latest OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56851/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-6681

Review Request 56847: Remove unecessary leveldb build rule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- Review request for mesos and haosdent huang. Repository: mesos Description

Re: Review Request 56493: Port_mapping isolator: do not depend on interface speed.

> On Feb. 17, 2017, 10:51 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 1597 > > > > > > We don't add period in log lines. Sorry for that. I see that you've already

Re: Review Request 56847: Remove unecessary leveldb build rule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 11:52 a.m.) Review request for mesos and haosdent

Re: Review Request 56742: Updated CHANGELOG for Mesos 1.2.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56742/#review166088 --- Patch looks great! Reviews applied: [56742] Passed command:

Re: Review Request 56836: Added test for a task specifying on termination policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56836/#review166067 --- Patch looks great! Reviews applied: [56830, 56831, 56832, 56833,

Re: Review Request 56537: Added a test to ensure framework can upgrade to support MULTI_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56537/#review166081 --- Patch looks great! Reviews applied: [56537] Passed command:

Review Request 56852: Updated OCI spec parsing & validation code with latest OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56852/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-6681

Review Request 56853: Update OCI tests with the latest OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56853/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-6681

Re: Review Request 56847: Removed unnecessary leveldb build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/#review166098 --- Ship it! I adjust to only build `libleveldb.a` ``` -all:

Re: Review Request 56847: Removed unnecessary leveldb build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 4:45 p.m.) Review request for mesos and haosdent

Re: Review Request 56847: Removed unnecessary leveldb build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 4:33 p.m.) Review request for mesos and haosdent

Re: Review Request 56847: Remove unecessary leveldb build rule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/#review166096 --- According to my test, apply this change should be enough. ```

Re: Review Request 56493: Port_mapping isolator: do not depend on interface speed.

> On Feb. 17, 2017, 10:51 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, lines > > 1601-1602 > > > > > > I would still return Error here. > > Pierre Cheynier wrote: >

Re: Review Request 56847: Removed unnecessary leveldb build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 4:35 p.m.) Review request for mesos and haosdent

Re: Review Request 51053: Update leveldb to 1.19.

> On Aug. 22, 2016, 2:29 a.m., Vinod Kone wrote: > > Have you also done compatibility tests mentioned in the ticket? > > Tomasz Janiszewski wrote: > No. It's minior upgrade from 1.18 to 1.19 but I can got thur >

Re: Review Request 51053: Update leveldb to 1.19.

> On Aug. 22, 2016, 4:29 a.m., Vinod Kone wrote: > > Have you also done compatibility tests mentioned in the ticket? > > Tomasz Janiszewski wrote: > No. It's minior upgrade from 1.18 to 1.19 but I can got thur >

Re: Review Request 55576: Fixes FutureTest.After3 flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/ --- (Updated Feb. 20, 2017, 2:41 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 56847: Remove unecessary leveldb build rule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/#review166091 --- Patch looks great! Reviews applied: [56847] Passed command:

Re: Review Request 55576: Fixes FutureTest.After3 flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/#review166107 --- Patch looks great! Reviews applied: [55576] Passed command:

Re: Review Request 56493: Port_mapping isolator: do not depend on interface speed.

> On Feb. 17, 2017, 10:51 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, lines > > 1601-1602 > > > > > > I would still return Error here. > > Pierre Cheynier wrote: >

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review166111 --- Hey looks like slave_authorization_tests.cpp is more suitable

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review166116 --- Looks good for a foundation, but I haven't looked at the rest of

Re: Review Request 56617: Updated libprocess handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56617/#review166117 --- Ship it! Ship It! - Adam B On Feb. 13, 2017, 7:41 p.m.,

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/#review166118 --- Lookin good include/mesos/authorizer/authorizer.proto (lines 29

Re: Review Request 56619: Updated 'Files' handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/#review166119 --- Ship it! Ship It! - Adam B On Feb. 17, 2017, 7 p.m., Greg

Re: Review Request 54783: Adds authorization tests of launching container sessions API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54783/#review166120 --- Ship it! Looks like a fine test of unauthorized access.

Re: Review Request 56804: Cleaned up weights handling code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56804/#review166122 --- Ship it! Ship It! - Adam B On Feb. 17, 2017, 4:14 p.m.,

Re: Review Request 56812: Updated agent handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56812/#review166123 --- Ship it! Ship It! - Adam B On Feb. 17, 2017, 7:02 p.m.,

Re: Review Request 54784: Added authorization tests when trying to attach to a container input.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54784/#review166121 --- Ship it! Ship It! - Adam B On Feb. 15, 2017, 6:31 a.m.,

Re: Review Request 56814: Wrapped IOSwitchboard.connect() in a dispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56814/#review166124 --- Ship it! Good catch! - Jie Yu On Feb. 18, 2017, 6:40 p.m.,

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

> On Feb. 20, 2017, 7:07 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 1713 > > > > > > s/tasks(s) // > > because it's already in `taskOrTaskGroup`? > > > > Also s/WARNING/ERROR/ because

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

> On Feb. 20, 2017, 7:50 a.m., Jiang Yan Xu wrote: > > src/tests/slave_tests.cpp, line 4965 > > > > > > s/users/user/ `users` is fine since there are 2 users, i.e. `bar` and the current user. - Anindya

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated Feb. 21, 2017, 7:21 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated Feb. 21, 2017, 7:20 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

> On Feb. 21, 2017, 12:18 a.m., Jiang Yan Xu wrote: > > Hey looks like slave_authorization_tests.cpp is more suitable place to put > > this test? Fair enough. Moved the test to `slave_authorization_tests.cpp` in the latest update. - Anindya

Review Request 56867: WIP: Added upgrade guide for 1.2.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56867/ --- Review request for mesos. Repository: mesos Description --- Added