Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

2017-11-27 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/ --- (Updated Nov. 27, 2017, 10:43 p.m.) Review request for mesos, Alexander

Re: Review Request 64086: Removed currently unneeded 'AWAIT_READY's in 'MockResourceProvider'.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64086/ --- (Updated Nov. 27, 2017, 4:18 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 64054: Refactored offer operation handling for speculative operations.

2017-11-27 Thread Benjamin Bannier
> On Nov. 26, 2017, 4:40 a.m., Jie Yu wrote: > > src/master/master.hpp > > Lines 2795-2841 (original) > > > > > > This should still be part of `addOfferOperation`. In fact, anything to > > do with `used` resourecs

Review Request 64086: Removed currently unneeded 'AWAIT_READY's in 'MockResourceProvider'.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64086/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 27, 2017, 3:55 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63997: Added a new allocator method to add resources to agents.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63997/ --- (Updated Nov. 27, 2017, 3:55 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64084: Made explicit that a 'switch' covers all branches.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64084/ --- (Updated Nov. 27, 2017, 2:07 p.m.) Review request for mesos and Alexander

Re: Review Request 64084: Made explicit that a 'switch' covers all branches.

2017-11-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64084/#review191883 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 27, 2017,

Re: Review Request 64000: Allowed stringification of hashmaps of stringifiable types.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64000/ --- (Updated Nov. 27, 2017, 4 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 63842: Allowed removing non-terminal offer operations.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/ --- (Updated Nov. 27, 2017, 4 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Review Request 64084: Made explicit that a 'switch' covers all branches.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64084/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 63953: Added logging based on container class.

2017-11-27 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/ --- (Updated Nov. 27, 2017, 2:16 p.m.) Review request for mesos and Alexander

Re: Review Request 63953: Added logging based on container class.

2017-11-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/#review191884 --- src/logging/utils.hpp Lines 17-18 (patched)

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

2017-11-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review191908 --- Fix it, then Ship it! src/slave/slave.cpp Lines 6895

Re: Review Request 63861: Windows: Updated networking doc.

2017-11-27 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/ --- (Updated Nov. 27, 2017, 5:38 p.m.) Review request for mesos, Andrew

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

2017-11-27 Thread Jiang Yan Xu
> On Nov. 21, 2017, 10:04 a.m., Alexander Rukletsov wrote: > > src/internal/devolve.cpp > > Lines 194-196 (original), 194-196 (patched) > > > > > > What about `evolve()`? I suppose I need to handle it there too

Re: Review Request 63999: Added env var to set default flags for parallel test runner.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63999/ --- (Updated Nov. 27, 2017, 4:44 p.m.) Review request for mesos and Alexander

Re: Review Request 64081: Fix a code snippet in libprocess documentation.

2017-11-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64081/#review191892 --- Ship it! Ship It! - Benjamin Hindman On Nov. 27, 2017,

Re: Review Request 64086: Removed currently unneeded 'AWAIT_READY's in 'MockResourceProvider'.

2017-11-27 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64086/#review191891 --- Ship it! Ship It! - Jan Schlicht On Nov. 27, 2017, 4:18

Re: Review Request 63999: Added env var to set default flags for parallel test runner.

2017-11-27 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63999/#review191898 --- Ship it! Ship It! - Armand Grillet On nov. 27, 2017, 3:44

Re: Review Request 63830: Fixed 'NoOffersWithAllRolesSuppressed' test.

2017-11-27 Thread Jiang Yan Xu
> On Nov. 21, 2017, 9:53 a.m., Alexander Rukletsov wrote: > > src/tests/scheduler_tests.cpp > > Lines 1515-1516 (original), 1534-1535 (patched) > > > > > > `.WillRepeatedly(Return());` There's only one agent with

Re: Review Request 64000: Allowed stringification of hashmaps of stringifiable types.

2017-11-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64000/#review191909 --- Ship it! Ship It! - Jie Yu On Nov. 27, 2017, 3 p.m.,

Re: Review Request 64000: Allowed stringification of hashmaps of stringifiable types.

2017-11-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64000/#review191910 --- include/mesos/type_utils.hpp Line 467 (original), 467 (patched)

Re: Review Request 63999: Added env var to set default flags for parallel test runner.

2017-11-27 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63999/#review191893 --- support/mesos-gtest-runner.py Lines 136 (patched)

Re: Review Request 63212: Added a findByTarget method for fs::MountInfoTable.

2017-11-27 Thread Jie Yu
> On Oct. 25, 2017, 9:26 p.m., James Peach wrote: > > src/linux/fs.hpp > > Lines 276 (patched) > > > > > > Not "immediate parent", but longest match right? It's more complicated than that. I think the goal is to

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

2017-11-27 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/ --- (Updated Nov. 27, 2017, 5:45 p.m.) Review request for mesos, Andrew

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

2017-11-27 Thread Akash Gupta
> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 121-124 (patched) > > > > > > Would it be possible to instead change the default network setting to

Re: Review Request 63860: Windows: Mapped the Docker network info types.

2017-11-27 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Nov. 27, 2017, 5:37 p.m.) Review request for mesos, Andrew

Re: Review Request 64081: Fixed a code snippet in libprocess documentation.

2017-11-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64081/ --- (Updated Nov. 27, 2017, 3:27 p.m.) Review request for mesos and Benjamin

Re: Review Request 64054: Refactored offer operation handling for speculative operations.

2017-11-27 Thread Benjamin Bannier
> On Nov. 26, 2017, 4:40 a.m., Jie Yu wrote: > > src/master/master.hpp > > Lines 2795-2841 (original) > > > > > > This should still be part of `addOfferOperation`. In fact, anything to > > do with `used` resourecs

Re: Review Request 63859: Windows: Fixed mock signal values in stout.

2017-11-27 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/ --- (Updated Nov. 27, 2017, 5:36 p.m.) Review request for mesos, Andrew

Review Request 64094: Added the `OfferOperationStatusUpdateRecord` protobuf message.

2017-11-27 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64094/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8197

Review Request 64093: Added operators for offer operation update protobuf classes.

2017-11-27 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64093/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8197

Re: Review Request 63732: Reconciled offer operations between agent and master.

2017-11-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/#review191911 --- src/master/master.cpp Lines 7119 (patched)

Re: Review Request 64000: Allowed stringification of hashmaps of stringifiable types.

2017-11-27 Thread Benjamin Bannier
> On Nov. 27, 2017, 7:24 p.m., Jie Yu wrote: > > include/mesos/type_utils.hpp > > Line 467 (original), 467 (patched) > > > > > > Do you also need to update v1/mesos.cpp? This makes me wonder whether we should just

Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-11-27 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8197

Review Request 64095: Added a generic actor to be used by status update managers.

2017-11-27 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8197

Review Request 63971: Defined a module interface for translating volume profiles.

2017-11-27 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/ --- Review request for mesos, Chun-Hung Hsiao and Jie Yu. Bugs: MESOS-8251

Re: Review Request 63212: Added a findByTarget method for fs::MountInfoTable.

2017-11-27 Thread Jie Yu
> On Oct. 25, 2017, 9:26 p.m., James Peach wrote: > > src/linux/fs.cpp > > Lines 257 (patched) > > > > > > Did you consider using a `Result` and returning `None()` in this case? I think not found is really not

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review191944 --- include/mesos/resource_provider/volume_profile.hpp Lines 28

Re: Review Request 64006: Moved registry operations into separate header.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64006/ --- (Updated Nov. 27, 2017, 11:29 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64007: Added infrastructure to support master capabilities.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64007/ --- (Updated Nov. 27, 2017, 11:29 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64009: Added new UpdateSlave registry operation.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/ --- (Updated Nov. 27, 2017, 11:29 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64010: Added an optional SlaveInfo parameter to Allocator::updateSlave().

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/ --- (Updated Nov. 27, 2017, 11:29 p.m.) Review request for mesos and Vinod Kone.

Review Request 64081: Fix a code snippet in libprocess documentation.

2017-11-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64081/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 64007: Added infrastructure to support master capabilities.

2017-11-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64007/#review191952 --- Ship it! Ship It! - Vinod Kone On Nov. 27, 2017, 11:29

Re: Review Request 63809: Windows: Fixed symlink code to not need admin privileges.

2017-11-27 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63809/#review191957 --- Ship it! Ship It! - Akash Gupta On Nov. 14, 2017, 11:14

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-11-27 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review191674 --- The approach looks good to me. src/master/http.cpp Line 320

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

2017-11-27 Thread Jiang Yan Xu
> On Nov. 21, 2017, 10:04 a.m., Alexander Rukletsov wrote: > > src/internal/devolve.cpp > > Lines 194-196 (original), 194-196 (patched) > > > > > > What about `evolve()`? > > Jiang Yan Xu wrote: > I suppose I

Re: Review Request 64010: Added an optional SlaveInfo parameter to Allocator::updateSlave().

2017-11-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review191955 --- include/mesos/allocator/allocator.hpp Lines 219 (patched)

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review191958 --- src/master/master.cpp Lines 6879 (patched)

Review Request 64101: Skip registry update if SlaveInfo didn't change.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64101/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 63831: Fixed a bug that removed the suppressed framework from sorter.

2017-11-27 Thread Jiang Yan Xu
> On Nov. 21, 2017, 10:27 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 430-437 (original), 431-438 (patched) > > > > > > Do we need a lambda here? I kept the original

Re: Review Request 64101: Skip registry update if SlaveInfo didn't change.

2017-11-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64101/#review191961 --- src/master/master.cpp Lines 6530-6536 (patched)

Re: Review Request 64101: Skip registry update if SlaveInfo didn't change.

2017-11-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64101/#review191963 --- src/master/master.cpp Lines 6530-6536 (patched)

Re: Review Request 64012: Added new --configuration_compatibility slave flag and implementation.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/ --- (Updated Nov. 28, 2017, 12:51 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 63060: Added utility functions and structures for CSI version and capabilities.

2017-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/ --- (Updated Nov. 28, 2017, 12:56 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-11-27 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 28, 2017, 12:56 a.m.) Review request for mesos, James Peach,

Review Request 64102: Renamed curl target to libcurl, and staging of curl.exe on Windows.

2017-11-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64102/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository:

Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

2017-11-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64104/ --- Review request for mesos. Bugs: MESOS-6709

Review Request 64103: Changed dependency of curl to libcurl for stout.

2017-11-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64103/ --- Review request for mesos. Repository: mesos Description --- Changed

Re: Review Request 64009: Added new UpdateSlave registry operation.

2017-11-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review191953 --- src/tests/registrar_tests.cpp Lines 270 (patched)

Re: Review Request 63212: Added a findByTarget method for fs::MountInfoTable.

2017-11-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63212/ --- (Updated Nov. 28, 2017, 12:28 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 64098: Send status updates when agent re-registers.

2017-11-27 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/ --- (Updated Nov. 28, 2017, 12:29 a.m.) Review request for mesos, James Peach and

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-11-27 Thread Joseph Wu
> On Nov. 27, 2017, 3:14 p.m., Chun-Hung Hsiao wrote: > > include/mesos/resource_provider/volume_profile.hpp > > Lines 28 (patched) > > > > > > Currently the CSI spec is internal (under `src/`). Do we want to expose

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Nov. 28, 2017, 12:28 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64009: Added new UpdateSlave registry operation.

2017-11-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review191960 --- src/master/registry_operations.cpp Lines 64-70 (patched)

Re: Review Request 64101: Skip registry update if SlaveInfo didn't change.

2017-11-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64101/#review191962 --- Write a test to ensure registry is not updated when there is no

Re: Review Request 63831: Fixed a bug that removed the suppressed framework from sorter.

2017-11-27 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63831/ --- (Updated Nov. 27, 2017, 4:45 p.m.) Review request for mesos and Alexander

Re: Review Request 63810: Windows: Added internal `fullpath` API to normalize paths.

2017-11-27 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63810/#review191967 --- Ship it! Ship It! - Akash Gupta On Nov. 14, 2017, 11:14

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64008/ --- (Updated Nov. 28, 2017, 12:48 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

2017-11-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64008/#review191966 --- Ship it! Ship It! - Vinod Kone On Nov. 28, 2017, 12:48

Re: Review Request 61157: Refactored ProcessManager::handle for future use with http::Server.

2017-11-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61157/#review191950 --- Ship it! Coming back to this change without context, it took

Re: Review Request 63385: Added utility functions for volume attributes and printing CSI messages.

2017-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63385/ --- (Updated Nov. 28, 2017, 12:57 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 63023: Added a test CSI plugin.

2017-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63023/ --- (Updated Nov. 28, 2017, 6 a.m.) Review request for mesos, James DeFelice, Jie

Re: Review Request 63022: Imported resources from CSI plugins in storage local resource provider.

2017-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/ --- (Updated Nov. 28, 2017, 5:59 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-11-27 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 27, 2017, 10:05 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-11-27 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 27, 2017, 10:08 p.m.) Review request for mesos, James Peach,

Re: Review Request 63018: Added filesystem layout for local resource providers.

2017-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63018/ --- (Updated Nov. 27, 2017, 10:14 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63997: Added a new allocator method to add resources to agents.

2017-11-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63997/#review191947 --- include/mesos/allocator/allocator.hpp Lines 220 (patched)

Re: Review Request 61473: Send status updates when agent re-registers.

2017-11-27 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 27, 2017, 10:02 p.m.) Review request for mesos, James Peach,

Re: Review Request 62636: Generated authentication tokens for local resource providers.

2017-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/ --- (Updated Nov. 27, 2017, 9:26 p.m.) Review request for mesos, Alexander Rojas,

Review Request 64098: Send status updates when agent re-registers.

2017-11-27 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/ --- Review request for mesos, James Peach and Jiang Yan Xu. Repository: mesos

Re: Review Request 63212: Added a findByTarget method for fs::MountInfoTable.

2017-11-27 Thread Jie Yu
> On Oct. 25, 2017, 9:26 p.m., James Peach wrote: > > src/linux/fs.cpp > > Lines 249 (patched) > > > > > > So if the target was "/mnt/foobar" and we had a mount called > > "/mnt/foo", this would match? Is that what

Re: Review Request 63212: Added a findByTarget method for fs::MountInfoTable.

2017-11-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63212/ --- (Updated Nov. 27, 2017, 11:18 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 64012: Added new --configuration_compatibility slave flag and implementation.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/ --- (Updated Nov. 27, 2017, 11:30 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Nov. 27, 2017, 11:30 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64008/ --- (Updated Nov. 27, 2017, 11:30 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64073: Fixed ignored Socket::accept discard when using LibeventSSLSocketImpl.

2017-11-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64073/#review191948 --- 3rdparty/libprocess/src/libevent_ssl_socket.cpp Line 958

Re: Review Request 64006: Moved registry operations into separate header.

2017-11-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64006/#review191951 --- Fix it, then Ship it! src/master/registry_operations.hpp

Re: Review Request 64068: Increased executor log verbosity in tests.

2017-11-27 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64068/#review191875 --- Ship it! Ship It! - Armand Grillet On Nov. 24, 2017, 7:12

Re: Review Request 64001: Made sure all true allocator agent updates return correct status.

2017-11-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64001/#review191876 --- Ship it! Please correct the commit message to omit mentioning

Re: Review Request 64001: Made sure all true allocator agent updates return correct status.

2017-11-27 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64001/#review191877 --- Ship it! Ship It! - Jan Schlicht On Nov. 24, 2017, 3:07

Re: Review Request 64001: Made sure all true allocator agent updates trigger allocations.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64001/ --- (Updated Nov. 27, 2017, 11:51 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 63022: Imported resources from CSI plugins in storage local resource provider.

2017-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/ --- (Updated Nov. 27, 2017, 9:32 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class.

2017-11-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63794/#review191873 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 17, 2017,

Re: Review Request 63796: Made `CheckerProcess` support IPv6 for HTTP/TCP check.

2017-11-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63796/#review191874 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 16, 2017,

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

2017-11-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191869 --- Ship it! src/checks/tcp_connect.cpp Lines 33-34 (patched)

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

2017-11-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191871 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines

Re: Review Request 64074: Added ENABLE_HTTP_SERVER option for cmake.

2017-11-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64074/#review191971 --- Fix it, then Ship it! Why just cmake?

  1   2   >