Re: Review Request 64659: Fixed unit tests for volume profile module integration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64659/#review194002 --- FAIL: Failed to apply the dependent review: 64658. Failed

Re: Review Request 64658: Modified SLRP to use the VolumeProfileAdaptor module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64658/ --- (Updated Dec. 16, 2017, 1:34 a.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 64466: Added a test to check shared resources accounting in quota enforcement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64466/#review194005 --- Ship it! Meng and I went over this patch together and made a

Re: Review Request 64465: Added a test for non-quota role reservation allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64465/#review194003 --- Fix it, then Ship it!

Re: Review Request 64636: Fixed a bug with quota headroom that can leave reservations unallocated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64636/#review193993 --- Fix it, then Ship it! Perhaps the required / available

Re: Review Request 64436: Toggled the authenticate_http_readwrite flag in MesosTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64436/ --- (Updated Dec. 16, 2017, 12:45 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 64436: Toggled the authenticate_http_readwrite flag in MesosTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64436/#review194004 --- PASS: Mesos patch 64436 was successfully built and tested.

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/#review193994 --- src/resource_provider/uri_volume_profile.cpp Lines 392-395

Re: Review Request 64354: Added tests for UriVolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64354/#review193995 --- Ship it! Ship It! - Jie Yu On Dec. 15, 2017, 7:29 p.m.,

Re: Review Request 64612: Added flag to pass VolumeProfileAdaptor module to SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64612/#review193997 --- src/resource_provider/local.cpp Lines 39 (patched)

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/#review193996 --- src/resource_provider/uri_volume_profile.hpp Lines 106 (patched)

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/#review193998 --- src/resource_provider/uri_volume_profile.hpp Lines 229 (patched)

Re: Review Request 64659: Fixed unit tests for volume profile module integration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64659/ --- (Updated Dec. 15, 2017, 11:56 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 64522: Made OfferOperationStatusUpdateManager tests pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64522/#review193999 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 15, 2017,

Re: Review Request 64522: Made OfferOperationStatusUpdateManager tests pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64522/#review194000 --- src/status_update_manager/status_update_manager_process.hpp

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/#review193892 --- src/resource_provider/uri_volume_profile.hpp Lines 81 (patched)

Re: Review Request 64650: Made resource provider driver start explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64650/#review193911 --- Ship it! Ship It! - Jan Schlicht On Dec. 15, 2017, 2:29

Review Request 64650: Made resource provider driver start explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64650/ --- Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.

Re: Review Request 64628: Updated GET_CONTAINERS API allowing nested/standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64628/#review193909 --- include/mesos/agent/agent.proto Line 349 (original), 355

Review Request 64648: Fixed handling of resource versions in agent oversubscribed updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64648/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 64648: Fixed handling of resource versions in agent oversubscribed updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64648/#review193912 --- FAIL: Some Mesos tests failed. Reviews applied: `['64648']`

Re: Review Request 64069: Ensured command executor always honors shutdown request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/ --- (Updated Dec. 15, 2017, 10:43 a.m.) Review request for mesos, Andrei Budnik,

Review Request 64647: Updated tests related to containerizer refactoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64647/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.

Review Request 64646: Unified return type of `wait`, `destroy`, `kill` containerizer methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64646/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.

Re: Review Request 64624: Added standalone isolator capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64624/#review193905 --- Ship it! LGTM! - Gilbert Song On Dec. 14, 2017, 12:19 p.m.,

Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64575/#review193896 --- src/slave/containerizer/mesos/containerizer.hpp Lines 358-359

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

> On Dec. 14, 2017, 9:40 p.m., Benjamin Mahler wrote: > > Can you link to some prior art? What do the RFCs say recommend, if > > anything? What do other http frameworks do? According to [RFC3986](https://tools.ietf.org/html/rfc3986#section-3.3), every '/' is meaningful, i.e., `/path` and

Re: Review Request 64647: Updated tests related to containerizer refactoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64647/#review193908 --- FAIL: Some Mesos tests failed. Reviews applied: `['64646',

Re: Review Request 64379: Improved logs displayed after a slave failed recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64379/#review193903 --- Ship it! Ship It! - Benno Evers On Dec. 13, 2017, 7:26

Review Request 64644: Refactored and fixed bugs for SLRP resource reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64644/ --- Review request for mesos, Jie Yu and Joseph Wu. Repository: mesos

Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64575/#review193893 --- Fix it, then Ship it!

Re: Review Request 64596: WIP: Added unit tests for storage local resource provider recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64596/#review193895 --- FAIL: Failed to apply the dependent review: 64644. Failed

Re: Review Request 63953: Added logging based on container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/#review193897 --- Fix it, then Ship it!

Re: Review Request 64623: Fixed a bug in handling standalone container recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64623/#review193894 --- Ship it! Ship It! - Gilbert Song On Dec. 14, 2017, 12:14

Re: Review Request 64648: Fixed handling of resource versions in agent oversubscribed updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64648/#review193932 --- Ship it! Ship It! - Jie Yu On Dec. 15, 2017, 1:15 p.m.,

Re: Review Request 64069: Ensured command executor always honors shutdown request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/#review193931 --- src/launcher/executor.cpp Lines 768 (patched)

Re: Review Request 64621: Fixed a corner case for pre-existing volumes created by old RPs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64621/ --- (Updated Dec. 15, 2017, 9:43 p.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 64591: Printed out the source profile and ID for a disk resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64591/ --- (Updated Dec. 15, 2017, 9:44 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 64638: Added VIEW_STANDALONE_CONTAINER ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64638/#review193980 --- Ship it! Ship It! - Greg Mann On Dec. 15, 2017, 4:55 p.m.,

Re: Review Request 64639: Supported getting all containers in the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64639/#review193965 --- Fix it, then Ship it! src/slave/http.cpp Lines 2327 (patched)

Re: Review Request 64628: Updated GET_CONTAINERS API allowing nested/standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64628/#review193981 --- Ship it! Ship It! - Greg Mann On Dec. 15, 2017, 4:54 p.m.,

Re: Review Request 64658: Modified SLRP to use the VolumeProfileAdaptor module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64658/ --- (Updated Dec. 15, 2017, 9:46 p.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 64653: Added doc for new fields in GET_CONTAINERS operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64653/#review193982 --- Ship it! Ship It! - Greg Mann On Dec. 15, 2017, 6:25 p.m.,

Re: Review Request 64654: Updated CHANGELOG about the change to GET_CONTAINERS API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64654/#review193983 --- Fix it, then Ship it! CHANGELOG Lines 20 (patched)

Re: Review Request 64639: Supported getting all containers in the agent API.

> On Dec. 15, 2017, 9:46 p.m., Greg Mann wrote: > > src/slave/http.cpp > > Lines 2275-2276 (original), 2380-2384 (patched) > > > > > > Nit: these fit on one line. The second one does not :( thus the change. -

Re: Review Request 64655: Updated upgrades.md about the GET_CONTAINERS API change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64655/#review193985 --- Fix it, then Ship it! docs/upgrades.md Lines 392 (patched)

Re: Review Request 64656: Added validation for VIEW_STANDALONE_CONTAINER ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64656/#review193986 --- Fix it, then Ship it! src/authorizer/local/authorizer.cpp

Re: Review Request 64657: Added tests for VIEW_STANDALONE_CONTAINER ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64657/#review193987 --- Fix it, then Ship it! src/tests/authorization_tests.cpp Lines

Re: Review Request 64650: Made resource provider driver start explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64650/#review193914 --- FAIL: Some Mesos tests failed. Reviews applied: `['64650']`

Re: Review Request 64628: Updated GET_CONTAINERS API allowing nested/standalone containers.

> On Dec. 15, 2017, 1:01 p.m., Gilbert Song wrote: > > include/mesos/agent/agent.proto > > Line 349 (original), 355 (patched) > > > > > > Missed `optional GetContainers get_containers = 20;` here? err... my

Re: Review Request 64628: Updated GET_CONTAINERS API allowing nested/standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64628/ --- (Updated Dec. 15, 2017, 4:54 p.m.) Review request for mesos, Gilbert Song,

Review Request 64655: Updated upgrades.md about the GET_CONTAINERS API change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64655/ --- Review request for mesos, Gilbert Song and Greg Mann. Repository: mesos

Review Request 64654: Updated CHANGELOG about the change to GET_CONTAINERS API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64654/ --- Review request for mesos, Gilbert Song and Greg Mann. Repository: mesos

Re: Review Request 64638: Added VIEW_STANDALONE_CONTAINER ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64638/ --- (Updated Dec. 15, 2017, 4:55 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 64639: Supported getting all containers in the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64639/ --- (Updated Dec. 15, 2017, 4:56 p.m.) Review request for mesos, Gilbert Song,

Review Request 64653: Added doc for new fields in GET_CONTAINERS operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64653/ --- Review request for mesos, Gilbert Song and Greg Mann. Repository: mesos

Re: Review Request 64639: Supported getting all containers in the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64639/#review193942 --- FAIL: Some Mesos tests failed. Reviews applied: `['64623',

Re: Review Request 64354: Added tests for UriVolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64354/ --- (Updated Dec. 15, 2017, 11:29 a.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 64657: Added tests for VIEW_STANDALONE_CONTAINER ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64657/ --- Review request for mesos, Gilbert Song and Greg Mann. Repository: mesos

Review Request 64656: Added validation for VIEW_STANDALONE_CONTAINER ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64656/ --- Review request for mesos, Gilbert Song and Greg Mann. Repository: mesos

Re: Review Request 64621: Fixed a corner case for pre-existing volumes created by old RPs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64621/#review193963 --- Fix it, then Ship it!

Review Request 64658: Modified SLRP to use the VolumeProfileAdaptor module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64658/ --- Review request for mesos, Jie Yu and Joseph Wu. Repository: mesos

Review Request 64659: Fixed unit tests for volume profile module integration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64659/ --- Review request for mesos, Jie Yu and Joseph Wu. Repository: mesos

Re: Review Request 64655: Updated upgrades.md about the GET_CONTAINERS API change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64655/#review193955 --- FAIL: Some Mesos tests failed. Reviews applied: `['64628',

Re: Review Request 64352: Added default VolumeProfile module implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64352/ --- (Updated Dec. 15, 2017, 11:28 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/ --- (Updated Dec. 15, 2017, 11:29 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 64591: Printed out the source profile and ID for a disk resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64591/#review193964 --- Fix it, then Ship it! src/v1/resources.cpp Lines 2124

Re: Review Request 64650: Made resource provider driver start explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64650/#review193933 --- Ship it! Ship It! - Jie Yu On Dec. 15, 2017, 1:29 p.m.,

Re: Review Request 64600: Fixed handling of resource provider updates without resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64600/#review193935 --- Ship it! Ship It! - Jie Yu On Dec. 14, 2017, 10:01 a.m.,

Re: Review Request 64522: WIP: try to make tests pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64522/#review193975 --- PASS: Mesos patch 64522 was successfully built and tested.

Re: Review Request 64522: Made OfferOperationStatusUpdateManager tests pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64522/ --- (Updated Dec. 15, 2017, 1:25 p.m.) Review request for mesos, Andrew

Re: Review Request 64644: Refactored and fixed bugs for SLRP resource reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64644/#review193968 --- Fix it, then Ship it! Please also add some more comments about

Re: Review Request 64644: Refactored and fixed bugs for SLRP resource reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64644/ --- (Updated Dec. 15, 2017, 8:21 p.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 64644: Refactored and fixed bugs for SLRP resource reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64644/#review193967 --- src/resource_provider/storage/provider.cpp Lines 1072 (patched)

Re: Review Request 64657: Added tests for VIEW_STANDALONE_CONTAINER ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64657/#review193969 --- FAIL: Some Mesos tests failed. Reviews applied: `['64628',

Re: Review Request 64659: Fixed unit tests for volume profile module integration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64659/#review193970 --- FAIL: Failed to apply the dependent review: 64658. Failed

Re: Review Request 64352: Added default VolumeProfile module implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64352/#review193989 --- Ship it! Ship It! - Jie Yu On Dec. 15, 2017, 7:28 p.m.,

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/ --- (Updated Dec. 15, 2017, 2:49 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/#review193991 --- src/resource_provider/uri_volume_profile.hpp Lines 105 (patched)