Re: Review Request 65113: Added Developer Guide to documentation.

> On Jan. 16, 2018, 10:08 a.m., Greg Mann wrote: > > docs/developer-guide.md > > Lines 33-34 (patched) > > > > > > Since this is contained in the preceding paragraph, this line can > > probably be removed? Thanks!

Re: Review Request 65113: Added Developer Guide to documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65113/ --- (Updated Jan. 16, 2018, 12:18 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65114: Updated C++ Style Guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65114/ --- (Updated Jan. 16, 2018, 12:18 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64857: Updated example frameworks for mesos-local.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64857/#review195518 --- src/examples/dynamic_reservation_framework.cpp Lines 389

Re: Review Request 65059: Speeded up SLRP unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65059/#review195519 --- Ship it! Ship It! - Greg Mann On Jan. 10, 2018, 2:32 a.m.,

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 17, 2018, 12:08 a.m.) Review request for mesos, Alexander

Re: Review Request 65150: Added support for discarding a Future from Queue::get.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65150/ --- (Updated Jan. 16, 2018, 9:40 p.m.) Review request for mesos and Benjamin

Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65182/#review195502 --- FAIL: Failed to apply the dependent review: 64994. Failed

Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65183/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 65114: Updated C++ Style Guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65114/#review195506 --- PASS: Mesos patch 65114 was successfully built and tested.

Re: Review Request 65113: Added Developer Guide to documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65113/#review195507 --- Ship it! Ship It! - Greg Mann On Jan. 16, 2018, 8:18 p.m.,

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/#review195516 --- Ship it! Ship It! - Chun-Hung Hsiao On Jan. 9, 2018, 9:25

Re: Review Request 64994: Renamed SLRP tests to describe them better.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64994/#review195517 --- Ship it! Ship It! - Greg Mann On Jan. 5, 2018, 10:05 p.m.,

Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65182/ --- Review request for mesos. Repository: mesos Description --- This patch

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65147/ --- (Updated Jan. 16, 2018, 1:26 p.m.) Review request for mesos, Akash Gupta,

Review Request 65184: Added missing registry-related flags to the master config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65184/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 65184: Added missing registry-related flags to the master config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65184/#review195514 --- Ship it! Ship It! - Vinod Kone On Jan. 16, 2018, 11:16

Re: Review Request 64992: Added SLRP unit tests for profile updates and corner cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64992/ --- (Updated Jan. 16, 2018, 11:20 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65147/#review195501 --- FAIL: Some Mesos tests failed. Reviews applied: `['65144',

Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65182/#review195523 --- PASS: Mesos patch 65182 was successfully built and tested.

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review195510 --- src/checks/checker_process.cpp Lines 990-1004 (patched)

Re: Review Request 64849: Added authentication to some example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64849/#review195515 --- src/examples/dynamic_reservation_framework.cpp Line 41

Re: Review Request 65184: Added missing registry-related flags to the master config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65184/#review195521 --- PASS: Mesos patch 65184 was successfully built and tested.

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Jan. 17, 2018, 12:09 a.m.) Review request for mesos, Alexander

Re: Review Request 64386: Refactored health checks to take in executor information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64386/ --- (Updated Jan. 16, 2018, 8:37 a.m.) Review request for mesos, Alexander

Re: Review Request 65126: Added a resource provider test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65126/ --- (Updated Jan. 16, 2018, 12:04 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65126: Added a resource provider test case.

> On Jan. 15, 2018, 10:57 a.m., Benjamin Bannier wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 1345 (patched) > > > > > > This does look more like an agent integration test to me; maybe move it

Re: Review Request 65126: Added a resource provider test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65126/#review195446 --- PASS: Mesos patch 65126 was successfully built and tested.

Re: Review Request 64515: Used `reserve_resources` ACL for static reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64515/#review195458 --- Ship it! Ship It! - James Peach On Jan. 10, 2018, 10:22

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Jan. 16, 2018, 4:41 p.m.) Review request for mesos, Alexander

Re: Review Request 63859: Windows: Fixed mock signal values in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/ --- (Updated Jan. 16, 2018, 4:54 p.m.) Review request for mesos, Andrew

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 16, 2018, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 64516: Improved documentation on resource reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64516/#review195459 --- Ship it! Ship It! - James Peach On Jan. 10, 2018, 10:23

Re: Review Request 65045: Tested correct operation handling during master failover.

> On Jan. 15, 2018, 11:34 a.m., Benjamin Bannier wrote: > > src/tests/master_tests.cpp > > Lines 8667 (patched) > > > > > > This requires `process/ssl/flags.hpp` to compile with SSL enabled. As the code is now

Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/#review195462 --- Fix it, then Ship it! src/slave/slave.hpp Lines 837-838

Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.

> On Jan. 12, 2018, 4:59 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Failed to apply the current review. > > > > Failed command: `python.exe .\support\apply-reviews.py -n -r 65116` > > > > All the build artifacts available at: > >

Re: Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65070/#review195465 --- Ship it! Nice test! - Vinod Kone On Jan. 16, 2018, 3:33

Re: Review Request 65167: Detached `virtualLatestPath` when recovering the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65167/#review195466 --- Ship it! Ship It! - Vinod Kone On Jan. 15, 2018, 1:49 p.m.,

Review Request 65179: Fixed flaky EOFBeforeRecv test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65179/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, and Joseph Wu. Bugs:

Re: Review Request 65114: Updated C++ Style Guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65114/#review195473 --- Fix it, then Ship it! docs/c++-style-guide.md Lines 92

Re: Review Request 65167: Detached `virtualLatestPath` when recovering the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65167/#review195467 --- Ship it! Ship It! - Zhitao Li On Jan. 15, 2018, 1:49 p.m.,

Re: Review Request 65113: Added Developer Guide to documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65113/#review195461 --- Thanks Andy, this is great! A few small comments below. Let's get

Re: Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65070/ --- (Updated Jan. 16, 2018, 11:33 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

> On Jan. 9, 2018, 8:04 a.m., Vinod Kone wrote: > > Can you add a test or update an existing test to verify the /files endpoint > > for task volume? Ideally, you could also verify that once the executor's > > work directory is gc'ed the files endpoint no longer serves the task volume > >

Re: Review Request 64848: Updated example frameworks to make use of added flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64848/#review195513 --- Love the cleanup! Thanks for doing this.

Re: Review Request 65109: Fixed a bug relating to lingering executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65109/ --- (Updated Jan. 16, 2018, 10:14 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64969: Added an performance benchmark for master `Getstate` v1 api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64969/#review195526 --- Fix it, then Ship it! s/Getstate/GetState/ in the summary

Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/ --- (Updated Jan. 17, 2018, 9:38 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65156: Detached the virtual paths regardless of the result of gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65156/ --- (Updated Jan. 17, 2018, 9:37 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64998: Added a SLRP test for CSI plugin restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64998/#review195525 --- Nice test!! src/slave/container_daemon_process.hpp Lines 26-27

Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

> On Jan. 17, 2018, 1:24 a.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Line 5911 (original) > > > > > > this should have been in the previous review. Fixed. - Qian

Re: Review Request 64969: Added an performance benchmark for master `Getstate` v1 api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64969/ --- (Updated Jan. 17, 2018, 1:29 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65114: Updated C++ Style Guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65114/#review195529 --- docs/c++-style-guide.md Lines 92 (patched)

Re: Review Request 65111: Added tests to verify the executor is shutdown if no task is delivered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65111/#review195535 --- PASS: Mesos patch 65111 was successfully built and tested.

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Jan. 16, 2018, 2:45 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65070/ --- (Updated Jan. 16, 2018, 10:28 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65144: Ported `os::which` to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65144/#review195475 --- Ship it! Ship It! - Jie Yu On Jan. 14, 2018, 2:01 a.m.,

Re: Review Request 65145: Fixed use of `os::which`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65145/#review195476 --- Ship it! Ship It! - Jie Yu On Jan. 14, 2018, 2 a.m., Andrew

Re: Review Request 65179: Fixed flaky EOFBeforeRecv test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65179/#review195482 --- PASS: Mesos patch 65179 was successfully built and tested.

Review Request 65180: Removed a comment in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65180/ --- Review request for mesos, Alexander Rukletsov and Kevin Klues. Repository:

Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65116/#review195488 --- Sorry for jumping so late into the party :(. I wanted to point

Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.

> On Jan. 12, 2018, 4:59 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Failed to apply the current review. > > > > Failed command: `python.exe .\support\apply-reviews.py -n -r 65116` > > > > All the build artifacts available at: > >

Re: Review Request 65144: Ported `os::which` to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65144/#review195480 --- 3rdparty/stout/include/stout/os/windows/which.hpp Lines 53-56

Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65116/#review195474 --- Awesome, thanks Senthil!! Some style comments below.

Re: Review Request 65122: Fixed race condition in io switchboard for ATTACH_CONTAINER_INPUT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65122/#review195483 --- Fix it, then Ship it!

Re: Review Request 65144: Ported `os::which` to Windows.

> On Jan. 16, 2018, 10:58 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/which.hpp > > Lines 53-56 (patched) > > > > > > I think the reason for allowing the caller to specify the extension is > >

Re: Review Request 65144: Ported `os::which` to Windows.

> On Jan. 16, 2018, 10:58 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/which.hpp > > Lines 53-56 (patched) > > > > > > I think the reason for allowing the caller to specify the extension is > >

Re: Review Request 65180: Removed a comment in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65180/#review195486 --- src/slave/containerizer/mesos/io/switchboard.cpp Lines 666-669

Re: Review Request 65145: Fixed use of `os::which`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65145/#review195489 --- Ship it! Ship It! - Joseph Wu On Jan. 13, 2018, 6 p.m.,

Re: Review Request 65180: Removed a comment in io switchboard.

> On Jan. 16, 2018, 7:24 p.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 666-669 (original) > > > > > > Does 4069e1c424 address making sure the IO-Switchboard allows > >

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65147/#review195492 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.

> On Jan. 16, 2018, 7:30 p.m., Kapil Arya wrote: > > Sorry for jumping so late into the party :(. > > > > I wanted to point out a better procedure to install Mesos packages. It's > > listed in the email I sent out earlier to the dev@ mailing list > >

Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.

> On Jan. 16, 2018, 2:30 p.m., Kapil Arya wrote: > > Sorry for jumping so late into the party :(. > > > > I wanted to point out a better procedure to install Mesos packages. It's > > listed in the email I sent out earlier to the dev@ mailing list > >

Re: Review Request 65180: Removed a comment in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65180/#review195497 --- PASS: Mesos patch 65180 was successfully built and tested.

Re: Review Request 65112: Added documentation about standalone containers.

> On Jan. 11, 2018, 5:59 p.m., Jie Yu wrote: > > docs/standalone-containers.md > > Lines 157 (patched) > > > > > > I don't think `REMOVE` is supported for standalone container for now. > > > > Also, if the

Re: Review Request 65144: Ported `os::which` to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65144/ --- (Updated Jan. 16, 2018, 12:05 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65147/ --- (Updated Jan. 16, 2018, 12:05 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 65144: Ported `os::which` to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65144/#review195498 --- Ship it! Ship It! - Joseph Wu On Jan. 16, 2018, 12:05 p.m.,