Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 22, 2018, 8:51 p.m., Gaston Kleiman wrote: > > src/tests/api_tests.cpp > > Lines 1011-1013 (patched) > > > > > > This doesn't seem to be necessary in most other tests, why exaclty do > > we need it here?

Re: Review Request 65197: Added some missing email addresses to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65197/#review195993 --- PASS: Mesos patch 65197 was successfully built and tested.

Re: Review Request 65197: Added some missing email addresses to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65197/#review195994 --- Ship it! Ship It! - Armand Grillet On Jan. 22, 2018, 8:45

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 22, 2018, 8:51 p.m., Gaston Kleiman wrote: > > src/tests/api_tests.cpp > > Lines 1011-1013 (patched) > > > > > > This doesn't seem to be necessary in most other tests, why exaclty do > > we need it here?

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 22, 2018, 7:37 p.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Lines 1011 (patched) > > > > > > Let's mention here that this is 5s. Solved this otherwise, no longer changing the allocation

Re: Review Request 62861: Updated list of excluded files by Python linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62861/#review195988 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 23, 2018, 1:14 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65306/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-6822

Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65306/#review196093 --- Looks like this is related to

Re: Review Request 64062: Added 6 nested container tests for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64062/#review196098 --- src/tests/containerizer/docker_volume_isolator_tests.cpp Lines

Re: Review Request 65278: Fixed a race in the test `ROOT_MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65278/ --- (Updated Jan. 24, 2018, 2:23 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 65278: Fixed a race in the test `ROOT_MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65278/#review196102 --- FAIL: Mesos tests failed to build. Reviews applied: `['65278']`

Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65305/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Joseph Wu.

Re: Review Request 65278: Fixed a race in the test `ROOT_MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65278/#review196097 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp

Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65305/#review196090 --- FAIL: Mesos tests failed to build. Reviews applied: `['65305']`

Re: Review Request 65278: Fixed a race in the test `ROOT_MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65278/#review196094 --- FAIL: Mesos tests failed to build. Reviews applied: `['65278']`

Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65306/#review196091 --- FAIL: Mesos tests failed to build. Reviews applied: `['65306']`

Re: Review Request 65301: Fixed resource statistics for Docker containers being destroyed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65301/#review196086 --- Ship it! Ship It! - Jie Yu On Jan. 23, 2018, 11:29 p.m.,

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/#review196087 --- Fix it, then Ship it! Approach looks good to me! A couple of

Re: Review Request 65278: Fixed a race in the test `ROOT_MultiTaskgroupSharePidNamespace`.

> On Jan. 24, 2018, 3:31 a.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 1854-1855 (patched) > > > > > > I'd change the condition to: > > > > ``` > >

Re: Review Request 65278: Fixed a race in the test `ROOT_MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65278/ --- (Updated Jan. 24, 2018, 10:09 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 64062: Added 6 nested container tests for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64062/#review196099 --- FAIL: Mesos tests failed to build. Reviews applied: `['64062']`

Re: Review Request 65280: Fixed make clean without Python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65280/#review196041 --- PASS: Mesos patch 65280 was successfully built and tested.

Re: Review Request 65215: Updated mesos-tidy setup for upgraded Boost version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65215/#review196042 --- FAIL: Failed to apply the dependent review: 62161. Failed

Review Request 65294: Add revocable resources support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65294/ --- Review request for mesos and Jason Lai. Bugs: MESOS-8471

Re: Review Request 65294: Add revocable resources support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65294/#review196053 --- PASS: Mesos patch 65294 was successfully built and tested.

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review196057 --- src/checks/checker_process.cpp Lines 887-888 (original)

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review196055 --- src/tests/health_check_tests.cpp Lines 109 (patched)

Re: Review Request 65245: Renamed `LOG` by `Stream logs` in Web UI.

> On Jan. 22, 2018, 7:33 p.m., Vinod Kone wrote: > > src/webui/master/static/agent.html > > Line 45 (original), 45 (patched) > > > > > > Hmm. This is inconsistent with how we did the stream vs download for > >

Re: Review Request 62447: Reverted usage of `-isystem` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/#review196005 --- Sorry for not coming back to this review earlier, and thanks for

Re: Review Request 64386: Refactored health checks to take in executor information.

> On Jan. 22, 2018, 1:27 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.hpp > > Lines 40-47 (patched) > > > > > > What meaning do you put in the difference between `UCR` and `MESOS`? > > For me, the

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196061 --- src/tests/api_tests.cpp Lines 6376-6379 (patched)

Re: Review Request 63422: Added os::eraseenv to clear the old environment value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63422/#review196070 --- Ship it! Ship It! - Greg Mann On Jan. 10, 2018, 10:08 p.m.,

Re: Review Request 63423: Cleared the executor auth token after using it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63423/#review196071 --- Ship it! Ship It! - Greg Mann On Jan. 10, 2018, 4:37 p.m.,

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65261/#review196009 --- Great idea, Andrei: clever yet clear and clean. We can ship this

Re: Review Request 65277: Logged pid of launched containers in the linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65277/#review196015 --- PASS: Mesos patch 65277 was successfully built and tested.

Re: Review Request 65127: Windows: Enabled docker health checks.

> On Jan. 22, 2018, 9:55 p.m., Joseph Wu wrote: > > src/checks/checker_process.cpp > > Lines 479-481 (original), 479-487 (patched) > > > > > > This is a bit unexpected. Considering that these arguments will be > >

Re: Review Request 65278: Fixed a race in the test `ROOT_MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65278/#review196007 --- PASS: Mesos patch 65278 was successfully built and tested.

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

> On Jan. 23, 2018, 3:12 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 842-843 (original), 845-852 (patched) > > > > > > If you add an override for

Re: Review Request 65255: Updated inverse-offers-framework with authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65255/#review196002 --- PASS: Mesos patch 65255 was successfully built and tested.

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196082 --- FAIL: Mesos tests failed to build. Reviews applied: `['65300',

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

> On Jan. 23, 2018, 3:12 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 842-843 (original), 845-852 (patched) > > > > > > If you add an override for

Review Request 65298: Split test flags into header and source files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65298/ --- Review request for mesos, Benjamin Bannier and Gaston Kleiman. Bugs:

Re: Review Request 65202: Adopted the libprocess `DEFAULT_TEST_TIMEOUT`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review196079 --- FAIL: Some Mesos tests failed. Reviews applied: `['65201',

Review Request 65301: Fixed resource statistics for Docker containers being destroyed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65301/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

> On Jan. 22, 2018, 9:08 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/Makefile.am > > Lines 200 (patched) > > > > > > I don't really like adding this testing tool to `libprocess`. Could you > > introduce

Review Request 65300: Added master metrics for operation status acknowledgments handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65300/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8184

Re: Review Request 65301: Fixed resource statistics for Docker containers being destroyed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65301/#review196084 --- FAIL: Mesos tests failed to build. Reviews applied: `['65301']`