Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review200661 --- src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp Lines 143

Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66461/#review200669 --- src/internal/evolve.hpp Lines 120 (patched)

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review200670 --- include/mesos/v1/scheduler.hpp Line 50 (original), 54-55

Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`.

> On April 5, 2018, 4:52 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/os/windows/write.hpp > > Lines 35 (patched) > > > > > > Same comment as previous read.hpp: > > > > Do you know why the

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 6, 2018, 1:24 p.m., Greg Mann wrote: > > src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp > > Lines 143 (patched) > > > > > > What do you think about using `LOG(FATAL)` here instead of > >

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- (Updated April 6, 2018, 1:59 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 6, 2018, 2:13 p.m., Vinod Kone wrote: > > include/mesos/v1/scheduler.hpp > > Line 50 (original), 54-55 (patched) > > > > > > Since we don't guarantee backwards compat for this library, can we just > >

Re: Review Request 66165: Re-fixed many master allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66165/#review200664 --- Ship it! Ship It! - Alexander Rukletsov On March 20, 2018,

Re: Review Request 66164: Added to a comment in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66164/ --- (Updated April 6, 2018, 6:09 p.m.) Review request for mesos, Alexander

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- (Updated April 6, 2018, 2:17 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/ --- (Updated April 6, 2018, 3:52 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66428/ --- (Updated April 6, 2018, 3:53 p.m.) Review request for mesos, Akash Gupta, Eric

Review Request 66489: Cleaned up internal evolve functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66489/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66461/ --- (Updated April 6, 2018, 5:16 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/ --- (Updated April 6, 2018, 4:15 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66440/ --- (Updated April 6, 2018, 4:17 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66445/ --- (Updated April 6, 2018, 4:18 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/ --- (Updated April 6, 2018, 4:11 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 65819: Enforced quota limit in the first resource allocation stage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65819/ --- (Updated April 6, 2018, 5:42 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66432/ --- (Updated April 6, 2018, 4:14 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/#review200685 --- 3rdparty/stout/include/stout/os/read.hpp Lines 117-127 (patched)

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

> On April 4, 2018, 2:49 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/windows/close.hpp > > Lines 38 (patched) > > > > > > Note that this will cause an SEH exception for `FsTest.Close` when

Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66439/ --- (Updated April 6, 2018, 4:16 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66445/#review200688 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

> On April 6, 2018, 2:01 p.m., Greg Mann wrote: > > src/internal/evolve.hpp > > Lines 120 (patched) > > > > > > Is the `mesos::` necessary in the type of the response argument here? > > Ditto in the implementation.

Re: Review Request 66463: Added a master metric for operations reconciliation messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66463/#review200673 --- Ship it! Ship It! - Greg Mann On April 4, 2018, 11:59 p.m.,

Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `FileEndOfFileInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66455/ --- (Updated April 6, 2018, 4:09 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200627 --- Patch looks great! Reviews applied: [66481] Passed command:

Re: Review Request 66474: Updated minimum supported Linux kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66474/#review200632 --- Ship it! Ship It! - Alexander Rukletsov On April 5, 2018,

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review200635 --- Please also call out this feature in the CHANGELOG. - Alexander

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review200634 --- Fix it, then Ship it! src/python/lib/tox.ini Lines 19

Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200631 --- Ship it! Ship It! - Alexander Rukletsov On April 3, 2018,

Re: Review Request 66165: Re-fixed many master allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66165/#review200644 --- PASS: Mesos patch 66165 was successfully built and tested.

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200650 --- src/resource_provider/manager.cpp Lines 261-263 (patched)

Re: Review Request 66454: Updated the documented release schedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66454/#review200654 --- Ship it! Ship It! - Jie Yu On April 4, 2018, 6:48 p.m.,

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review200633 --- 3rdparty/libprocess/Makefile.am Lines 208 (patched)

Re: Review Request 66165: Re-fixed many master allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66165/#review200651 --- Patch looks great! Reviews applied: [66164, 66165] Passed

Re: Review Request 66459: Fixed bug in `Master::updateSlave()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66459/#review200658 --- Ship it! Ship It! - Greg Mann On April 4, 2018, 11:49 p.m.,

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

> On April 5, 2018, 4:51 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/os/windows/read.hpp > > Lines 43 (patched) > > > > > > Do you know why the return value is `ssize_t` instead of a > > `Try`. Is it