Review Request 66657: Updated Config initialization for new CLI if file does not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66657/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8779

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66652/#review201294 --- PASS: Mesos patch 66652 was successfully built and tested.

Re: Review Request 66635: Fixed potential races when interacting with cgroup subsystem isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/#review201302 --- FAIL: Failed to get dependent review IDs for the current patch.

Re: Review Request 66635: Fixed potential races when interacting with cgroup subsystem isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/#review201309 --- PASS: Mesos patch 66635 was successfully built and tested.

Re: Review Request 66657: Updated Config initialization for new CLI if file does not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66657/#review201308 --- PASS: Mesos patch 66657 was successfully built and tested.

Re: Review Request 66643: WIP: Attribute filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66643/#review201301 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 66666: Added MemoryProfiler to CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 66670: Ensured that `wait()` and `destroy()` return the same result. (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66670/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian

Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian

Review Request 66669: Added clean up of `containers_` map in composing containerizer. (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian

Review Request 66671: Updated composing containerizer tests. (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/ --- (Updated April 17, 2018, 10 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 12, 2018, 5:33 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 4986-4994 (patched) > > > > > > What will happen if these operations are sent to a 1.5 agent which has > > the RESOURCE_PROVIDER

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 17, 2018, 9:58 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66608: Improved support for move-only types in `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/#review201319 --- PASS: Mesos patch 66608 was successfully built and tested.

Re: Review Request 66608: Improved support for move-only types in `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/ --- (Updated April 17, 2018, 4:35 p.m.) Review request for mesos, Alexander

Re: Review Request 66608: Improved support for move-only types in `hashmap`.

> On April 16, 2018, 6:56 p.m., Alexander Rukletsov wrote: > > 3rdparty/stout/include/stout/hashmap.hpp > > Line 104 (original), 104 (patched) > > > > > > Reading > >

Re: Review Request 66648: Marked the resource provider API as experimental.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66648/#review201313 --- Patch looks great! Reviews applied: [66398, 66407, 66408, 66409,

Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 66577: Enabled CSI proto compilation by default.

> On April 17, 2018, 6:19 p.m., Benno Evers wrote: > > src/Makefile.am > > Line 2378 (original), 2369 (patched) > > > > > > Will this library also get built when using `cmake`? Please see

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/ --- (Updated April 17, 2018, 8:13 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/ --- (Updated April 17, 2018, 8:22 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201342 --- src/master/master.cpp Lines 4525 (patched)

Re: Review Request 66648: Marked the resource provider API as experimental.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66648/ --- (Updated April 17, 2018, 7:22 p.m.) Review request for mesos, Benjamin

Re: Review Request 66616: Marked volume/block creation and destroy operations as experimental.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66616/ --- (Updated April 17, 2018, 7:20 p.m.) Review request for mesos, Benjamin

Re: Review Request 66671: Updated composing containerizer tests. (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/#review201327 --- PASS: Mesos patch 66671 was successfully built and tested.

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66652/#review201329 --- Patch looks great! Reviews applied: [66559, 66650, 66651, 66561,

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 13, 2018, 9:43 a.m., Greg Mann wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 455-459 (patched) > > > > > > Is this enforced somewhere in validation code? Can we check for > > expected

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On April 12, 2018, 5:27 p.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > > > > > Hmm I wonder if we should just use a `double` here? Does the > > `Value.Scalar` type provide some

Re: Review Request 66052: Added new operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66052/ --- (Updated April 17, 2018, 11:36 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/ --- (Updated April 17, 2018, 11:37 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66577: Enabled CSI proto compilation by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66577/#review201340 --- Fix it, then Ship it! src/Makefile.am Line 2378 (original),

Re: Review Request 66648: Marked the resource provider API as experimental.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66648/#review201331 --- include/mesos/resource_provider/resource_provider.proto Lines 27

Re: Review Request 66531: Added new authorization for `UpdateVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66531/#review201357 --- src/master/master.hpp Lines 877 (patched)

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201355 --- src/tests/persistent_volume_tests.cpp Lines 474-475 (patched)

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/ --- (Updated April 17, 2018, 3:53 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66052: Added new operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66052/#review201356 --- Fix it, then Ship it! include/mesos/master/master.proto Lines

Re: Review Request 66531: Added new authorization for `UpdateVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66531/#review201361 --- src/master/master.cpp Lines 3816-3819 (patched)

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review201362 --- src/tests/authorization_tests.cpp Line 1979 (original), 1979

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201346 --- src/master/master.cpp Lines 4519-4522 (original), 4543-4546

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/#review201344 --- PASS: Mesos patch 66649 was successfully built and tested.

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 17, 2018, 12:04 p.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 4525 (patched) > > > > > > I'm not sure about this. Would `REASON_TASK_INVALID` be more > > appropriate? I honest don't

Re: Review Request 66648: Marked the resource provider API as experimental.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66648/#review201349 --- PASS: Mesos patch 66648 was successfully built and tested.

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201351 --- Fix it, then Ship it! src/master/master.cpp Lines 4510

Re: Review Request 66650: Removed an invalid TODO in puller.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66650/#review201368 --- Mind to explain why this TODO is invalid in the description? :-)

Re: Review Request 66648: Marked the resource provider API as experimental.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66648/#review201369 --- Ship it! Ship It! - Gilbert Song On April 17, 2018, 12:22

Re: Review Request 66608: Improved support for move-only types in `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/#review201370 --- Patch looks great! Reviews applied: [66608] Passed command:

Re: Review Request 66679: Made the master send operation status updates when dropping operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66679/#review201374 --- PASS: Mesos patch 66679 was successfully built and tested.

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review201364 --- src/tests/authorization_tests.cpp Lines 2155 (patched)

Re: Review Request 66559: Made agent flag '--hadoop_home' as optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66559/#review201367 --- Ship it! Ship It! - Qian Zhang On April 17, 2018, 1:32

Re: Review Request 66657: Updated Config initialization for new CLI if file does not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66657/#review201363 --- Patch looks great! Reviews applied: [66657] Passed command:

Review Request 66679: Made the master send operation status updates when dropping operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66679/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8781

Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66227/#review201366 --- src/tests/api_tests.cpp Lines 3688 (patched)

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/#review201377 --- src/slave/slave.hpp Line 815 (original), 819 (patched)

Re: Review Request 66671: Updated composing containerizer tests. (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/#review201382 --- Patch looks great! Reviews applied: [8, 9, 66670, 66671]

Re: Review Request 63366: Added jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/ --- (Updated April 18, 2018, 4:15 a.m.) Review request for mesos, Alexander

Re: Review Request 63366: Added jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/#review201380 --- Fix it, then Ship it! I'll fix the issues and commit shortly.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review201381 --- Ship it! I will commit this now, fixing outstanding typos and

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review201384 --- Fix it, then Ship it! src/slave/main.cpp Lines 369 (patched)

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/ --- (Updated April 18, 2018, 4:15 a.m.) Review request for mesos and Alexander

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated April 18, 2018, 4:15 a.m.) Review request for mesos, Alexander

Re: Review Request 63366: Added jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/ --- (Updated April 18, 2018, 4:15 a.m.) Review request for mesos, Alexander