----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review201381 -----------------------------------------------------------
Ship it! I will commit this now, fixing outstanding typos and style issues. I will also refactor `DiskArtifact` to be more aligned with the single version of the artifact and refactor some functions to minimize taking `Try<>`s as parameters. I think we can come up with even cleaner implementation. - Alexander Rukletsov On April 18, 2018, 4:15 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63368/ > ----------------------------------------------------------- > > (Updated April 18, 2018, 4:15 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Bugs: MESOS-7944 > https://issues.apache.org/jira/browse/MESOS-7944 > > > Repository: mesos > > > Description > ------- > > This class exposes profiling functionality of jemalloc > memory allocator when it is detected to be the memory > allocator of the current process. > > In particular, it enables developers to access live > statistics of current memory usage, and to create > heap profiles that show where most memory is allocated. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c895d3ac7b9cc5ffd6c8b57ff24def866eb0213d > 3rdparty/libprocess/include/process/process.hpp > c36df991b6a2c120ab0562e8ff907f9fbf8630d1 > 3rdparty/libprocess/src/CMakeLists.txt > 0ce7dac5deea94623530820d173ce3ffe5b42ea4 > 3rdparty/libprocess/src/memory_profiler.hpp PRE-CREATION > 3rdparty/libprocess/src/memory_profiler.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 9eb37465cd86f408d69f5f98fb76c4f4b93b9acd > > > Diff: https://reviews.apache.org/r/63368/diff/12/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
