Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-06-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review204313 --- 3rdparty/libprocess/include/process/http.hpp Line 701

Review Request 67454: Fixed failing ArchiverTest due to long filename.

2018-06-05 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67454/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao,

Re: Review Request 67454: Fixed failing ArchiverTest due to long filename.

2018-06-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67454/#review204341 --- Ship it! Ship It! - Joseph Wu On June 5, 2018, 12:09 p.m.,

Re: Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`.

2018-06-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67385/#review204284 --- 3rdparty/stout/include/stout/os/windows/fd.hpp Lines 181

Review Request 67456: Windows: Wrapped docker executor code in job object.

2018-06-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67456/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Bugs: MESOS-7342

Review Request 67455: Windows: Fixed incorrect return code for `os:kill`.

2018-06-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67455/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Bugs: MESOS-8666

Re: Review Request 67454: Fixed failing ArchiverTest due to long filename.

2018-06-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67454/#review204343 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Bugs: MESOS-7342

Re: Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`.

2018-06-05 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67385/#review204345 --- 3rdparty/stout/include/stout/os/windows/fd.hpp Lines 181

Review Request 67463: Fixed type error when using `check_output` in Python 3 scripts.

2018-06-05 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67463/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-8979

Review Request 67464: Fixed `python3/mesos-style.py`.

2018-06-05 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67464/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Review Request 67465: Windows: Log a fatal error if `WindowsFD(int)` is incorrectly used.

2018-06-05 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67465/ --- Review request for mesos, Akash Gupta and Joseph Wu. Repository: mesos

Re: Review Request 67389: Windows: Implemented Windows IOCP async backend.

2018-06-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67389/#review204334 --- 3rdparty/libprocess/src/libwinio_impl.cpp Lines 62-74 (patched)

Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.

2018-06-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67421/#review204357 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67463: Fixed type error when using `check_output` in Python 3 scripts.

2018-06-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67463/#review204356 --- PASS: Mesos patch 67463 was successfully built and tested.

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review204347 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67264: Unmounted any dangling persistent volume in gc paths.

2018-06-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67264/#review204328 --- src/slave/gc.cpp Lines 225 (patched)

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review204351 --- Patch looks great! Reviews applied: [67384, 67385, 67386, 67387,

Re: Review Request 67460: Enable stouttest EnvTest.EraseEnv.

2018-06-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67460/#review204352 --- PASS: Mesos patch 67460 was successfully built and tested.

Re: Review Request 67264: Unmounted any mount points in gc paths.

2018-06-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67264/ --- (Updated June 5, 2018, 5:07 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.

2018-06-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67421/ --- (Updated June 5, 2018, 5:08 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 67465: Windows: Log a fatal error if `WindowsFD(int)` is incorrectly used.

2018-06-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67465/#review204353 --- PASS: Mesos patch 67465 was successfully built and tested.

Re: Review Request 67464: Fixed `python3/mesos-style.py`.

2018-06-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67464/#review204354 --- PASS: Mesos patch 67464 was successfully built and tested.

Re: Review Request 67465: Windows: Log a fatal error if `WindowsFD(int)` is incorrectly used.

2018-06-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67465/#review204359 --- Patch looks great! Reviews applied: [67465] Passed command: